[INFO] updating cached repository mmstick/systemd-manager [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mmstick/systemd-manager [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mmstick/systemd-manager" "work/ex/clippy-test-run/sources/stable/gh/mmstick/systemd-manager"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mmstick/systemd-manager'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mmstick/systemd-manager" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmstick/systemd-manager"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmstick/systemd-manager'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 946de585fdd92783788d4e8970b8bcb5bf8e8822 [INFO] sha for GitHub repo mmstick/systemd-manager: 946de585fdd92783788d4e8970b8bcb5bf8e8822 [INFO] validating manifest of mmstick/systemd-manager on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mmstick/systemd-manager on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mmstick/systemd-manager [INFO] finished frobbing mmstick/systemd-manager [INFO] frobbed toml for mmstick/systemd-manager written to work/ex/clippy-test-run/sources/stable/gh/mmstick/systemd-manager/Cargo.toml [INFO] started frobbing mmstick/systemd-manager [INFO] finished frobbing mmstick/systemd-manager [INFO] frobbed toml for mmstick/systemd-manager written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmstick/systemd-manager/Cargo.toml [INFO] crate mmstick/systemd-manager has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mmstick/systemd-manager against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mmstick/systemd-manager:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 55142f0e5085e7fa5456ffb94c0c1f3115e3c205549a5cb320099ea5fec99016 [INFO] running `"docker" "start" "-a" "55142f0e5085e7fa5456ffb94c0c1f3115e3c205549a5cb320099ea5fec99016"` [INFO] [stderr] Checking nodrop v0.1.9 [INFO] [stderr] Checking quickersort v2.2.0 [INFO] [stderr] Checking systemd-manager v1.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/systemd/analyze.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | Analyze { time: time, service: String::from(service) } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/systemd/dbus.rs:112:40 [INFO] [stderr] | [INFO] [stderr] 112 | systemd_units.push(SystemdUnit{name: name, path: path, state: state, utype: utype}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/systemd/dbus.rs:112:52 [INFO] [stderr] | [INFO] [stderr] 112 | systemd_units.push(SystemdUnit{name: name, path: path, state: state, utype: utype}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/systemd/dbus.rs:112:64 [INFO] [stderr] | [INFO] [stderr] 112 | systemd_units.push(SystemdUnit{name: name, path: path, state: state, utype: utype}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/systemd/dbus.rs:112:78 [INFO] [stderr] | [INFO] [stderr] 112 | systemd_units.push(SystemdUnit{name: name, path: path, state: state, utype: utype}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `utype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/systemd/analyze.rs:71:19 [INFO] [stderr] | [INFO] [stderr] 71 | Analyze { time: time, service: String::from(service) } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/systemd/dbus.rs:112:40 [INFO] [stderr] | [INFO] [stderr] 112 | systemd_units.push(SystemdUnit{name: name, path: path, state: state, utype: utype}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/systemd/dbus.rs:112:52 [INFO] [stderr] | [INFO] [stderr] 112 | systemd_units.push(SystemdUnit{name: name, path: path, state: state, utype: utype}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/systemd/dbus.rs:112:64 [INFO] [stderr] | [INFO] [stderr] 112 | systemd_units.push(SystemdUnit{name: name, path: path, state: state, utype: utype}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/systemd/dbus.rs:112:78 [INFO] [stderr] | [INFO] [stderr] 112 | systemd_units.push(SystemdUnit{name: name, path: path, state: state, utype: utype}); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `utype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/systemd/analyze.rs:98:33 [INFO] [stderr] | [INFO] [stderr] 98 | let correct = Analyze{time: 218514, service: String::from("updatedb.service")}; [INFO] [stderr] | ^^^^^^ help: consider: `218_514` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/systemd/dbus.rs:40:26 [INFO] [stderr] | [INFO] [stderr] 40 | .find(|unit| &unit.path == &self.path) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 40 | .find(|unit| unit.path == self.path) [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/gui/gtk3/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | journal.get_buffer().map(|buffer| buffer.set_text(unit.get_journal().as_str())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(buffer) = journal.get_buffer() { buffer.set_text(unit.get_journal().as_str()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/systemd/dbus.rs:40:26 [INFO] [stderr] | [INFO] [stderr] 40 | .find(|unit| &unit.path == &self.path) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 40 | .find(|unit| unit.path == self.path) [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/gui/gtk3/mod.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | journal.get_buffer().map(|buffer| buffer.set_text(unit.get_journal().as_str())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(buffer) = journal.get_buffer() { buffer.set_text(unit.get_journal().as_str()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.59s [INFO] running `"docker" "inspect" "55142f0e5085e7fa5456ffb94c0c1f3115e3c205549a5cb320099ea5fec99016"` [INFO] running `"docker" "rm" "-f" "55142f0e5085e7fa5456ffb94c0c1f3115e3c205549a5cb320099ea5fec99016"` [INFO] [stdout] 55142f0e5085e7fa5456ffb94c0c1f3115e3c205549a5cb320099ea5fec99016