[INFO] updating cached repository mmstick/parallel [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mmstick/parallel [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mmstick/parallel" "work/ex/clippy-test-run/sources/stable/gh/mmstick/parallel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mmstick/parallel'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mmstick/parallel" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmstick/parallel"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmstick/parallel'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c5a0df810acae4ca04bc4c0291e9f0f00309c828 [INFO] sha for GitHub repo mmstick/parallel: c5a0df810acae4ca04bc4c0291e9f0f00309c828 [INFO] validating manifest of mmstick/parallel on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mmstick/parallel on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mmstick/parallel [INFO] finished frobbing mmstick/parallel [INFO] frobbed toml for mmstick/parallel written to work/ex/clippy-test-run/sources/stable/gh/mmstick/parallel/Cargo.toml [INFO] started frobbing mmstick/parallel [INFO] finished frobbing mmstick/parallel [INFO] frobbed toml for mmstick/parallel written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmstick/parallel/Cargo.toml [INFO] crate mmstick/parallel has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mmstick/parallel against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mmstick/parallel:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0ef9845c9bc9c83f65910a47904e2f7bd2e25a4953b2fbd65f538a2cb8087573 [INFO] running `"docker" "start" "-a" "0ef9845c9bc9c83f65910a47904e2f7bd2e25a4953b2fbd65f538a2cb8087573"` [INFO] [stderr] Checking permutate v0.3.2 [INFO] [stderr] Checking numtoa v0.0.7 [INFO] [stderr] Compiling sys-info v0.5.0 [INFO] [stderr] Checking wait-timeout v0.1.5 [INFO] [stderr] Checking arrayvec v0.4.6 [INFO] [stderr] Checking parallel v0.11.3 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:80:25 [INFO] [stderr] | [INFO] [stderr] 80 | let _ = write!(stderr, "delay parameter, '{}', is not a number.\n", arguments[index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | let _ = write!(stderr, "jobs parameter, '{}', is not a number.\n", value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | let _ = write!(stderr, "groups parameter, '{}', is not a number.\n", arguments[index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:104:25 [INFO] [stderr] | [INFO] [stderr] 104 | let _ = write!(stderr, "invalid memory value: {}\n", arguments[index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:107:25 [INFO] [stderr] | [INFO] [stderr] 107 | let _ = write!(stderr, "invalid argument: {}\n", arguments[index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | let _ = write!(stderr, "no input arguments were given.\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | let _ = write!(stderr, "an error occurred while redirecting file: {:?}\n", path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:119:25 [INFO] [stderr] | [INFO] [stderr] 119 | let _ = write!(stderr, "invalid timeout value: {}\n", arguments[index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_buffer/mod.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | file: file, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/argument_splitter.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/dry.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | job_total: job_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `job_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/dry.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/execute/dry.rs:64:33 [INFO] [stderr] | [INFO] [stderr] 64 | let _ = write!(stderr, "parallel: input file read error: {:?}: {}\n", path, why); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_commands.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | job_total: job_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `job_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_commands.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | job_id: job_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `job_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_commands.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_commands.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | exit_value: exit_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exit_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_commands.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | signal: signal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `signal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/execute/exec_inputs.rs:54:29 [INFO] [stderr] | [INFO] [stderr] 54 | let _ = write!(&mut stderr, "parallel: command error: {}: {}\n", input, why); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_inputs.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | job_id: job_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `job_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_inputs.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_inputs.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | exit_value: exit_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exit_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_inputs.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | signal: signal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `signal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_inputs.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/execute/receive.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/input_iterator/lock.rs:53:33 [INFO] [stderr] | [INFO] [stderr] 53 | let _ = write!(stderr, "parallel: input file read error: {:?}: {}\n", path, why); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input_iterator/iterator.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | input_buffer: input_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input_iterator/iterator.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer/mod.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | Number{ id: id, token: token } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer/mod.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | Number{ id: id, token: token } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:194:25 [INFO] [stderr] | [INFO] [stderr] 194 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:225:25 [INFO] [stderr] | [INFO] [stderr] 225 | slot: slot, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `slot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:226:25 [INFO] [stderr] | [INFO] [stderr] 226 | num_inputs: num_inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:227:25 [INFO] [stderr] | [INFO] [stderr] 227 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:228:25 [INFO] [stderr] | [INFO] [stderr] 228 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 229 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | output_tx: output_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:231:25 [INFO] [stderr] | [INFO] [stderr] 231 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:80:25 [INFO] [stderr] | [INFO] [stderr] 80 | let _ = write!(stderr, "delay parameter, '{}', is not a number.\n", arguments[index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:89:25 [INFO] [stderr] | [INFO] [stderr] 89 | let _ = write!(stderr, "jobs parameter, '{}', is not a number.\n", value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:95:25 [INFO] [stderr] | [INFO] [stderr] 95 | let _ = write!(stderr, "groups parameter, '{}', is not a number.\n", arguments[index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:104:25 [INFO] [stderr] | [INFO] [stderr] 104 | let _ = write!(stderr, "invalid memory value: {}\n", arguments[index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:107:25 [INFO] [stderr] | [INFO] [stderr] 107 | let _ = write!(stderr, "invalid argument: {}\n", arguments[index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:110:25 [INFO] [stderr] | [INFO] [stderr] 110 | let _ = write!(stderr, "no input arguments were given.\n"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | let _ = write!(stderr, "an error occurred while redirecting file: {:?}\n", path); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/arguments/errors.rs:119:25 [INFO] [stderr] | [INFO] [stderr] 119 | let _ = write!(stderr, "invalid timeout value: {}\n", arguments[index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk_buffer/mod.rs:37:13 [INFO] [stderr] | [INFO] [stderr] 37 | file: file, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/argument_splitter.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | data: data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/dry.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | job_total: job_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `job_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/dry.rs:50:21 [INFO] [stderr] | [INFO] [stderr] 50 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/execute/dry.rs:64:33 [INFO] [stderr] | [INFO] [stderr] 64 | let _ = write!(stderr, "parallel: input file read error: {:?}: {}\n", path, why); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_commands.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | job_total: job_total, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `job_total` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_commands.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | job_id: job_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `job_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_commands.rs:85:21 [INFO] [stderr] | [INFO] [stderr] 85 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_commands.rs:87:21 [INFO] [stderr] | [INFO] [stderr] 87 | exit_value: exit_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exit_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_commands.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | signal: signal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `signal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/execute/exec_inputs.rs:54:29 [INFO] [stderr] | [INFO] [stderr] 54 | let _ = write!(&mut stderr, "parallel: command error: {}: {}\n", input, why); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_inputs.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | job_id: job_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `job_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_inputs.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_inputs.rs:67:21 [INFO] [stderr] | [INFO] [stderr] 67 | exit_value: exit_value, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exit_value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_inputs.rs:68:21 [INFO] [stderr] | [INFO] [stderr] 68 | signal: signal, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `signal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/execute/exec_inputs.rs:69:21 [INFO] [stderr] | [INFO] [stderr] 69 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/execute/receive.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/input_iterator/lock.rs:53:33 [INFO] [stderr] | [INFO] [stderr] 53 | let _ = write!(stderr, "parallel: input file read error: {:?}: {}\n", path, why); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input_iterator/iterator.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | input_buffer: input_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/input_iterator/iterator.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | left: left, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer/mod.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | Number{ id: id, token: token } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tokenizer/mod.rs:57:25 [INFO] [stderr] | [INFO] [stderr] 57 | Number{ id: id, token: token } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:194:25 [INFO] [stderr] | [INFO] [stderr] 194 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:219:21 [INFO] [stderr] | [INFO] [stderr] 219 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:225:25 [INFO] [stderr] | [INFO] [stderr] 225 | slot: slot, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `slot` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:226:25 [INFO] [stderr] | [INFO] [stderr] 226 | num_inputs: num_inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:227:25 [INFO] [stderr] | [INFO] [stderr] 227 | flags: flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:228:25 [INFO] [stderr] | [INFO] [stderr] 228 | timeout: timeout, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `timeout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:229:25 [INFO] [stderr] | [INFO] [stderr] 229 | inputs: inputs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `inputs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:230:25 [INFO] [stderr] | [INFO] [stderr] 230 | output_tx: output_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:231:25 [INFO] [stderr] | [INFO] [stderr] 231 | arguments: arguments, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/arguments/man.rs:1:22 [INFO] [stderr] | [INFO] [stderr] 1 | pub const MAN_PAGE: &'static str = r#"NAME [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/execute/receive.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | /// Prints messages from executed commands in the correct order. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | /// Wait for all threads to exit before proceeding. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/arguments/man.rs:1:22 [INFO] [stderr] | [INFO] [stderr] 1 | pub const MAN_PAGE: &'static str = r#"NAME [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: lint name `cyclomatic_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/execute/receive.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | #[allow(cyclomatic_complexity)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cyclomatic_complexity` [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/input_iterator/iterator.rs:231:48 [INFO] [stderr] | [INFO] [stderr] 231 | for (actual, expected) in iterator.zip((1..4096)) { [INFO] [stderr] | ^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/input_iterator/iterator.rs:231:48 [INFO] [stderr] | [INFO] [stderr] 231 | for (actual, expected) in iterator.zip((1..4096)) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | /// Prints messages from executed commands in the correct order. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | /// Wait for all threads to exit before proceeding. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/arguments/mod.rs:553:9 [INFO] [stderr] | [INFO] [stderr] 553 | let mut append_list = &mut Vec::new(); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/execute/exec_commands.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut command_buffer = &mut String::with_capacity(64); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/execute/pipe.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | let mut stdout = child.stdout.as_mut().expect("unable to open stdout of child"); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/arguments/mod.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn parse(&mut self, comm: &mut String, arguments: &[String], base_path: &mut PathBuf) [INFO] [stderr] 71 | | -> Result [INFO] [stderr] 72 | | { [INFO] [stderr] 73 | | // Each list will consist of a series of input arguments [INFO] [stderr] ... | [INFO] [stderr] 306 | | Ok(number_of_arguments) [INFO] [stderr] 307 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/arguments/mod.rs:677:54 [INFO] [stderr] | [INFO] [stderr] 677 | if !line.is_empty() && !line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/execute/child.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn handle_child(mut child: Child, output: &Sender, flags: u16, job_id: usize, input: String, [INFO] [stderr] 14 | | has_timeout: bool, timeout: Duration, base: &str, buffer: &mut [u8]) -> (Timespec, Timespec, i32, i32) [INFO] [stderr] 15 | | { [INFO] [stderr] 16 | | let start_time = get_time(); [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/input_iterator/iterator.rs:77:40 [INFO] [stderr] | [INFO] [stderr] 77 | InputIteratorErr::FileRead(PathBuf::from(self.input_buffer.disk_buffer.path.clone()), why) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `self.input_buffer.disk_buffer.path.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tokenizer/mod.rs:123:87 [INFO] [stderr] | [INFO] [stderr] 123 | None => { tokens.push(Token::Argument(Cow::Borrowed(&template[pattern_start..id+1]))); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `pattern_start..=id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | if let Ok(_) = file.read_exact(&mut buffer) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 62 | | if &buffer == b"[a" { [INFO] [stderr] 63 | | let _ = writeln!(stderr.lock(), "ion: /sys/kernel/mm/transparent_hugepage/enabled is set to always instead of madvise. This will gravely effect the performance of Parallel."); [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____________- help: try this: `if file.read_exact(&mut buffer).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:206:25 [INFO] [stderr] | [INFO] [stderr] 206 | for slot in 1..args.ncores+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `1..=args.ncores` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/arguments/mod.rs:553:9 [INFO] [stderr] | [INFO] [stderr] 553 | let mut append_list = &mut Vec::new(); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/execute/exec_commands.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | let mut command_buffer = &mut String::with_capacity(64); [INFO] [stderr] | ----^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/execute/pipe.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | let mut stdout = child.stdout.as_mut().expect("unable to open stdout of child"); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 31 [INFO] [stderr] --> src/arguments/mod.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / pub fn parse(&mut self, comm: &mut String, arguments: &[String], base_path: &mut PathBuf) [INFO] [stderr] 71 | | -> Result [INFO] [stderr] 72 | | { [INFO] [stderr] 73 | | // Each list will consist of a series of input arguments [INFO] [stderr] ... | [INFO] [stderr] 306 | | Ok(number_of_arguments) [INFO] [stderr] 307 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/arguments/mod.rs:677:54 [INFO] [stderr] | [INFO] [stderr] 677 | if !line.is_empty() && !line.starts_with("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/execute/child.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | / pub fn handle_child(mut child: Child, output: &Sender, flags: u16, job_id: usize, input: String, [INFO] [stderr] 14 | | has_timeout: bool, timeout: Duration, base: &str, buffer: &mut [u8]) -> (Timespec, Timespec, i32, i32) [INFO] [stderr] 15 | | { [INFO] [stderr] 16 | | let start_time = get_time(); [INFO] [stderr] ... | [INFO] [stderr] 30 | | } [INFO] [stderr] 31 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/input_iterator/iterator.rs:77:40 [INFO] [stderr] | [INFO] [stderr] 77 | InputIteratorErr::FileRead(PathBuf::from(self.input_buffer.disk_buffer.path.clone()), why) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `self.input_buffer.disk_buffer.path.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/tokenizer/mod.rs:123:87 [INFO] [stderr] | [INFO] [stderr] 123 | None => { tokens.push(Token::Argument(Cow::Borrowed(&template[pattern_start..id+1]))); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: use: `pattern_start..=id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/main.rs:61:20 [INFO] [stderr] | [INFO] [stderr] 61 | if let Ok(_) = file.read_exact(&mut buffer) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 62 | | if &buffer == b"[a" { [INFO] [stderr] 63 | | let _ = writeln!(stderr.lock(), "ion: /sys/kernel/mm/transparent_hugepage/enabled is set to always instead of madvise. This will gravely effect the performance of Parallel."); [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____________- help: try this: `if file.read_exact(&mut buffer).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:206:25 [INFO] [stderr] | [INFO] [stderr] 206 | for slot in 1..args.ncores+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `1..=args.ncores` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.34s [INFO] running `"docker" "inspect" "0ef9845c9bc9c83f65910a47904e2f7bd2e25a4953b2fbd65f538a2cb8087573"` [INFO] running `"docker" "rm" "-f" "0ef9845c9bc9c83f65910a47904e2f7bd2e25a4953b2fbd65f538a2cb8087573"` [INFO] [stdout] 0ef9845c9bc9c83f65910a47904e2f7bd2e25a4953b2fbd65f538a2cb8087573