[INFO] updating cached repository mmarkell/rust_sat [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mmarkell/rust_sat [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mmarkell/rust_sat" "work/ex/clippy-test-run/sources/stable/gh/mmarkell/rust_sat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mmarkell/rust_sat'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mmarkell/rust_sat" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmarkell/rust_sat"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmarkell/rust_sat'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 150d0e00a58c2b9c89356bcb28fa31db120b3867 [INFO] sha for GitHub repo mmarkell/rust_sat: 150d0e00a58c2b9c89356bcb28fa31db120b3867 [INFO] validating manifest of mmarkell/rust_sat on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mmarkell/rust_sat on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mmarkell/rust_sat [INFO] finished frobbing mmarkell/rust_sat [INFO] frobbed toml for mmarkell/rust_sat written to work/ex/clippy-test-run/sources/stable/gh/mmarkell/rust_sat/Cargo.toml [INFO] started frobbing mmarkell/rust_sat [INFO] finished frobbing mmarkell/rust_sat [INFO] frobbed toml for mmarkell/rust_sat written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmarkell/rust_sat/Cargo.toml [INFO] crate mmarkell/rust_sat has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mmarkell/rust_sat against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mmarkell/rust_sat:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3611cc125537576fc684bd44a32297119e8310093744a38fa80c62bc996d58ca [INFO] running `"docker" "start" "-a" "3611cc125537576fc684bd44a32297119e8310093744a38fa80c62bc996d58ca"` [INFO] [stderr] Checking sat_solver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | clauses: clauses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `clauses` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | units: units, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `units` [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | clauses: clauses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `clauses` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver.rs:50:78 [INFO] [stderr] | [INFO] [stderr] 50 | let ((l, r), s) = solve((encoder::FORMULA {clauses: new_clauses, units: units}, used_vars, left_new)); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `units` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver.rs:273:36 [INFO] [stderr] | [INFO] [stderr] 273 | return (encoder::FORMULA { clauses: clauses, units: new_units }, return_pure_literals); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `clauses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | units: units, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `units` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver.rs:50:78 [INFO] [stderr] | [INFO] [stderr] 50 | let ((l, r), s) = solve((encoder::FORMULA {clauses: new_clauses, units: units}, used_vars, left_new)); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `units` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/solver.rs:273:36 [INFO] [stderr] | [INFO] [stderr] 273 | return (encoder::FORMULA { clauses: clauses, units: new_units }, return_pure_literals); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `clauses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoder.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return (test_s(test_descriptor), 0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(test_s(test_descriptor), 0, 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoder.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / return FORMULA { [INFO] [stderr] 19 | | clauses: clauses, [INFO] [stderr] 20 | | units: units, [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 18 | FORMULA { [INFO] [stderr] 19 | clauses: clauses, [INFO] [stderr] 20 | units: units, [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoder.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return FORMULA::new(clauses, units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FORMULA::new(clauses, units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return (Vec::new(), Vec::new(), width, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Vec::new(), Vec::new(), width, height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return (positive, negative, width, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(positive, negative, width, height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return ((Vec::new(), Vec::new()), false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((Vec::new(), Vec::new()), false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/solver.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | new_vars.remove((idx as usize)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/solver.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | new_vars.remove((idx as usize)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:91:33 [INFO] [stderr] | [INFO] [stderr] 91 | Some(&(_, location)) => return (most_common, location), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(most_common, location)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | _ => return (0, 0), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `(0, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | return (positives, negatives); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(positives, negatives)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/solver.rs:114:16 [INFO] [stderr] | [INFO] [stderr] 114 | } else if v < 0 { [INFO] [stderr] | ________________^ [INFO] [stderr] 115 | | if !negatives.contains(&v) { [INFO] [stderr] 116 | | negatives.push(v); [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 114 | } else if v < 0 && !negatives.contains(&v) { [INFO] [stderr] 115 | negatives.push(v); [INFO] [stderr] 116 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | return (encoder::FORMULA {clauses: clauses_clone, units: formula.units }, Vec::new(), variables); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(encoder::FORMULA {clauses: clauses_clone, units: formula.units }, Vec::new(), variables)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | return encoder::FORMULA {clauses: formula.clauses, units: formula.units}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `encoder::FORMULA {clauses: formula.clauses, units: formula.units}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | return clause.iter().any(|v| (*v == u)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `clause.iter().any(|v| (*v == u))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:279:5 [INFO] [stderr] | [INFO] [stderr] 279 | return remove_pure_clauses(new_clauses, pure_clauses(clauses, units), formula.units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `remove_pure_clauses(new_clauses, pure_clauses(clauses, units), formula.units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | return remove; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `remove` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/solver.rs:231:50 [INFO] [stderr] | [INFO] [stderr] 231 | if occurrences.contains_key(&((elem * -1))) && !(non_pure.contains(&elem)) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | return (encoder::FORMULA { clauses: clauses, units: new_units }, return_pure_literals); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(encoder::FORMULA { clauses: clauses, units: new_units }, return_pure_literals)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | return !clause.iter().any(|v| (*v == *u)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!clause.iter().any(|v| (*v == *u))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoder.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | return (test_s(test_descriptor), 0, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(test_s(test_descriptor), 0, 0)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoder.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | / return FORMULA { [INFO] [stderr] 19 | | clauses: clauses, [INFO] [stderr] 20 | | units: units, [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 18 | FORMULA { [INFO] [stderr] 19 | clauses: clauses, [INFO] [stderr] 20 | units: units, [INFO] [stderr] 21 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/encoder.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | return FORMULA::new(clauses, units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `FORMULA::new(clauses, units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:10:9 [INFO] [stderr] | [INFO] [stderr] 10 | return (Vec::new(), Vec::new(), width, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(Vec::new(), Vec::new(), width, height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return (positive, negative, width, height); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(positive, negative, width, height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return ((Vec::new(), Vec::new()), false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `((Vec::new(), Vec::new()), false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/solver.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | new_vars.remove((idx as usize)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/solver.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | new_vars.remove((idx as usize)); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:91:33 [INFO] [stderr] | [INFO] [stderr] 91 | Some(&(_, location)) => return (most_common, location), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(most_common, location)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:92:14 [INFO] [stderr] | [INFO] [stderr] 92 | _ => return (0, 0), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `(0, 0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | return (positives, negatives); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(positives, negatives)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/solver.rs:114:16 [INFO] [stderr] | [INFO] [stderr] 114 | } else if v < 0 { [INFO] [stderr] | ________________^ [INFO] [stderr] 115 | | if !negatives.contains(&v) { [INFO] [stderr] 116 | | negatives.push(v); [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 114 | } else if v < 0 && !negatives.contains(&v) { [INFO] [stderr] 115 | negatives.push(v); [INFO] [stderr] 116 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:154:5 [INFO] [stderr] | [INFO] [stderr] 154 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | return (encoder::FORMULA {clauses: clauses_clone, units: formula.units }, Vec::new(), variables); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(encoder::FORMULA {clauses: clauses_clone, units: formula.units }, Vec::new(), variables)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:218:5 [INFO] [stderr] | [INFO] [stderr] 218 | return encoder::FORMULA {clauses: formula.clauses, units: formula.units}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `encoder::FORMULA {clauses: formula.clauses, units: formula.units}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:180:9 [INFO] [stderr] | [INFO] [stderr] 180 | return clause.iter().any(|v| (*v == u)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `clause.iter().any(|v| (*v == u))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:279:5 [INFO] [stderr] | [INFO] [stderr] 279 | return remove_pure_clauses(new_clauses, pure_clauses(clauses, units), formula.units); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `remove_pure_clauses(new_clauses, pure_clauses(clauses, units), formula.units)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:254:13 [INFO] [stderr] | [INFO] [stderr] 254 | return remove; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `remove` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/solver.rs:231:50 [INFO] [stderr] | [INFO] [stderr] 231 | if occurrences.contains_key(&((elem * -1))) && !(non_pure.contains(&elem)) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | return (encoder::FORMULA { clauses: clauses, units: new_units }, return_pure_literals); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(encoder::FORMULA { clauses: clauses, units: new_units }, return_pure_literals)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/solver.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | return !clause.iter().any(|v| (*v == *u)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `!clause.iter().any(|v| (*v == *u))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `width` [INFO] [stderr] --> src/encoder.rs:53:45 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn format_output((positives, negatives, width, height): (Vec, Vec, i32, i32)) { [INFO] [stderr] | ^^^^^ help: consider using `_width` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `height` [INFO] [stderr] --> src/encoder.rs:53:52 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn format_output((positives, negatives, width, height): (Vec, Vec, i32, i32)) { [INFO] [stderr] | ^^^^^^ help: consider using `_height` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `last_seen` [INFO] [stderr] --> src/solver.rs:73:33 [INFO] [stderr] | [INFO] [stderr] 73 | Some(&(occurrences, last_seen)) => { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_last_seen` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `width` [INFO] [stderr] --> src/encoder.rs:53:45 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn format_output((positives, negatives, width, height): (Vec, Vec, i32, i32)) { [INFO] [stderr] | ^^^^^ help: consider using `_width` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `height` [INFO] [stderr] --> src/encoder.rs:53:52 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn format_output((positives, negatives, width, height): (Vec, Vec, i32, i32)) { [INFO] [stderr] | ^^^^^^ help: consider using `_height` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `last_seen` [INFO] [stderr] --> src/solver.rs:73:33 [INFO] [stderr] | [INFO] [stderr] 73 | Some(&(occurrences, last_seen)) => { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_last_seen` instead [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/encoder.rs:30:33 [INFO] [stderr] | [INFO] [stderr] 30 | for line in test_case.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/encoder.rs:32:29 [INFO] [stderr] | [INFO] [stderr] 32 | for l in line.split(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/solver.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | if s == true || x == 0 { [INFO] [stderr] | ^^^^^^^^^ help: try simplifying it as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | old_used.push(-1 * x); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: the variable `idx` is used as a loop counter. Consider using `for (idx, item) in vars.enumerate()` or similar iterators [INFO] [stderr] --> src/solver.rs:71:16 [INFO] [stderr] | [INFO] [stderr] 71 | for var in vars { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:99:33 [INFO] [stderr] | [INFO] [stderr] 99 | if clone_vars.contains(&(-1 * input)) && input != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:136:73 [INFO] [stderr] | [INFO] [stderr] 136 | if !(input_vars.contains(&variable) || input_vars.contains(&(-1 * variable))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:164:37 [INFO] [stderr] | [INFO] [stderr] 164 | if !variables.contains(&(-1 * v)) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:170:33 [INFO] [stderr] | [INFO] [stderr] 170 | if !variables.contains(&(-1 * u)) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:195:47 [INFO] [stderr] | [INFO] [stderr] 195 | } else if contains(copy_clause_3, -1 * unit) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:196:32 [INFO] [stderr] | [INFO] [stderr] 196 | to_remove.push(-1 * unit); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:231:50 [INFO] [stderr] | [INFO] [stderr] 231 | if occurrences.contains_key(&((elem * -1))) && !(non_pure.contains(&elem)) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:233:39 [INFO] [stderr] | [INFO] [stderr] 233 | non_pure.push(-1 * elem); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:249:70 [INFO] [stderr] | [INFO] [stderr] 249 | if !non_pure.contains(&elem) && !units.contains(&(-1 * elem)) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/solver.rs:264:36 [INFO] [stderr] | [INFO] [stderr] 264 | fn not_in(u: &i32, clause: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:264:22 [INFO] [stderr] | [INFO] [stderr] 264 | fn not_in(u: &i32, clause: &Vec) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/solver.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | for ref r in pure_literals { [INFO] [stderr] | ^^^^^ ------------- help: try: `let r = &pure_literals;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/encoder.rs:30:33 [INFO] [stderr] | [INFO] [stderr] 30 | for line in test_case.split("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/encoder.rs:32:29 [INFO] [stderr] | [INFO] [stderr] 32 | for l in line.split(" ") { [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/solver.rs:51:16 [INFO] [stderr] | [INFO] [stderr] 51 | if s == true || x == 0 { [INFO] [stderr] | ^^^^^^^^^ help: try simplifying it as shown: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:54:31 [INFO] [stderr] | [INFO] [stderr] 54 | old_used.push(-1 * x); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::neg_multiply)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: the variable `idx` is used as a loop counter. Consider using `for (idx, item) in vars.enumerate()` or similar iterators [INFO] [stderr] --> src/solver.rs:71:16 [INFO] [stderr] | [INFO] [stderr] 71 | for var in vars { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:99:33 [INFO] [stderr] | [INFO] [stderr] 99 | if clone_vars.contains(&(-1 * input)) && input != 0 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:136:73 [INFO] [stderr] | [INFO] [stderr] 136 | if !(input_vars.contains(&variable) || input_vars.contains(&(-1 * variable))) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:164:37 [INFO] [stderr] | [INFO] [stderr] 164 | if !variables.contains(&(-1 * v)) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:170:33 [INFO] [stderr] | [INFO] [stderr] 170 | if !variables.contains(&(-1 * u)) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:195:47 [INFO] [stderr] | [INFO] [stderr] 195 | } else if contains(copy_clause_3, -1 * unit) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:196:32 [INFO] [stderr] | [INFO] [stderr] 196 | to_remove.push(-1 * unit); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:231:50 [INFO] [stderr] | [INFO] [stderr] 231 | if occurrences.contains_key(&((elem * -1))) && !(non_pure.contains(&elem)) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:233:39 [INFO] [stderr] | [INFO] [stderr] 233 | non_pure.push(-1 * elem); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: Negation by multiplying with -1 [INFO] [stderr] --> src/solver.rs:249:70 [INFO] [stderr] | [INFO] [stderr] 249 | if !non_pure.contains(&elem) && !units.contains(&(-1 * elem)) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/solver.rs:264:36 [INFO] [stderr] | [INFO] [stderr] 264 | fn not_in(u: &i32, clause: &Vec) -> bool { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i32]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/solver.rs:264:22 [INFO] [stderr] | [INFO] [stderr] 264 | fn not_in(u: &i32, clause: &Vec) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `i32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/solver.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | for ref r in pure_literals { [INFO] [stderr] | ^^^^^ ------------- help: try: `let r = &pure_literals;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.93s [INFO] running `"docker" "inspect" "3611cc125537576fc684bd44a32297119e8310093744a38fa80c62bc996d58ca"` [INFO] running `"docker" "rm" "-f" "3611cc125537576fc684bd44a32297119e8310093744a38fa80c62bc996d58ca"` [INFO] [stdout] 3611cc125537576fc684bd44a32297119e8310093744a38fa80c62bc996d58ca