[INFO] updating cached repository mmajko/knapsack-problem [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mmajko/knapsack-problem [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mmajko/knapsack-problem" "work/ex/clippy-test-run/sources/stable/gh/mmajko/knapsack-problem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mmajko/knapsack-problem'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mmajko/knapsack-problem" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmajko/knapsack-problem"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmajko/knapsack-problem'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 11cdd693800848f8d688ce82a5444f0e12f56b04 [INFO] sha for GitHub repo mmajko/knapsack-problem: 11cdd693800848f8d688ce82a5444f0e12f56b04 [INFO] validating manifest of mmajko/knapsack-problem on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mmajko/knapsack-problem on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mmajko/knapsack-problem [INFO] finished frobbing mmajko/knapsack-problem [INFO] frobbed toml for mmajko/knapsack-problem written to work/ex/clippy-test-run/sources/stable/gh/mmajko/knapsack-problem/Cargo.toml [INFO] started frobbing mmajko/knapsack-problem [INFO] finished frobbing mmajko/knapsack-problem [INFO] frobbed toml for mmajko/knapsack-problem written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmajko/knapsack-problem/Cargo.toml [INFO] crate mmajko/knapsack-problem has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mmajko/knapsack-problem against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mmajko/knapsack-problem:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 427c9d0aa1d6d36c15a10d500714d48aadfb846f2d95f492e3b27c7d646db772 [INFO] running `"docker" "start" "-a" "427c9d0aa1d6d36c15a10d500714d48aadfb846f2d95f492e3b27c7d646db772"` [INFO] [stderr] Checking knapsack-problem v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | items: items, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `items` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return val.parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `val.parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / return Knapsack { [INFO] [stderr] 53 | | id: props[0], [INFO] [stderr] 54 | | capacity: props[2], [INFO] [stderr] 55 | | items: items, [INFO] [stderr] ... | [INFO] [stderr] 58 | | elapsed: 0.0, [INFO] [stderr] 59 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | Knapsack { [INFO] [stderr] 53 | id: props[0], [INFO] [stderr] 54 | capacity: props[2], [INFO] [stderr] 55 | items: items, [INFO] [stderr] 56 | config: (props[2], items_count), [INFO] [stderr] 57 | price: 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `solvers::recursive` [INFO] [stderr] --> src/solvers/dynamic.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use solvers::recursive; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `KnapItem`, `sum_of_prices` [INFO] [stderr] --> src/solvers/recursive.rs:1:14 [INFO] [stderr] | [INFO] [stderr] 1 | use parser::{sum_of_prices, Knapsack, KnapItem}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solvers/mod.rs:29:107 [INFO] [stderr] | [INFO] [stderr] 29 | solved.elapsed = if elapsed_t.num_milliseconds() <= 1 { elapsed_t.num_nanoseconds().unwrap() as f32 / 1000000.0 } else { elapsed_t.num_milliseconds() as f32 }; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `inspect` [INFO] [stderr] --> src/genetic/mod.rs:6:48 [INFO] [stderr] | [INFO] [stderr] 6 | use self::utils::{odds_are, random_individual, inspect, sort_population}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / return BufReader::new(match File::open(file_path) { [INFO] [stderr] 18 | | Ok(file) => file, [INFO] [stderr] 19 | | Err(err) => panic!("File {} can't be opened: {}", file_path, err), [INFO] [stderr] 20 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | BufReader::new(match File::open(file_path) { [INFO] [stderr] 18 | Ok(file) => file, [INFO] [stderr] 19 | Err(err) => panic!("File {} can't be opened: {}", file_path, err), [INFO] [stderr] 20 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | return val.parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `val.parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | / return Knapsack { [INFO] [stderr] 53 | | id: props[0], [INFO] [stderr] 54 | | capacity: props[2], [INFO] [stderr] 55 | | items: items, [INFO] [stderr] ... | [INFO] [stderr] 58 | | elapsed: 0.0, [INFO] [stderr] 59 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 52 | Knapsack { [INFO] [stderr] 53 | id: props[0], [INFO] [stderr] 54 | capacity: props[2], [INFO] [stderr] 55 | items: items, [INFO] [stderr] 56 | config: (props[2], items_count), [INFO] [stderr] 57 | price: 0, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `solvers::recursive` [INFO] [stderr] --> src/solvers/dynamic.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use solvers::recursive; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `KnapItem`, `sum_of_prices` [INFO] [stderr] --> src/solvers/recursive.rs:1:14 [INFO] [stderr] | [INFO] [stderr] 1 | use parser::{sum_of_prices, Knapsack, KnapItem}; [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/solvers/mod.rs:29:107 [INFO] [stderr] | [INFO] [stderr] 29 | solved.elapsed = if elapsed_t.num_milliseconds() <= 1 { elapsed_t.num_nanoseconds().unwrap() as f32 / 1000000.0 } else { elapsed_t.num_milliseconds() as f32 }; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `inspect` [INFO] [stderr] --> src/genetic/mod.rs:6:48 [INFO] [stderr] | [INFO] [stderr] 6 | use self::utils::{odds_are, random_individual, inspect, sort_population}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / return BufReader::new(match File::open(file_path) { [INFO] [stderr] 18 | | Ok(file) => file, [INFO] [stderr] 19 | | Err(err) => panic!("File {} can't be opened: {}", file_path, err), [INFO] [stderr] 20 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 17 | BufReader::new(match File::open(file_path) { [INFO] [stderr] 18 | Ok(file) => file, [INFO] [stderr] 19 | Err(err) => panic!("File {} can't be opened: {}", file_path, err), [INFO] [stderr] 20 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/solvers/mod.rs:60:72 [INFO] [stderr] | [INFO] [stderr] 60 | let new_items = knap.items.clone().iter().enumerate().filter(|&(i, x)| bits[i]) [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/solvers/mod.rs:61:28 [INFO] [stderr] | [INFO] [stderr] 61 | .map(|(i, x)| *x).collect(); [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pop_size` [INFO] [stderr] --> src/genetic/selectors.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let pop_size = population.len(); [INFO] [stderr] | ^^^^^^^^ help: consider using `_pop_size` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `generation` [INFO] [stderr] --> src/genetic/utils.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn inspect(generation: usize, sorted_population: &Vec>, fitness_fn: &F) where F: Fn(&Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_generation` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `elitism_count` [INFO] [stderr] --> src/genetic/mod.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let elitism_count = 2; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_elitism_count` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/genetic/mod.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | for i in 0..500 { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/reporter.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let mut stype = String::from(format!("{:?}", solution)); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `x` [INFO] [stderr] --> src/solvers/mod.rs:60:72 [INFO] [stderr] | [INFO] [stderr] 60 | let new_items = knap.items.clone().iter().enumerate().filter(|&(i, x)| bits[i]) [INFO] [stderr] | ^ help: consider using `_x` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/solvers/mod.rs:61:28 [INFO] [stderr] | [INFO] [stderr] 61 | .map(|(i, x)| *x).collect(); [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `pop_size` [INFO] [stderr] --> src/genetic/selectors.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let pop_size = population.len(); [INFO] [stderr] | ^^^^^^^^ help: consider using `_pop_size` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `generation` [INFO] [stderr] --> src/genetic/utils.rs:34:19 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn inspect(generation: usize, sorted_population: &Vec>, fitness_fn: &F) where F: Fn(&Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_generation` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `elitism_count` [INFO] [stderr] --> src/genetic/mod.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | let elitism_count = 2; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_elitism_count` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/genetic/mod.rs:21:9 [INFO] [stderr] | [INFO] [stderr] 21 | for i in 0..500 { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `None` [INFO] [stderr] --> src/parser.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | None, [INFO] [stderr] | ^^^^ [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/reporter.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let mut stype = String::from(format!("{:?}", solution)); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FPTAS25` [INFO] [stderr] --> src/parser.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | FPTAS25, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FPTAS75` [INFO] [stderr] --> src/parser.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | FPTAS75, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `inspect` [INFO] [stderr] --> src/genetic/utils.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn inspect(generation: usize, sorted_population: &Vec>, fitness_fn: &F) where F: Fn(&Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn sum_of_prices(items: &Vec) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[KnapItem]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reporter.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | let mut stype = String::from(format!("{:?}", solution)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{:?}", solution)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/solvers/branchandbound.rs:6:8 [INFO] [stderr] | [INFO] [stderr] 6 | if knap.items.len() <= 0 { return knap; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using knap.items.len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/solvers/branchandbound.rs:14:8 [INFO] [stderr] | [INFO] [stderr] 14 | if best < &mut top { [INFO] [stderr] | ^^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `top` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solvers/branchandbound.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | *best = knapsack_with_sol.price.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `knapsack_with_sol.price` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solvers/branchandbound.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | *best = knapsack_wout_sol.price.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `knapsack_wout_sol.price` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/solvers/fptas.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | let ratio = (1.0 - accuracy) * max_price as f32 / knap.items.len() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(max_price)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/solvers/fptas.rs:13:61 [INFO] [stderr] | [INFO] [stderr] 13 | id: item.id, weight: item.weight, price: f32::floor(item.price as f32 / ratio) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(item.price)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/solvers/fptas.rs:20:33 [INFO] [stderr] | [INFO] [stderr] 20 | solution.price = f32::floor(solution.price as f32 * ratio) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(solution.price)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/solvers/recursive.rs:21:8 [INFO] [stderr] | [INFO] [stderr] 21 | if knap.items.len() <= 0 { return knap; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using knap.items.len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `None` [INFO] [stderr] --> src/parser.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | None, [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FPTAS25` [INFO] [stderr] --> src/parser.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | FPTAS25, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `FPTAS75` [INFO] [stderr] --> src/parser.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | FPTAS75, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `inspect` [INFO] [stderr] --> src/genetic/utils.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn inspect(generation: usize, sorted_population: &Vec>, fitness_fn: &F) where F: Fn(&Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `individual`. [INFO] [stderr] --> src/genetic/mutators.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | for i in 0..individual.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 4 | for in &mut individual { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/genetic/selectors.rs:3:34 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn tournament(population: &Vec>, tournaments: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/genetic/utils.rs:8:39 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn sort_population(population: &Vec>, fitness_fn: &F) -> Vec> [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 8 | pub fn sort_population(population: &[Vec], fitness_fn: &F) -> Vec> [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:35:29 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn sum_of_prices(items: &Vec) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[KnapItem]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] help: change `population.clone()` to [INFO] [stderr] | [INFO] [stderr] 10| let mut sorted = population.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/genetic/utils.rs:21:38 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn random_individual(population: &Vec>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/genetic/utils.rs:34:57 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn inspect(generation: usize, sorted_population: &Vec>, fitness_fn: &F) where F: Fn(&Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 34 | pub fn inspect(generation: usize, sorted_population: &[Vec], fitness_fn: &F) where F: Fn(&Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] help: change `sorted_population.clone()` to [INFO] [stderr] | [INFO] [stderr] 35 | let mut pop = sorted_population.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/genetic/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | / let mut child: Vec; [INFO] [stderr] 35 | | [INFO] [stderr] 36 | | // Mate or select a random individual [INFO] [stderr] 37 | | if odds_are(xover_probability) { [INFO] [stderr] ... | [INFO] [stderr] 45 | | child = random_individual(&population); [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let child = if odds_are(xover_probability) { ..; crossover::single_point(in1, in2) } else { random_individual(&population) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/reporter.rs:22:21 [INFO] [stderr] | [INFO] [stderr] 22 | let mut stype = String::from(format!("{:?}", solution)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{:?}", solution)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/solvers/branchandbound.rs:6:8 [INFO] [stderr] | [INFO] [stderr] 6 | if knap.items.len() <= 0 { return knap; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using knap.items.len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/solvers/branchandbound.rs:14:8 [INFO] [stderr] | [INFO] [stderr] 14 | if best < &mut top { [INFO] [stderr] | ^^^^^^^-------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `top` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solvers/branchandbound.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | *best = knapsack_with_sol.price.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `knapsack_with_sol.price` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/solvers/branchandbound.rs:23:21 [INFO] [stderr] | [INFO] [stderr] 23 | *best = knapsack_wout_sol.price.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `knapsack_wout_sol.price` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/solvers/fptas.rs:8:36 [INFO] [stderr] | [INFO] [stderr] 8 | let ratio = (1.0 - accuracy) * max_price as f32 / knap.items.len() as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f32::from(max_price)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Could not compile `knapsack-problem`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/solvers/fptas.rs:13:61 [INFO] [stderr] | [INFO] [stderr] 13 | id: item.id, weight: item.weight, price: f32::floor(item.price as f32 / ratio) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f32::from(item.price)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/solvers/fptas.rs:20:33 [INFO] [stderr] | [INFO] [stderr] 20 | solution.price = f32::floor(solution.price as f32 * ratio) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(solution.price)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/solvers/recursive.rs:21:8 [INFO] [stderr] | [INFO] [stderr] 21 | if knap.items.len() <= 0 { return knap; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using knap.items.len() == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `individual`. [INFO] [stderr] --> src/genetic/mutators.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | for i in 0..individual.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 4 | for in &mut individual { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/genetic/selectors.rs:3:34 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn tournament(population: &Vec>, tournaments: usize, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/genetic/utils.rs:8:39 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn sort_population(population: &Vec>, fitness_fn: &F) -> Vec> [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 8 | pub fn sort_population(population: &[Vec], fitness_fn: &F) -> Vec> [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] help: change `population.clone()` to [INFO] [stderr] | [INFO] [stderr] 10| let mut sorted = population.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/genetic/utils.rs:21:38 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn random_individual(population: &Vec>) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/genetic/utils.rs:34:57 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn inspect(generation: usize, sorted_population: &Vec>, fitness_fn: &F) where F: Fn(&Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 34 | pub fn inspect(generation: usize, sorted_population: &[Vec], fitness_fn: &F) where F: Fn(&Vec) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] help: change `sorted_population.clone()` to [INFO] [stderr] | [INFO] [stderr] 35 | let mut pop = sorted_population.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/genetic/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | / let mut child: Vec; [INFO] [stderr] 35 | | [INFO] [stderr] 36 | | // Mate or select a random individual [INFO] [stderr] 37 | | if odds_are(xover_probability) { [INFO] [stderr] ... | [INFO] [stderr] 45 | | child = random_individual(&population); [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let child = if odds_are(xover_probability) { ..; crossover::single_point(in1, in2) } else { random_individual(&population) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `knapsack-problem`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "427c9d0aa1d6d36c15a10d500714d48aadfb846f2d95f492e3b27c7d646db772"` [INFO] running `"docker" "rm" "-f" "427c9d0aa1d6d36c15a10d500714d48aadfb846f2d95f492e3b27c7d646db772"` [INFO] [stdout] 427c9d0aa1d6d36c15a10d500714d48aadfb846f2d95f492e3b27c7d646db772