[INFO] updating cached repository mmacedoeu/hello
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mmacedoeu/hello
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mmacedoeu/hello" "work/ex/clippy-test-run/sources/stable/gh/mmacedoeu/hello"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mmacedoeu/hello'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mmacedoeu/hello" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmacedoeu/hello"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmacedoeu/hello'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 912818b2b15e56e78eb0429db5bc9f8ce2256693
[INFO] sha for GitHub repo mmacedoeu/hello: 912818b2b15e56e78eb0429db5bc9f8ce2256693
[INFO] validating manifest of mmacedoeu/hello on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mmacedoeu/hello on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mmacedoeu/hello
[INFO] finished frobbing mmacedoeu/hello
[INFO] frobbed toml for mmacedoeu/hello written to work/ex/clippy-test-run/sources/stable/gh/mmacedoeu/hello/Cargo.toml
[INFO] started frobbing mmacedoeu/hello
[INFO] finished frobbing mmacedoeu/hello
[INFO] frobbed toml for mmacedoeu/hello written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mmacedoeu/hello/Cargo.toml
[INFO] crate mmacedoeu/hello has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mmacedoeu/hello against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mmacedoeu/hello:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d887dd14509191f7292c1e141a341650a9bf7e2fc2afef6007752c6156ec4ec2
[INFO] running `"docker" "start" "-a" "d887dd14509191f7292c1e141a341650a9bf7e2fc2afef6007752c6156ec4ec2"`
[INFO] [stderr]     Checking xdg v2.1.0
[INFO] [stderr]     Checking target_info v0.1.0
[INFO] [stderr]     Checking hostname v0.1.4
[INFO] [stderr]    Compiling backtrace-sys v0.1.19
[INFO] [stderr]    Compiling miniz_oxide_c_api v0.1.2
[INFO] [stderr]    Compiling syntex_fmt_macros v0.5.0
[INFO] [stderr]    Compiling actix-web v0.6.10
[INFO] [stderr]    Compiling time v0.1.40
[INFO] [stderr]     Checking miniz_oxide v0.1.2
[INFO] [stderr]     Checking bytes v0.4.7
[INFO] [stderr]     Checking parking_lot_core v0.2.14
[INFO] [stderr]     Checking uuid v0.6.4
[INFO] [stderr]    Compiling tempdir v0.3.7
[INFO] [stderr]    Compiling rand v0.3.22
[INFO] [stderr]    Compiling serde v1.0.59
[INFO] [stderr]     Checking resolv-conf v0.6.0
[INFO] [stderr]     Checking clap v2.31.2
[INFO] [stderr]     Checking app_dirs v1.2.1
[INFO] [stderr]     Checking brotli-sys v0.3.2
[INFO] [stderr]    Compiling syn v0.14.0
[INFO] [stderr]     Checking parking_lot v0.5.5
[INFO] [stderr]    Compiling actix_derive v0.2.0
[INFO] [stderr]     Checking regex v1.0.0
[INFO] [stderr]     Checking tokio-io v0.1.6
[INFO] [stderr]     Checking http v0.1.5
[INFO] [stderr]    Compiling vergen v0.1.1
[INFO] [stderr]     Checking brotli2 v0.3.2
[INFO] [stderr]     Checking cookie v0.10.1
[INFO] [stderr]     Checking serde_urlencoded v0.5.2
[INFO] [stderr]     Checking crossbeam-channel v0.1.3
[INFO] [stderr]     Checking tokio-reactor v0.1.1
[INFO] [stderr]     Checking env_logger v0.5.10
[INFO] [stderr]     Checking tokio-fs v0.1.0
[INFO] [stderr]    Compiling hello v0.1.0 (/opt/crater/workdir)
[INFO] [stderr]     Checking flate2 v1.0.1
[INFO] [stderr]     Checking tokio-udp v0.1.0
[INFO] [stderr]     Checking tokio-tcp v0.1.0
[INFO] [stderr]     Checking h2 v0.1.8
[INFO] [stderr]     Checking tokio v0.1.6
[INFO] [stderr]     Checking tokio-core v0.1.17
[INFO] [stderr]    Compiling backtrace v0.3.8
[INFO] [stderr]     Checking backtrace v0.2.3
[INFO] [stderr]    Compiling serde_derive v1.0.59
[INFO] [stderr]    Compiling derive-error-chain v0.11.2
[INFO] [stderr]     Checking failure v0.1.1
[INFO] [stderr]     Checking error-chain v0.11.0
[INFO] [stderr]     Checking error-chain v0.1.12
[INFO] [stderr]     Checking tokio-signal v0.1.5
[INFO] [stderr]     Checking tokio-tls v0.1.4
[INFO] [stderr]     Checking trust-dns-proto v0.3.3
[INFO] [stderr]    Compiling semver v0.9.0
[INFO] [stderr]    Compiling serde_json v1.0.17
[INFO] [stderr]     Checking trust-dns-resolver v0.8.2
[INFO] [stderr]    Compiling cargo_metadata v0.5.4
[INFO] [stderr]    Compiling skeptic v0.13.3
[INFO] [stderr]    Compiling actix v0.5.7
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dirs.rs:19:13
[INFO] [stderr]    |
[INFO] [stderr] 19 |             base: base,            
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `base`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/dirs.rs:19:13
[INFO] [stderr]    |
[INFO] [stderr] 19 |             base: base,            
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `base`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/dirs.rs:4:16
[INFO] [stderr]   |
[INFO] [stderr] 4 | const AUTHOR: &'static str = "mmacedoeu";
[INFO] [stderr]   |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/dirs.rs:5:17
[INFO] [stderr]   |
[INFO] [stderr] 5 | const PRODUCT: &'static str = "hello";
[INFO] [stderr]   |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/misc.rs:11:20
[INFO] [stderr]    |
[INFO] [stderr] 11 | const THIS_TRACK: &'static str = "unstable";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/dirs.rs:46:34
[INFO] [stderr]    |
[INFO] [stderr] 46 |     let r = arg.replace("$HOME", env::home_dir().unwrap().to_str().unwrap());
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/dirs.rs:4:16
[INFO] [stderr]   |
[INFO] [stderr] 4 | const AUTHOR: &'static str = "mmacedoeu";
[INFO] [stderr]   |               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/dirs.rs:5:17
[INFO] [stderr]   |
[INFO] [stderr] 5 | const PRODUCT: &'static str = "hello";
[INFO] [stderr]   |                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/misc.rs:11:20
[INFO] [stderr]    |
[INFO] [stderr] 11 | const THIS_TRACK: &'static str = "unstable";
[INFO] [stderr]    |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead.
[INFO] [stderr]   --> src/dirs.rs:46:34
[INFO] [stderr]    |
[INFO] [stderr] 46 |     let r = arg.replace("$HOME", env::home_dir().unwrap().to_str().unwrap());
[INFO] [stderr]    |                                  ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `now`
[INFO] [stderr]  --> /opt/crater/target/debug/build/hello-13ded72cbbc8e1b4/out/version.rs:2:1
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub fn now() -> &'static str {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `short_now`
[INFO] [stderr]  --> /opt/crater/target/debug/build/hello-13ded72cbbc8e1b4/out/version.rs:7:1
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub fn short_now() -> &'static str {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `sha`
[INFO] [stderr]   --> /opt/crater/target/debug/build/hello-13ded72cbbc8e1b4/out/version.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | pub fn sha() -> &'static str {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `short_sha`
[INFO] [stderr]   --> /opt/crater/target/debug/build/hello-13ded72cbbc8e1b4/out/version.rs:17:1
[INFO] [stderr]    |
[INFO] [stderr] 17 | pub fn short_sha() -> &'static str {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `target`
[INFO] [stderr]   --> /opt/crater/target/debug/build/hello-13ded72cbbc8e1b4/out/version.rs:27:1
[INFO] [stderr]    |
[INFO] [stderr] 27 | pub fn target() -> &'static str {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `semver`
[INFO] [stderr]   --> /opt/crater/target/debug/build/hello-13ded72cbbc8e1b4/out/version.rs:32:1
[INFO] [stderr]    |
[INFO] [stderr] 32 | pub fn semver() -> &'static str {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/cli.rs:42:20
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let port_str = env::var("PORT").unwrap_or(String::new());
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var("PORT").unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/cli.rs:66:47
[INFO] [stderr]    |
[INFO] [stderr] 66 |     let port = value_t!(matches, "port", u16).unwrap_or(get_api_port());
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| get_api_port())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `now`
[INFO] [stderr]  --> /opt/crater/target/debug/build/hello-13ded72cbbc8e1b4/out/version.rs:2:1
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub fn now() -> &'static str {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `short_now`
[INFO] [stderr]  --> /opt/crater/target/debug/build/hello-13ded72cbbc8e1b4/out/version.rs:7:1
[INFO] [stderr]   |
[INFO] [stderr] 7 | pub fn short_now() -> &'static str {
[INFO] [stderr]   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `sha`
[INFO] [stderr]   --> /opt/crater/target/debug/build/hello-13ded72cbbc8e1b4/out/version.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | pub fn sha() -> &'static str {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `short_sha`
[INFO] [stderr]   --> /opt/crater/target/debug/build/hello-13ded72cbbc8e1b4/out/version.rs:17:1
[INFO] [stderr]    |
[INFO] [stderr] 17 | pub fn short_sha() -> &'static str {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `target`
[INFO] [stderr]   --> /opt/crater/target/debug/build/hello-13ded72cbbc8e1b4/out/version.rs:27:1
[INFO] [stderr]    |
[INFO] [stderr] 27 | pub fn target() -> &'static str {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `semver`
[INFO] [stderr]   --> /opt/crater/target/debug/build/hello-13ded72cbbc8e1b4/out/version.rs:32:1
[INFO] [stderr]    |
[INFO] [stderr] 32 | pub fn semver() -> &'static str {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/cli.rs:42:20
[INFO] [stderr]    |
[INFO] [stderr] 42 |     let port_str = env::var("PORT").unwrap_or(String::new());
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var("PORT").unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/cli.rs:66:47
[INFO] [stderr]    |
[INFO] [stderr] 66 |     let port = value_t!(matches, "port", u16).unwrap_or(get_api_port());
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| get_api_port())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 37s
[INFO] running `"docker" "inspect" "d887dd14509191f7292c1e141a341650a9bf7e2fc2afef6007752c6156ec4ec2"`
[INFO] running `"docker" "rm" "-f" "d887dd14509191f7292c1e141a341650a9bf7e2fc2afef6007752c6156ec4ec2"`
[INFO] [stdout] d887dd14509191f7292c1e141a341650a9bf7e2fc2afef6007752c6156ec4ec2