[INFO] updating cached repository mkulke/locc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mkulke/locc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mkulke/locc" "work/ex/clippy-test-run/sources/stable/gh/mkulke/locc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mkulke/locc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mkulke/locc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkulke/locc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkulke/locc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 72d47a04006cd949d51404b90b675118ef9f8fc9 [INFO] sha for GitHub repo mkulke/locc: 72d47a04006cd949d51404b90b675118ef9f8fc9 [INFO] validating manifest of mkulke/locc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mkulke/locc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mkulke/locc [INFO] finished frobbing mkulke/locc [INFO] frobbed toml for mkulke/locc written to work/ex/clippy-test-run/sources/stable/gh/mkulke/locc/Cargo.toml [INFO] started frobbing mkulke/locc [INFO] finished frobbing mkulke/locc [INFO] frobbed toml for mkulke/locc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkulke/locc/Cargo.toml [INFO] crate mkulke/locc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mkulke/locc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mkulke/locc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 233f043f40758adbb1e675b998e924b93b69466d52ed7d5500c9c43b855e804f [INFO] running `"docker" "start" "-a" "233f043f40758adbb1e675b998e924b93b69466d52ed7d5500c9c43b855e804f"` [INFO] [stderr] Compiling gcc v0.3.49 [INFO] [stderr] Compiling openssl v0.9.13 [INFO] [stderr] Checking polyline v0.4.0 [INFO] [stderr] Checking unicode-bidi v0.3.3 [INFO] [stderr] Checking num_cpus v1.5.0 [INFO] [stderr] Checking libflate v0.1.7 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Compiling hyper v0.10.11 [INFO] [stderr] Checking geo v0.5.0 [INFO] [stderr] Checking idna v0.1.2 [INFO] [stderr] Compiling openssl-sys v0.9.13 [INFO] [stderr] Checking url v1.4.1 [INFO] [stderr] Checking serde_urlencoded v0.5.1 [INFO] [stderr] Checking native-tls v0.1.2 [INFO] [stderr] Checking hyper-native-tls v0.2.3 [INFO] [stderr] Checking reqwest v0.6.2 [INFO] [stderr] Checking locc v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/locc.rs:119:39 [INFO] [stderr] | [INFO] [stderr] 119 | let center_point = Point::new(9.177789688110352, 48.776781529534965); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `9.177_789_688_110_352` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/locc.rs:119:58 [INFO] [stderr] | [INFO] [stderr] 119 | let center_point = Point::new(9.177789688110352, 48.776781529534965); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `48.776_781_529_534_965` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/locc.rs:131:10 [INFO] [stderr] | [INFO] [stderr] 131 | .ok_or(From::from(format!("Could not parse {} argument", key))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| From::from(format!("Could not parse {} argument", key)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/locc.rs:137:10 [INFO] [stderr] | [INFO] [stderr] 137 | .ok_or(format!("Could not parse {} argument", key))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Could not parse {} argument", key))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/locc.rs:207:19 [INFO] [stderr] | [INFO] [stderr] 207 | let geojson = match matches.is_present("collection") { [INFO] [stderr] | ___________________^ [INFO] [stderr] 208 | | true => { [INFO] [stderr] 209 | | json!({ [INFO] [stderr] 210 | | "type": "FeatureCollection", [INFO] [stderr] ... | [INFO] [stderr] 214 | | false => feature, [INFO] [stderr] 215 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 207 | let geojson = if matches.is_present("collection") { [INFO] [stderr] 208 | json!({ [INFO] [stderr] 209 | "type": "FeatureCollection", [INFO] [stderr] 210 | "features": [feature], [INFO] [stderr] 211 | }) [INFO] [stderr] 212 | } else { feature }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | .and_then(|f| match f < 0. { [INFO] [stderr] | _______________________^ [INFO] [stderr] 33 | | false => Ok(()), [INFO] [stderr] 34 | | true => Err("Value is not positive.".to_string()), [INFO] [stderr] 35 | | }) [INFO] [stderr] | |___________________^ help: consider using an if/else expression: `if f < 0. { Err("Value is not positive.".to_string()) } else { Ok(()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/locc.rs:131:10 [INFO] [stderr] | [INFO] [stderr] 131 | .ok_or(From::from(format!("Could not parse {} argument", key))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| From::from(format!("Could not parse {} argument", key)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/locc.rs:137:10 [INFO] [stderr] | [INFO] [stderr] 137 | .ok_or(format!("Could not parse {} argument", key))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format!("Could not parse {} argument", key))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/locc.rs:207:19 [INFO] [stderr] | [INFO] [stderr] 207 | let geojson = match matches.is_present("collection") { [INFO] [stderr] | ___________________^ [INFO] [stderr] 208 | | true => { [INFO] [stderr] 209 | | json!({ [INFO] [stderr] 210 | | "type": "FeatureCollection", [INFO] [stderr] ... | [INFO] [stderr] 214 | | false => feature, [INFO] [stderr] 215 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 207 | let geojson = if matches.is_present("collection") { [INFO] [stderr] 208 | json!({ [INFO] [stderr] 209 | "type": "FeatureCollection", [INFO] [stderr] 210 | "features": [feature], [INFO] [stderr] 211 | }) [INFO] [stderr] 212 | } else { feature }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:32:23 [INFO] [stderr] | [INFO] [stderr] 32 | .and_then(|f| match f < 0. { [INFO] [stderr] | _______________________^ [INFO] [stderr] 33 | | false => Ok(()), [INFO] [stderr] 34 | | true => Err("Value is not positive.".to_string()), [INFO] [stderr] 35 | | }) [INFO] [stderr] | |___________________^ help: consider using an if/else expression: `if f < 0. { Err("Value is not positive.".to_string()) } else { Ok(()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.27s [INFO] running `"docker" "inspect" "233f043f40758adbb1e675b998e924b93b69466d52ed7d5500c9c43b855e804f"` [INFO] running `"docker" "rm" "-f" "233f043f40758adbb1e675b998e924b93b69466d52ed7d5500c9c43b855e804f"` [INFO] [stdout] 233f043f40758adbb1e675b998e924b93b69466d52ed7d5500c9c43b855e804f