[INFO] updating cached repository mkroli/relog [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mkroli/relog [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mkroli/relog" "work/ex/clippy-test-run/sources/stable/gh/mkroli/relog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mkroli/relog'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mkroli/relog" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkroli/relog"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkroli/relog'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 854267643ac2f1987deb79e1b2d6461305cdff3a [INFO] sha for GitHub repo mkroli/relog: 854267643ac2f1987deb79e1b2d6461305cdff3a [INFO] validating manifest of mkroli/relog on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mkroli/relog on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mkroli/relog [INFO] finished frobbing mkroli/relog [INFO] frobbed toml for mkroli/relog written to work/ex/clippy-test-run/sources/stable/gh/mkroli/relog/Cargo.toml [INFO] started frobbing mkroli/relog [INFO] finished frobbing mkroli/relog [INFO] frobbed toml for mkroli/relog written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mkroli/relog/Cargo.toml [INFO] crate mkroli/relog has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mkroli/relog against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mkroli/relog:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b1e3f1dec0c480682df8381d975d5cacffe4baa7b399901b33baaedd83f6b6c2 [INFO] running `"docker" "start" "-a" "b1e3f1dec0c480682df8381d975d5cacffe4baa7b399901b33baaedd83f6b6c2"` [INFO] [stderr] Checking nom v2.1.0 [INFO] [stderr] Checking time v0.1.36 [INFO] [stderr] Checking backtrace-sys v0.1.5 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking error-chain v0.8.1 [INFO] [stderr] Checking relog v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | date_format: date_format [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `date_format` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | log_entry_parser: log_entry_parser [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `log_entry_parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | date_format: date_format [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `date_format` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/logfile.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | log_entry_parser: log_entry_parser [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `log_entry_parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:95:55 [INFO] [stderr] | [INFO] [stderr] 95 | let date_format = matches.value_of("date_format").ok_or(Error::from("date_format missing"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("date_format missing"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:96:47 [INFO] [stderr] | [INFO] [stderr] 96 | let logfile = matches.value_of("logfile").ok_or(Error::from("logfile missing"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("logfile missing"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:101:10 [INFO] [stderr] | [INFO] [stderr] 101 | .or( [INFO] [stderr] | __________^ [INFO] [stderr] 102 | | regex_from_date_format(&date_format.as_bytes()) [INFO] [stderr] 103 | | .to_result() [INFO] [stderr] 104 | | .chain_err(|| "failed to create regex from date_format") [INFO] [stderr] 105 | | )?; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | .or_else(|_| regex_from_date_format(&date_format.as_bytes()) [INFO] [stderr] 102 | .to_result() [INFO] [stderr] 103 | .chain_err(|| "failed to create regex from date_format"))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:99:10 [INFO] [stderr] | [INFO] [stderr] 99 | .ok_or(Error::from("date_extraction_regex missing")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("date_extraction_regex missing"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:95:55 [INFO] [stderr] | [INFO] [stderr] 95 | let date_format = matches.value_of("date_format").ok_or(Error::from("date_format missing"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("date_format missing"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:96:47 [INFO] [stderr] | [INFO] [stderr] 96 | let logfile = matches.value_of("logfile").ok_or(Error::from("logfile missing"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("logfile missing"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or` followed by a function call [INFO] [stderr] --> src/main.rs:101:10 [INFO] [stderr] | [INFO] [stderr] 101 | .or( [INFO] [stderr] | __________^ [INFO] [stderr] 102 | | regex_from_date_format(&date_format.as_bytes()) [INFO] [stderr] 103 | | .to_result() [INFO] [stderr] 104 | | .chain_err(|| "failed to create regex from date_format") [INFO] [stderr] 105 | | )?; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 101 | .or_else(|_| regex_from_date_format(&date_format.as_bytes()) [INFO] [stderr] 102 | .to_result() [INFO] [stderr] 103 | .chain_err(|| "failed to create regex from date_format"))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:99:10 [INFO] [stderr] | [INFO] [stderr] 99 | .ok_or(Error::from("date_extraction_regex missing")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| Error::from("date_extraction_regex missing"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.55s [INFO] running `"docker" "inspect" "b1e3f1dec0c480682df8381d975d5cacffe4baa7b399901b33baaedd83f6b6c2"` [INFO] running `"docker" "rm" "-f" "b1e3f1dec0c480682df8381d975d5cacffe4baa7b399901b33baaedd83f6b6c2"` [INFO] [stdout] b1e3f1dec0c480682df8381d975d5cacffe4baa7b399901b33baaedd83f6b6c2