[INFO] updating cached repository mjec/advent-of-code [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mjec/advent-of-code [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mjec/advent-of-code" "work/ex/clippy-test-run/sources/stable/gh/mjec/advent-of-code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mjec/advent-of-code'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mjec/advent-of-code" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mjec/advent-of-code"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mjec/advent-of-code'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] edb511912f0ebadbe40f34ac2e471de5a3c5ad3c [INFO] sha for GitHub repo mjec/advent-of-code: edb511912f0ebadbe40f34ac2e471de5a3c5ad3c [INFO] validating manifest of mjec/advent-of-code on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mjec/advent-of-code on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mjec/advent-of-code [INFO] finished frobbing mjec/advent-of-code [INFO] frobbed toml for mjec/advent-of-code written to work/ex/clippy-test-run/sources/stable/gh/mjec/advent-of-code/Cargo.toml [INFO] started frobbing mjec/advent-of-code [INFO] finished frobbing mjec/advent-of-code [INFO] frobbed toml for mjec/advent-of-code written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mjec/advent-of-code/Cargo.toml [INFO] crate mjec/advent-of-code has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mjec/advent-of-code against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mjec/advent-of-code:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 105d4f56a257a71512db3366c7316006dbfef4b123d905a2e5d1aa64ae6df8b5 [INFO] running `"docker" "start" "-a" "105d4f56a257a71512db3366c7316006dbfef4b123d905a2e5d1aa64ae6df8b5"` [INFO] [stderr] Checking advent-of-code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:8:11 [INFO] [stderr] | [INFO] [stderr] 8 | fn main() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:8:11 [INFO] [stderr] | [INFO] [stderr] 8 | fn main() -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/twentyseventeen/day1.rs:18:8 [INFO] [stderr] | [INFO] [stderr] 18 | if args[0].len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args[0].is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `sum_of_consecutive_equal_digits` doesn't need a mutable reference [INFO] [stderr] --> src/twentyseventeen/day1.rs:22:52 [INFO] [stderr] | [INFO] [stderr] 22 | println!("{}", sum_of_consecutive_equal_digits(&mut args[0])); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/twentyseventeen/day1.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | if args[0].len() == 0 || args[0].len() % 2 == 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args[0].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `sum_of_oppsite_equal_digits` doesn't need a mutable reference [INFO] [stderr] --> src/twentyseventeen/day1.rs:41:48 [INFO] [stderr] | [INFO] [stderr] 41 | println!("{}", sum_of_oppsite_equal_digits(&mut args[0])); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/twentyseventeen/day1.rs:45:39 [INFO] [stderr] | [INFO] [stderr] 45 | fn sum_of_consecutive_equal_digits(s: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/twentyseventeen/day1.rs:64:35 [INFO] [stderr] | [INFO] [stderr] 64 | fn sum_of_oppsite_equal_digits(s: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/twentyseventeen/day2.rs:48:47 [INFO] [stderr] | [INFO] [stderr] 48 | fn sum_of_difference_min_and_max_each_line(s: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/twentyseventeen/day2.rs:72:43 [INFO] [stderr] | [INFO] [stderr] 72 | fn sum_of_possible_divisions_each_line(s: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/twentyseventeen/day1.rs:18:8 [INFO] [stderr] | [INFO] [stderr] 18 | if args[0].len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args[0].is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `sum_of_consecutive_equal_digits` doesn't need a mutable reference [INFO] [stderr] --> src/twentyseventeen/day1.rs:22:52 [INFO] [stderr] | [INFO] [stderr] 22 | println!("{}", sum_of_consecutive_equal_digits(&mut args[0])); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/twentyseventeen/day1.rs:37:8 [INFO] [stderr] | [INFO] [stderr] 37 | if args[0].len() == 0 || args[0].len() % 2 == 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args[0].is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: The function/method `sum_of_oppsite_equal_digits` doesn't need a mutable reference [INFO] [stderr] --> src/twentyseventeen/day1.rs:41:48 [INFO] [stderr] | [INFO] [stderr] 41 | println!("{}", sum_of_oppsite_equal_digits(&mut args[0])); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/twentyseventeen/day1.rs:45:39 [INFO] [stderr] | [INFO] [stderr] 45 | fn sum_of_consecutive_equal_digits(s: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/twentyseventeen/day1.rs:64:35 [INFO] [stderr] | [INFO] [stderr] 64 | fn sum_of_oppsite_equal_digits(s: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/twentyseventeen/day2.rs:48:47 [INFO] [stderr] | [INFO] [stderr] 48 | fn sum_of_difference_min_and_max_each_line(s: &String) -> u32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/twentyseventeen/day2.rs:72:43 [INFO] [stderr] | [INFO] [stderr] 72 | fn sum_of_possible_divisions_each_line(s: &String) -> i32 { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.31s [INFO] running `"docker" "inspect" "105d4f56a257a71512db3366c7316006dbfef4b123d905a2e5d1aa64ae6df8b5"` [INFO] running `"docker" "rm" "-f" "105d4f56a257a71512db3366c7316006dbfef4b123d905a2e5d1aa64ae6df8b5"` [INFO] [stdout] 105d4f56a257a71512db3366c7316006dbfef4b123d905a2e5d1aa64ae6df8b5