[INFO] updating cached repository mjd95/bcrust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mjd95/bcrust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mjd95/bcrust" "work/ex/clippy-test-run/sources/stable/gh/mjd95/bcrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mjd95/bcrust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mjd95/bcrust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mjd95/bcrust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mjd95/bcrust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 384c6fb4795fde4f2ce8e06ef68a7ff7ded1ef68 [INFO] sha for GitHub repo mjd95/bcrust: 384c6fb4795fde4f2ce8e06ef68a7ff7ded1ef68 [INFO] validating manifest of mjd95/bcrust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mjd95/bcrust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mjd95/bcrust [INFO] finished frobbing mjd95/bcrust [INFO] frobbed toml for mjd95/bcrust written to work/ex/clippy-test-run/sources/stable/gh/mjd95/bcrust/Cargo.toml [INFO] started frobbing mjd95/bcrust [INFO] finished frobbing mjd95/bcrust [INFO] frobbed toml for mjd95/bcrust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mjd95/bcrust/Cargo.toml [INFO] crate mjd95/bcrust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mjd95/bcrust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mjd95/bcrust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3dfa9f3e8177e9c1e11c42f35d6a10a3d1ea6fed1bf2a2fa35e39fcbf10b9a63 [INFO] running `"docker" "start" "-a" "3dfa9f3e8177e9c1e11c42f35d6a10a3d1ea6fed1bf2a2fa35e39fcbf10b9a63"` [INFO] [stderr] Compiling bcrust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Compiling rand v0.6.0 [INFO] [stderr] warning: src/c/bcrypt.c: In function 'decode_base64': [INFO] [stderr] warning: src/c/bcrypt.c:205:22: warning: pointer targets in initialization differ in signedness [-Wpointer-sign] [INFO] [stderr] warning: const u_int8_t *p = b64data; [INFO] [stderr] warning: ^~~~~~~ [INFO] [stderr] warning: src/c/bcrypt.c: In function 'encode_base64': [INFO] [stderr] warning: src/c/bcrypt.c:247:17: warning: pointer targets in initialization differ in signedness [-Wpointer-sign] [INFO] [stderr] warning: u_int8_t *bp = b64buffer; [INFO] [stderr] warning: ^~~~~~~~~ [INFO] [stderr] warning: In file included from src/c/bcrypt_pbkdf.c:24:0: [INFO] [stderr] warning: src/c/sha2.h:68:2: warning: '__bounded__' attribute directive ignored [-Wattributes] [INFO] [stderr] warning: __attribute__((__bounded__(__string__,2,3))); [INFO] [stderr] warning: ^~~~~~~~~~~~~ [INFO] [stderr] warning: src/c/sha2.h:70:2: warning: '__bounded__' attribute directive ignored [-Wattributes] [INFO] [stderr] warning: __attribute__((__bounded__(__minbytes__,1,SHA256_DIGEST_LENGTH))); [INFO] [stderr] warning: ^~~~~~~~~~~~~ [INFO] [stderr] warning: src/c/sha2.h:74:2: warning: '__bounded__' attribute directive ignored [-Wattributes] [INFO] [stderr] warning: __attribute__((__bounded__(__string__,2,3))); [INFO] [stderr] warning: ^~~~~~~~~~~~~ [INFO] [stderr] warning: src/c/sha2.h:76:2: warning: '__bounded__' attribute directive ignored [-Wattributes] [INFO] [stderr] warning: __attribute__((__bounded__(__minbytes__,1,SHA384_DIGEST_LENGTH))); [INFO] [stderr] warning: ^~~~~~~~~~~~~ [INFO] [stderr] warning: src/c/sha2.h:80:2: warning: '__bounded__' attribute directive ignored [-Wattributes] [INFO] [stderr] warning: __attribute__((__bounded__(__string__,2,3))); [INFO] [stderr] warning: ^~~~~~~~~~~~~ [INFO] [stderr] warning: src/c/sha2.h:82:2: warning: '__bounded__' attribute directive ignored [-Wattributes] [INFO] [stderr] warning: __attribute__((__bounded__(__minbytes__,1,SHA512_DIGEST_LENGTH))); [INFO] [stderr] warning: ^~~~~~~~~~~~~ [INFO] [stderr] warning: In file included from src/c/sha2.c:38:0: [INFO] [stderr] warning: src/c/sha2.h:68:2: warning: '__bounded__' attribute directive ignored [-Wattributes] [INFO] [stderr] warning: __attribute__((__bounded__(__string__,2,3))); [INFO] [stderr] warning: ^~~~~~~~~~~~~ [INFO] [stderr] warning: src/c/sha2.h:70:2: warning: '__bounded__' attribute directive ignored [-Wattributes] [INFO] [stderr] warning: __attribute__((__bounded__(__minbytes__,1,SHA256_DIGEST_LENGTH))); [INFO] [stderr] warning: ^~~~~~~~~~~~~ [INFO] [stderr] warning: src/c/sha2.h:74:2: warning: '__bounded__' attribute directive ignored [-Wattributes] [INFO] [stderr] warning: __attribute__((__bounded__(__string__,2,3))); [INFO] [stderr] warning: ^~~~~~~~~~~~~ [INFO] [stderr] warning: src/c/sha2.h:76:2: warning: '__bounded__' attribute directive ignored [-Wattributes] [INFO] [stderr] warning: __attribute__((__bounded__(__minbytes__,1,SHA384_DIGEST_LENGTH))); [INFO] [stderr] warning: ^~~~~~~~~~~~~ [INFO] [stderr] warning: src/c/sha2.h:80:2: warning: '__bounded__' attribute directive ignored [-Wattributes] [INFO] [stderr] warning: __attribute__((__bounded__(__string__,2,3))); [INFO] [stderr] warning: ^~~~~~~~~~~~~ [INFO] [stderr] warning: src/c/sha2.h:82:2: warning: '__bounded__' attribute directive ignored [-Wattributes] [INFO] [stderr] warning: __attribute__((__bounded__(__minbytes__,1,SHA512_DIGEST_LENGTH))); [INFO] [stderr] warning: ^~~~~~~~~~~~~ [INFO] [stderr] warning: src/c/sha2.c:122:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] [INFO] [stderr] warning: const static u_int32_t K256[64] = { [INFO] [stderr] warning: ^~~~~ [INFO] [stderr] warning: src/c/sha2.c:142:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] [INFO] [stderr] warning: const static u_int32_t sha256_initial_hash_value[8] = { [INFO] [stderr] warning: ^~~~~ [INFO] [stderr] warning: src/c/sha2.c:154:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] [INFO] [stderr] warning: const static u_int64_t K512[80] = { [INFO] [stderr] warning: ^~~~~ [INFO] [stderr] warning: src/c/sha2.c:198:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] [INFO] [stderr] warning: const static u_int64_t sha384_initial_hash_value[8] = { [INFO] [stderr] warning: ^~~~~ [INFO] [stderr] warning: src/c/sha2.c:210:1: warning: 'static' is not at beginning of declaration [-Wold-style-declaration] [INFO] [stderr] warning: const static u_int64_t sha512_initial_hash_value[8] = { [INFO] [stderr] warning: ^~~~~ [INFO] [stderr] warning: unused import: `std::ffi::CString` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::ffi::CString; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | return dst [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `dst` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ffi::CString` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::ffi::CString; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | return dst [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `dst` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | return true [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.81s [INFO] running `"docker" "inspect" "3dfa9f3e8177e9c1e11c42f35d6a10a3d1ea6fed1bf2a2fa35e39fcbf10b9a63"` [INFO] running `"docker" "rm" "-f" "3dfa9f3e8177e9c1e11c42f35d6a10a3d1ea6fed1bf2a2fa35e39fcbf10b9a63"` [INFO] [stdout] 3dfa9f3e8177e9c1e11c42f35d6a10a3d1ea6fed1bf2a2fa35e39fcbf10b9a63