[INFO] updating cached repository mjbryant/docker-attach
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mjbryant/docker-attach
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mjbryant/docker-attach" "work/ex/clippy-test-run/sources/stable/gh/mjbryant/docker-attach"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mjbryant/docker-attach'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mjbryant/docker-attach" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mjbryant/docker-attach"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mjbryant/docker-attach'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 41d0fafb87cddfc3976d7fee4c859620766682c8
[INFO] sha for GitHub repo mjbryant/docker-attach: 41d0fafb87cddfc3976d7fee4c859620766682c8
[INFO] validating manifest of mjbryant/docker-attach on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mjbryant/docker-attach on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mjbryant/docker-attach
[INFO] finished frobbing mjbryant/docker-attach
[INFO] frobbed toml for mjbryant/docker-attach written to work/ex/clippy-test-run/sources/stable/gh/mjbryant/docker-attach/Cargo.toml
[INFO] started frobbing mjbryant/docker-attach
[INFO] finished frobbing mjbryant/docker-attach
[INFO] frobbed toml for mjbryant/docker-attach written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mjbryant/docker-attach/Cargo.toml
[INFO] crate mjbryant/docker-attach has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mjbryant/docker-attach against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mjbryant/docker-attach:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cb4e3f16f5b88190217377a80d80fd99753dfb4dcd466ab78b32853e8776b802
[INFO] running `"docker" "start" "-a" "cb4e3f16f5b88190217377a80d80fd99753dfb4dcd466ab78b32853e8776b802"`
[INFO] [stderr]     Checking termion v1.5.1
[INFO] [stderr]     Checking docker-attach v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/main.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 | /         write!(
[INFO] [stderr] 51 | |             stdout,
[INFO] [stderr] 52 | |             "{}{}{} {}({} - {}){}\r\n",
[INFO] [stderr] 53 | |             leader,
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |             style::Reset,
[INFO] [stderr] 60 | |         ).unwrap();
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]   --> src/main.rs:50:9
[INFO] [stderr]    |
[INFO] [stderr] 50 | /         write!(
[INFO] [stderr] 51 | |             stdout,
[INFO] [stderr] 52 | |             "{}{}{} {}({} - {}){}\r\n",
[INFO] [stderr] 53 | |             leader,
[INFO] [stderr] ...  |
[INFO] [stderr] 59 | |             style::Reset,
[INFO] [stderr] 60 | |         ).unwrap();
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     return ContainerInfo {
[INFO] [stderr] 28 | |         id: String::from(id),
[INFO] [stderr] 29 | |         image: String::from(image),
[INFO] [stderr] 30 | |         name: String::from(name),
[INFO] [stderr] 31 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 27 |     ContainerInfo {
[INFO] [stderr] 28 |         id: String::from(id),
[INFO] [stderr] 29 |         image: String::from(image),
[INFO] [stderr] 30 |         name: String::from(name),
[INFO] [stderr] 31 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:27:5
[INFO] [stderr]    |
[INFO] [stderr] 27 | /     return ContainerInfo {
[INFO] [stderr] 28 | |         id: String::from(id),
[INFO] [stderr] 29 | |         image: String::from(image),
[INFO] [stderr] 30 | |         name: String::from(name),
[INFO] [stderr] 31 | |     };
[INFO] [stderr]    | |______^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 27 |     ContainerInfo {
[INFO] [stderr] 28 |         id: String::from(id),
[INFO] [stderr] 29 |         image: String::from(image),
[INFO] [stderr] 30 |         name: String::from(name),
[INFO] [stderr] 31 |     }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/main.rs:24:28
[INFO] [stderr]    |
[INFO] [stderr] 24 |     while let Some(word) = iter.next() {
[INFO] [stderr]    |                            ^^^^^^^^^^^ help: try: `for word in iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:35:17
[INFO] [stderr]    |
[INFO] [stderr] 35 |     containers: &Vec<ContainerInfo>,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ContainerInfo]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]   --> src/main.rs:24:28
[INFO] [stderr]    |
[INFO] [stderr] 24 |     while let Some(word) = iter.next() {
[INFO] [stderr]    |                            ^^^^^^^^^^^ help: try: `for word in iter { .. }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:35:17
[INFO] [stderr]    |
[INFO] [stderr] 35 |     containers: &Vec<ContainerInfo>,
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[ContainerInfo]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:101:13
[INFO] [stderr]     |
[INFO] [stderr] 101 |             y = y - containers.len() as u16;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= containers.len() as u16`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:101:13
[INFO] [stderr]     |
[INFO] [stderr] 101 |             y = y - containers.len() as u16;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `y -= containers.len() as u16`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.83s
[INFO] running `"docker" "inspect" "cb4e3f16f5b88190217377a80d80fd99753dfb4dcd466ab78b32853e8776b802"`
[INFO] running `"docker" "rm" "-f" "cb4e3f16f5b88190217377a80d80fd99753dfb4dcd466ab78b32853e8776b802"`
[INFO] [stdout] cb4e3f16f5b88190217377a80d80fd99753dfb4dcd466ab78b32853e8776b802