[INFO] updating cached repository mitsuhiko/machfind [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mitsuhiko/machfind [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mitsuhiko/machfind" "work/ex/clippy-test-run/sources/stable/gh/mitsuhiko/machfind"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mitsuhiko/machfind'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mitsuhiko/machfind" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mitsuhiko/machfind"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mitsuhiko/machfind'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5105e6c324f06c348759f9ac5ad9836be36361cf [INFO] sha for GitHub repo mitsuhiko/machfind: 5105e6c324f06c348759f9ac5ad9836be36361cf [INFO] validating manifest of mitsuhiko/machfind on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mitsuhiko/machfind on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mitsuhiko/machfind [INFO] finished frobbing mitsuhiko/machfind [INFO] frobbed toml for mitsuhiko/machfind written to work/ex/clippy-test-run/sources/stable/gh/mitsuhiko/machfind/Cargo.toml [INFO] started frobbing mitsuhiko/machfind [INFO] finished frobbing mitsuhiko/machfind [INFO] frobbed toml for mitsuhiko/machfind written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mitsuhiko/machfind/Cargo.toml [INFO] crate mitsuhiko/machfind has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mitsuhiko/machfind against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mitsuhiko/machfind:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b65fb239b6fda68aaeb189ccf0314748fc0b3cc1013cdf61dfbec4eb9623434f [INFO] running `"docker" "start" "-a" "b65fb239b6fda68aaeb189ccf0314748fc0b3cc1013cdf61dfbec4eb9623434f"` [INFO] [stderr] Checking uuid v0.4.0 [INFO] [stderr] Checking memmap v0.5.2 [INFO] [stderr] Checking clap v2.21.2 [INFO] [stderr] Checking error-chain v0.9.0 [INFO] [stderr] Checking mach_object v0.1.3 [INFO] [stderr] Checking machfind v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:14:17 [INFO] [stderr] | [INFO] [stderr] 14 | const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / if let &OFile::MachFile { ref commands, .. } = file { [INFO] [stderr] 99 | | for &MachCommand(ref load_cmd, _) in commands { [INFO] [stderr] 100 | | match load_cmd { [INFO] [stderr] 101 | | &LoadCommand::Uuid(uuid) => { [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | if let OFile::MachFile { ref commands, .. } = *file { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cli.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / match load_cmd { [INFO] [stderr] 101 | | &LoadCommand::Uuid(uuid) => { [INFO] [stderr] 102 | | uuids.push(uuid); [INFO] [stderr] 103 | | }, [INFO] [stderr] 104 | | _ => {} [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 100 | if let &LoadCommand::Uuid(uuid) = load_cmd { [INFO] [stderr] 101 | uuids.push(uuid); [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / match load_cmd { [INFO] [stderr] 101 | | &LoadCommand::Uuid(uuid) => { [INFO] [stderr] 102 | | uuids.push(uuid); [INFO] [stderr] 103 | | }, [INFO] [stderr] 104 | | _ => {} [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | match *load_cmd { [INFO] [stderr] 101 | LoadCommand::Uuid(uuid) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / if let &OFile::MachFile { ref commands, .. } = file { [INFO] [stderr] 99 | | for &MachCommand(ref load_cmd, _) in commands { [INFO] [stderr] 100 | | match load_cmd { [INFO] [stderr] 101 | | &LoadCommand::Uuid(uuid) => { [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 98 | if let OFile::MachFile { ref commands, .. } = *file { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/cli.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / match load_cmd { [INFO] [stderr] 101 | | &LoadCommand::Uuid(uuid) => { [INFO] [stderr] 102 | | uuids.push(uuid); [INFO] [stderr] 103 | | }, [INFO] [stderr] 104 | | _ => {} [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 100 | if let &LoadCommand::Uuid(uuid) = load_cmd { [INFO] [stderr] 101 | uuids.push(uuid); [INFO] [stderr] 102 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/cli.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | / match load_cmd { [INFO] [stderr] 101 | | &LoadCommand::Uuid(uuid) => { [INFO] [stderr] 102 | | uuids.push(uuid); [INFO] [stderr] 103 | | }, [INFO] [stderr] 104 | | _ => {} [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 100 | match *load_cmd { [INFO] [stderr] 101 | LoadCommand::Uuid(uuid) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.46s [INFO] running `"docker" "inspect" "b65fb239b6fda68aaeb189ccf0314748fc0b3cc1013cdf61dfbec4eb9623434f"` [INFO] running `"docker" "rm" "-f" "b65fb239b6fda68aaeb189ccf0314748fc0b3cc1013cdf61dfbec4eb9623434f"` [INFO] [stdout] b65fb239b6fda68aaeb189ccf0314748fc0b3cc1013cdf61dfbec4eb9623434f