[INFO] updating cached repository mithril1992/rust_practice [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mithril1992/rust_practice [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mithril1992/rust_practice" "work/ex/clippy-test-run/sources/stable/gh/mithril1992/rust_practice"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mithril1992/rust_practice'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mithril1992/rust_practice" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mithril1992/rust_practice"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mithril1992/rust_practice'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 98c8210092b3438bf51a7f1be0be1182dae00bef [INFO] sha for GitHub repo mithril1992/rust_practice: 98c8210092b3438bf51a7f1be0be1182dae00bef [INFO] validating manifest of mithril1992/rust_practice on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mithril1992/rust_practice on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mithril1992/rust_practice [INFO] finished frobbing mithril1992/rust_practice [INFO] frobbed toml for mithril1992/rust_practice written to work/ex/clippy-test-run/sources/stable/gh/mithril1992/rust_practice/Cargo.toml [INFO] started frobbing mithril1992/rust_practice [INFO] finished frobbing mithril1992/rust_practice [INFO] frobbed toml for mithril1992/rust_practice written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mithril1992/rust_practice/Cargo.toml [INFO] crate mithril1992/rust_practice has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mithril1992/rust_practice against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mithril1992/rust_practice:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 85d093ad825c57a25fddbaefb2d3746495ae469a7c85fa6bb7fcbdeedfdd518a [INFO] running `"docker" "start" "-a" "85d093ad825c57a25fddbaefb2d3746495ae469a7c85fa6bb7fcbdeedfdd518a"` [INFO] [stderr] Compiling rust_sample v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/async_queue.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/async_queue.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/async_queue.rs:35:40 [INFO] [stderr] | [INFO] [stderr] 35 | let tasks = (0..7).into_iter().map(|n| Task::new(n)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Task::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/async_queue.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | let tasks = (0..7).into_iter().map(|n| Task::new(n)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..7)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/async_queue.rs:38:27 [INFO] [stderr] | [INFO] [stderr] 38 | let handles: Vec<_> = (0..2).into_iter().map(|id| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/bin/async_queue.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | / loop { [INFO] [stderr] 42 | | match pop_from(&queue) { [INFO] [stderr] 43 | | Some(t) => t.run(id), [INFO] [stderr] 44 | | None => break, [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ help: try: `while let Some(t) = pop_from(&queue) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/async_queue.rs:35:40 [INFO] [stderr] | [INFO] [stderr] 35 | let tasks = (0..7).into_iter().map(|n| Task::new(n)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove closure as shown: `Task::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/async_queue.rs:35:17 [INFO] [stderr] | [INFO] [stderr] 35 | let tasks = (0..7).into_iter().map(|n| Task::new(n)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..7)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/async_queue.rs:38:27 [INFO] [stderr] | [INFO] [stderr] 38 | let handles: Vec<_> = (0..2).into_iter().map(|id| { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/bin/async_queue.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | / loop { [INFO] [stderr] 42 | | match pop_from(&queue) { [INFO] [stderr] 43 | | Some(t) => t.run(id), [INFO] [stderr] 44 | | None => break, [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ help: try: `while let Some(t) = pop_from(&queue) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: unused variable: `program` [INFO] [stderr] --> src/bin/fizzbuzz.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let program = args[0].clone(); [INFO] [stderr] | ^^^^^^^ help: consider using `_program` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `program` [INFO] [stderr] --> src/bin/fizzbuzz.rs:7:9 [INFO] [stderr] | [INFO] [stderr] 7 | let program = args[0].clone(); [INFO] [stderr] | ^^^^^^^ help: consider using `_program` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.25s [INFO] running `"docker" "inspect" "85d093ad825c57a25fddbaefb2d3746495ae469a7c85fa6bb7fcbdeedfdd518a"` [INFO] running `"docker" "rm" "-f" "85d093ad825c57a25fddbaefb2d3746495ae469a7c85fa6bb7fcbdeedfdd518a"` [INFO] [stdout] 85d093ad825c57a25fddbaefb2d3746495ae469a7c85fa6bb7fcbdeedfdd518a