[INFO] updating cached repository mitchhentges/lcov-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mitchhentges/lcov-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mitchhentges/lcov-rs" "work/ex/clippy-test-run/sources/stable/gh/mitchhentges/lcov-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mitchhentges/lcov-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mitchhentges/lcov-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mitchhentges/lcov-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mitchhentges/lcov-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 91156db347a6c35ecfb789db8672f1d0baae9df2 [INFO] sha for GitHub repo mitchhentges/lcov-rs: 91156db347a6c35ecfb789db8672f1d0baae9df2 [INFO] validating manifest of mitchhentges/lcov-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mitchhentges/lcov-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mitchhentges/lcov-rs [INFO] finished frobbing mitchhentges/lcov-rs [INFO] frobbed toml for mitchhentges/lcov-rs written to work/ex/clippy-test-run/sources/stable/gh/mitchhentges/lcov-rs/Cargo.toml [INFO] started frobbing mitchhentges/lcov-rs [INFO] finished frobbing mitchhentges/lcov-rs [INFO] frobbed toml for mitchhentges/lcov-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mitchhentges/lcov-rs/Cargo.toml [INFO] crate mitchhentges/lcov-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mitchhentges/lcov-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mitchhentges/lcov-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 06eb2df29a4c0c0219052c38bdc0284156cb35dbc7a3a459eaf69836a37abe16 [INFO] running `"docker" "start" "-a" "06eb2df29a4c0c0219052c38bdc0284156cb35dbc7a3a459eaf69836a37abe16"` [INFO] [stderr] Checking itertools v0.5.10 [INFO] [stderr] Checking lcov-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | identifier: identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | line_number_checksum: line_number_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | config_checksum: config_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | line_number: line_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | function_id: function_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `function_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | counts: counts, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `counts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:307:17 [INFO] [stderr] | [INFO] [stderr] 307 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:335:13 [INFO] [stderr] | [INFO] [stderr] 335 | destination_block: destination_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:336:13 [INFO] [stderr] | [INFO] [stderr] 336 | flags: flags [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:341:9 [INFO] [stderr] | [INFO] [stderr] 341 | source_block: source_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | identifier: identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | line_number_checksum: line_number_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | config_checksum: config_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:474:29 [INFO] [stderr] | [INFO] [stderr] 474 | return ParseError { code: code }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | identifier: identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | line_number_checksum: line_number_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | config_checksum: config_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | line_number: line_number, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:257:9 [INFO] [stderr] | [INFO] [stderr] 257 | function_id: function_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `function_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | counts: counts, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `counts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:307:17 [INFO] [stderr] | [INFO] [stderr] 307 | block: block, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:335:13 [INFO] [stderr] | [INFO] [stderr] 335 | destination_block: destination_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:336:13 [INFO] [stderr] | [INFO] [stderr] 336 | flags: flags [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:341:9 [INFO] [stderr] | [INFO] [stderr] 341 | source_block: source_block, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_block` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | identifier: identifier, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:358:9 [INFO] [stderr] | [INFO] [stderr] 358 | line_number_checksum: line_number_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `line_number_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:359:9 [INFO] [stderr] | [INFO] [stderr] 359 | config_checksum: config_checksum, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `config_checksum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:474:29 [INFO] [stderr] | [INFO] [stderr] 474 | return ParseError { code: code }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | const GCDA_MAGIC: u32 = 0x67636461; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6763_6461` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | const GCNO_MAGIC: u32 = 0x67636e6f; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6763_6e6f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | const TAG_FUNCTION: u32 = 0x01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | const TAG_COUNTS: u32 = 0x01a10000; // For MVP, ignore multi-run values [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x01a1_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | const TAG_BLOCKS: u32 = 0x01410000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0141_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | const TAG_ARCS: u32 = 0x01430000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0143_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | const TAG_LINES: u32 = 0x01450000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0145_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:21:27 [INFO] [stderr] | [INFO] [stderr] 21 | const TAG_END_FILE: u32 = 0x00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / return functions.into_iter() [INFO] [stderr] 137 | | .group_by(|f| f.src_path.clone()) [INFO] [stderr] 138 | | .into_iter() [INFO] [stderr] 139 | | .map(|(k, g)| { [INFO] [stderr] ... | [INFO] [stderr] 144 | | }) [INFO] [stderr] 145 | | .collect(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 136 | functions.into_iter() [INFO] [stderr] 137 | .group_by(|f| f.src_path.clone()) [INFO] [stderr] 138 | .into_iter() [INFO] [stderr] 139 | .map(|(k, g)| { [INFO] [stderr] 140 | FileNotes { [INFO] [stderr] 141 | src_path: k, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | return Ok(12); // Read magic, version, skip stamp [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(12)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | return Ok(12); // Read magic, version, skip stamp [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(12)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | / return Ok(Record { [INFO] [stderr] 246 | | length: 24 + name_length + src_path_length, [INFO] [stderr] 247 | | record: function_record [INFO] [stderr] 248 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 245 | Ok(Record { [INFO] [stderr] 246 | length: 24 + name_length + src_path_length, [INFO] [stderr] 247 | record: function_record [INFO] [stderr] 248 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | / return Record { [INFO] [stderr] 262 | | length: buffer.len(), [INFO] [stderr] 263 | | record: counts_record [INFO] [stderr] 264 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 261 | Record { [INFO] [stderr] 262 | length: buffer.len(), [INFO] [stderr] 263 | record: counts_record [INFO] [stderr] 264 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:273:5 [INFO] [stderr] | [INFO] [stderr] 273 | / return Record { [INFO] [stderr] 274 | | length: buffer.len(), [INFO] [stderr] 275 | | record: block_records [INFO] [stderr] 276 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 273 | Record { [INFO] [stderr] 274 | length: buffer.len(), [INFO] [stderr] 275 | record: block_records [INFO] [stderr] 276 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:314:5 [INFO] [stderr] | [INFO] [stderr] 314 | / return Ok(Record { [INFO] [stderr] 315 | | length: line_offset, [INFO] [stderr] 316 | | record: line_records [INFO] [stderr] 317 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 314 | Ok(Record { [INFO] [stderr] 315 | length: line_offset, [INFO] [stderr] 316 | record: line_records [INFO] [stderr] 317 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:345:5 [INFO] [stderr] | [INFO] [stderr] 345 | / return Record { [INFO] [stderr] 346 | | length: buffer.len(), [INFO] [stderr] 347 | | record: arc_record [INFO] [stderr] 348 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 345 | Record { [INFO] [stderr] 346 | length: buffer.len(), [INFO] [stderr] 347 | record: arc_record [INFO] [stderr] 348 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / return Record { [INFO] [stderr] 363 | | length: 12, [INFO] [stderr] 364 | | record: function_reference [INFO] [stderr] 365 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 362 | Record { [INFO] [stderr] 363 | length: 12, [INFO] [stderr] 364 | record: function_reference [INFO] [stderr] 365 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | return str::from_utf8(&buffer[0..content_end+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `str::from_utf8(&buffer[0..content_end+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:413:9 [INFO] [stderr] | [INFO] [stderr] 413 | return self.flags & ARC_ON_TREE > 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.flags & ARC_ON_TREE > 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:474:9 [INFO] [stderr] | [INFO] [stderr] 474 | return ParseError { code: code }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParseError { code: code }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:480:9 [INFO] [stderr] | [INFO] [stderr] 480 | return ParseError { code: 3 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParseError { code: 3 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:14:25 [INFO] [stderr] | [INFO] [stderr] 14 | const GCDA_MAGIC: u32 = 0x67636461; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6763_6461` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | const GCNO_MAGIC: u32 = 0x67636e6f; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6763_6e6f` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:16:27 [INFO] [stderr] | [INFO] [stderr] 16 | const TAG_FUNCTION: u32 = 0x01000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | const TAG_COUNTS: u32 = 0x01a10000; // For MVP, ignore multi-run values [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x01a1_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:18:25 [INFO] [stderr] | [INFO] [stderr] 18 | const TAG_BLOCKS: u32 = 0x01410000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0141_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | const TAG_ARCS: u32 = 0x01430000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0143_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | const TAG_LINES: u32 = 0x01450000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0145_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:21:27 [INFO] [stderr] | [INFO] [stderr] 21 | const TAG_END_FILE: u32 = 0x00000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / return functions.into_iter() [INFO] [stderr] 137 | | .group_by(|f| f.src_path.clone()) [INFO] [stderr] 138 | | .into_iter() [INFO] [stderr] 139 | | .map(|(k, g)| { [INFO] [stderr] ... | [INFO] [stderr] 144 | | }) [INFO] [stderr] 145 | | .collect(); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 136 | functions.into_iter() [INFO] [stderr] 137 | .group_by(|f| f.src_path.clone()) [INFO] [stderr] 138 | .into_iter() [INFO] [stderr] 139 | .map(|(k, g)| { [INFO] [stderr] 140 | FileNotes { [INFO] [stderr] 141 | src_path: k, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | return Ok(12); // Read magic, version, skip stamp [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(12)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | return Ok(12); // Read magic, version, skip stamp [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(12)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:245:5 [INFO] [stderr] | [INFO] [stderr] 245 | / return Ok(Record { [INFO] [stderr] 246 | | length: 24 + name_length + src_path_length, [INFO] [stderr] 247 | | record: function_record [INFO] [stderr] 248 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 245 | Ok(Record { [INFO] [stderr] 246 | length: 24 + name_length + src_path_length, [INFO] [stderr] 247 | record: function_record [INFO] [stderr] 248 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:261:5 [INFO] [stderr] | [INFO] [stderr] 261 | / return Record { [INFO] [stderr] 262 | | length: buffer.len(), [INFO] [stderr] 263 | | record: counts_record [INFO] [stderr] 264 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 261 | Record { [INFO] [stderr] 262 | length: buffer.len(), [INFO] [stderr] 263 | record: counts_record [INFO] [stderr] 264 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:273:5 [INFO] [stderr] | [INFO] [stderr] 273 | / return Record { [INFO] [stderr] 274 | | length: buffer.len(), [INFO] [stderr] 275 | | record: block_records [INFO] [stderr] 276 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 273 | Record { [INFO] [stderr] 274 | length: buffer.len(), [INFO] [stderr] 275 | record: block_records [INFO] [stderr] 276 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:314:5 [INFO] [stderr] | [INFO] [stderr] 314 | / return Ok(Record { [INFO] [stderr] 315 | | length: line_offset, [INFO] [stderr] 316 | | record: line_records [INFO] [stderr] 317 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 314 | Ok(Record { [INFO] [stderr] 315 | length: line_offset, [INFO] [stderr] 316 | record: line_records [INFO] [stderr] 317 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:345:5 [INFO] [stderr] | [INFO] [stderr] 345 | / return Record { [INFO] [stderr] 346 | | length: buffer.len(), [INFO] [stderr] 347 | | record: arc_record [INFO] [stderr] 348 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 345 | Record { [INFO] [stderr] 346 | length: buffer.len(), [INFO] [stderr] 347 | record: arc_record [INFO] [stderr] 348 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / return Record { [INFO] [stderr] 363 | | length: 12, [INFO] [stderr] 364 | | record: function_reference [INFO] [stderr] 365 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 362 | Record { [INFO] [stderr] 363 | length: 12, [INFO] [stderr] 364 | record: function_reference [INFO] [stderr] 365 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:374:5 [INFO] [stderr] | [INFO] [stderr] 374 | return str::from_utf8(&buffer[0..content_end+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `str::from_utf8(&buffer[0..content_end+1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:413:9 [INFO] [stderr] | [INFO] [stderr] 413 | return self.flags & ARC_ON_TREE > 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.flags & ARC_ON_TREE > 0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:474:9 [INFO] [stderr] | [INFO] [stderr] 474 | return ParseError { code: code }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParseError { code: code }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:480:9 [INFO] [stderr] | [INFO] [stderr] 480 | return ParseError { code: 3 }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParseError { code: 3 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tmp_output_path` [INFO] [stderr] --> src/main.rs:148:31 [INFO] [stderr] | [INFO] [stderr] 148 | fn read_gcda(gcda_path: &str, tmp_output_path: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_tmp_output_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tmp_output_path` [INFO] [stderr] --> src/main.rs:148:31 [INFO] [stderr] | [INFO] [stderr] 148 | fn read_gcda(gcda_path: &str, tmp_output_path: &str) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using `_tmp_output_path` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ARC_ON_TREE` [INFO] [stderr] --> src/main.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | const ARC_ON_TREE: u32 = 1 << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_on_tree` [INFO] [stderr] --> src/main.rs:412:5 [INFO] [stderr] | [INFO] [stderr] 412 | fn is_on_tree(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/main.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | const ARC_ON_TREE: u32 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ARC_ON_TREE` [INFO] [stderr] --> src/main.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | const ARC_ON_TREE: u32 = 1 << 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `is_on_tree` [INFO] [stderr] --> src/main.rs:412:5 [INFO] [stderr] | [INFO] [stderr] 412 | fn is_on_tree(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/main.rs:23:26 [INFO] [stderr] | [INFO] [stderr] 23 | const ARC_ON_TREE: u32 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | writeln!(std::io::stderr(), "Failed to open {}:{}", &gcno_path, e.description()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/main.rs:60:50 [INFO] [stderr] | [INFO] [stderr] 60 | let tag = LittleEndian::read_u32(&buffer[offset + 0..offset + 4]); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/main.rs:132:66 [INFO] [stderr] | [INFO] [stderr] 132 | offset += if record_offset != 0 { record_offset } else { 1 * 4 }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | writeln!(std::io::stderr(), "Failed to open {}:{}", &gcno_path, e.description()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/main.rs:60:50 [INFO] [stderr] | [INFO] [stderr] 60 | let tag = LittleEndian::read_u32(&buffer[offset + 0..offset + 4]); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | writeln!(std::io::stderr(), "Failed to open {}:{}", &gcda_path, e.description()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/main.rs:170:50 [INFO] [stderr] | [INFO] [stderr] 170 | let tag = LittleEndian::read_u32(&buffer[offset + 0..offset + 4]); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/main.rs:132:66 [INFO] [stderr] | [INFO] [stderr] 132 | offset += if record_offset != 0 { record_offset } else { 1 * 4 }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/main.rs:198:66 [INFO] [stderr] | [INFO] [stderr] 198 | offset += if record_offset != 0 { record_offset } else { 1 * 4 }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | / writeln!(std::io::stderr(), [INFO] [stderr] 205 | | "Invalid magic bytes. Could be an endian issue if on non-Linux").unwrap(); [INFO] [stderr] | |__________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | writeln!(std::io::stderr(), "Failed to open {}:{}", &gcda_path, e.description()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/main.rs:170:50 [INFO] [stderr] | [INFO] [stderr] 170 | let tag = LittleEndian::read_u32(&buffer[offset + 0..offset + 4]); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | / writeln!(std::io::stderr(), [INFO] [stderr] 216 | | "Invalid magic bytes. Could be an endian issue if on non-Linux").unwrap(); [INFO] [stderr] | |__________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `4` [INFO] [stderr] --> src/main.rs:198:66 [INFO] [stderr] | [INFO] [stderr] 198 | offset += if record_offset != 0 { record_offset } else { 1 * 4 }; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | / writeln!(std::io::stderr(), [INFO] [stderr] 205 | | "Invalid magic bytes. Could be an endian issue if on non-Linux").unwrap(); [INFO] [stderr] | |__________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `writeln!(stderr(), ...).unwrap()`. Consider using `eprintln!` instead [INFO] [stderr] --> src/main.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | / writeln!(std::io::stderr(), [INFO] [stderr] 216 | | "Invalid magic bytes. Could be an endian issue if on non-Linux").unwrap(); [INFO] [stderr] | |__________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `line_offset` [INFO] [stderr] --> src/main.rs:290:54 [INFO] [stderr] | [INFO] [stderr] 290 | let line_no = LittleEndian::read_u32(&buffer[0+line_offset..4+line_offset]); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `arc_offset` [INFO] [stderr] --> src/main.rs:331:64 [INFO] [stderr] | [INFO] [stderr] 331 | let destination_block = LittleEndian::read_u32(&buffer[0+arc_offset..4+arc_offset]); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `line_offset` [INFO] [stderr] --> src/main.rs:290:54 [INFO] [stderr] | [INFO] [stderr] 290 | let line_no = LittleEndian::read_u32(&buffer[0+line_offset..4+line_offset]); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:374:35 [INFO] [stderr] | [INFO] [stderr] 374 | return str::from_utf8(&buffer[0..content_end+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=content_end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `arc_offset` [INFO] [stderr] --> src/main.rs:331:64 [INFO] [stderr] | [INFO] [stderr] 331 | let destination_block = LittleEndian::read_u32(&buffer[0+arc_offset..4+arc_offset]); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/main.rs:374:35 [INFO] [stderr] | [INFO] [stderr] 374 | return str::from_utf8(&buffer[0..content_end+1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `0..=content_end` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.07s [INFO] running `"docker" "inspect" "06eb2df29a4c0c0219052c38bdc0284156cb35dbc7a3a459eaf69836a37abe16"` [INFO] running `"docker" "rm" "-f" "06eb2df29a4c0c0219052c38bdc0284156cb35dbc7a3a459eaf69836a37abe16"` [INFO] [stdout] 06eb2df29a4c0c0219052c38bdc0284156cb35dbc7a3a459eaf69836a37abe16