[INFO] updating cached repository mistahchris/thesogu [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mistahchris/thesogu [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mistahchris/thesogu" "work/ex/clippy-test-run/sources/stable/gh/mistahchris/thesogu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mistahchris/thesogu'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mistahchris/thesogu" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mistahchris/thesogu"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mistahchris/thesogu'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 704498fff395b2087f62a535d75c4156bf50fe7b [INFO] sha for GitHub repo mistahchris/thesogu: 704498fff395b2087f62a535d75c4156bf50fe7b [INFO] validating manifest of mistahchris/thesogu on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mistahchris/thesogu on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mistahchris/thesogu [INFO] finished frobbing mistahchris/thesogu [INFO] frobbed toml for mistahchris/thesogu written to work/ex/clippy-test-run/sources/stable/gh/mistahchris/thesogu/Cargo.toml [INFO] started frobbing mistahchris/thesogu [INFO] finished frobbing mistahchris/thesogu [INFO] frobbed toml for mistahchris/thesogu written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mistahchris/thesogu/Cargo.toml [INFO] crate mistahchris/thesogu has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mistahchris/thesogu against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mistahchris/thesogu:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e8e44c337853c4f60ad13297233eebf5c2ad715509f8b873778eeadab12273ec [INFO] running `"docker" "start" "-a" "e8e44c337853c4f60ad13297233eebf5c2ad715509f8b873778eeadab12273ec"` [INFO] [stderr] Compiling rustc-demangle v0.1.7 [INFO] [stderr] Compiling num-traits v0.2.2 [INFO] [stderr] Compiling serde v1.0.36 [INFO] [stderr] Compiling remove_dir_all v0.5.0 [INFO] [stderr] Compiling openssl v0.10.5 [INFO] [stderr] Checking unidecode v0.2.0 [INFO] [stderr] Checking hostname v0.1.4 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Compiling crossbeam-utils v0.2.2 [INFO] [stderr] Checking tokio-executor v0.1.2 [INFO] [stderr] Compiling num_cpus v1.8.0 [INFO] [stderr] Compiling openssl-sys v0.9.27 [INFO] [stderr] Checking serde_json v1.0.13 [INFO] [stderr] Checking uuid v0.6.2 [INFO] [stderr] Checking resolv-conf v0.6.0 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Checking chrono v0.4.1 [INFO] [stderr] Checking http v0.1.5 [INFO] [stderr] Checking parking_lot v0.4.8 [INFO] [stderr] Compiling crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling backtrace-sys v0.1.16 [INFO] [stderr] Checking tokio-timer v0.2.0 [INFO] [stderr] Checking mio-uds v0.6.4 [INFO] [stderr] Compiling actix_derive v0.2.0 [INFO] [stderr] Compiling pest_derive v1.0.7 [INFO] [stderr] Checking url v1.7.0 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking slug v0.1.2 [INFO] [stderr] Compiling backtrace v0.3.5 [INFO] [stderr] Checking crossbeam-channel v0.1.2 [INFO] [stderr] Checking tokio-threadpool v0.1.2 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Compiling crossbeam-deque v0.2.0 [INFO] [stderr] Checking env_logger v0.5.6 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking h2 v0.1.3 [INFO] [stderr] Checking tokio v0.1.5 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking tera v0.11.6 [INFO] [stderr] Compiling semver v0.8.0 [INFO] [stderr] Checking tokio-core v0.1.16 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Compiling cargo_metadata v0.3.3 [INFO] [stderr] Checking trust-dns-proto v0.3.2 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Checking tokio-openssl v0.2.0 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Compiling skeptic v0.13.2 [INFO] [stderr] Compiling actix v0.5.5 [INFO] [stderr] Compiling actix-web v0.4.10 [INFO] [stderr] Checking trust-dns-resolver v0.8.1 [INFO] [stderr] Checking cookie v0.10.1 [INFO] [stderr] Checking thesogu v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `NamedFile` [INFO] [stderr] --> src/main.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | use actix_web::fs::{NamedFile, StaticFiles}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | const DEV_HTTPS_PORT: &'static str = "8443"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | if host.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:51:52 [INFO] [stderr] | [INFO] [stderr] 51 | let mut host_port: Vec<_> = new_host.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:106:10 [INFO] [stderr] | [INFO] [stderr] 106 | .expect(&format!("Cannot bind to {}", &https_ipaddr_port)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot bind to {}", &https_ipaddr_port))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:113:10 [INFO] [stderr] | [INFO] [stderr] 113 | .expect(&format!("Cannot bind to {}", &http_ipaddr_port)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot bind to {}", &http_ipaddr_port))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused import: `NamedFile` [INFO] [stderr] --> src/main.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | use actix_web::fs::{NamedFile, StaticFiles}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:18:24 [INFO] [stderr] | [INFO] [stderr] 18 | const DEV_HTTPS_PORT: &'static str = "8443"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | if host.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:51:52 [INFO] [stderr] | [INFO] [stderr] 51 | let mut host_port: Vec<_> = new_host.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:106:10 [INFO] [stderr] | [INFO] [stderr] 106 | .expect(&format!("Cannot bind to {}", &https_ipaddr_port)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot bind to {}", &https_ipaddr_port))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:113:10 [INFO] [stderr] | [INFO] [stderr] 113 | .expect(&format!("Cannot bind to {}", &http_ipaddr_port)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Cannot bind to {}", &http_ipaddr_port))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 32s [INFO] running `"docker" "inspect" "e8e44c337853c4f60ad13297233eebf5c2ad715509f8b873778eeadab12273ec"` [INFO] running `"docker" "rm" "-f" "e8e44c337853c4f60ad13297233eebf5c2ad715509f8b873778eeadab12273ec"` [INFO] [stdout] e8e44c337853c4f60ad13297233eebf5c2ad715509f8b873778eeadab12273ec