[INFO] updating cached repository miro662/swt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/miro662/swt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/miro662/swt" "work/ex/clippy-test-run/sources/stable/gh/miro662/swt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/miro662/swt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/miro662/swt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/miro662/swt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/miro662/swt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8a48953cb04a99d15ae74c93879c3cabfdeb3d87 [INFO] sha for GitHub repo miro662/swt: 8a48953cb04a99d15ae74c93879c3cabfdeb3d87 [INFO] validating manifest of miro662/swt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of miro662/swt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing miro662/swt [INFO] finished frobbing miro662/swt [INFO] frobbed toml for miro662/swt written to work/ex/clippy-test-run/sources/stable/gh/miro662/swt/Cargo.toml [INFO] started frobbing miro662/swt [INFO] finished frobbing miro662/swt [INFO] frobbed toml for miro662/swt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/miro662/swt/Cargo.toml [INFO] crate miro662/swt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting miro662/swt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/miro662/swt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e109df60bf42dae96c39e75d0895a83941316c620e52983d6b6f2d6e22a7ad44 [INFO] running `"docker" "start" "-a" "e109df60bf42dae96c39e75d0895a83941316c620e52983d6b6f2d6e22a7ad44"` [INFO] [stderr] Checking winapi v0.2.7 [INFO] [stderr] Checking libc v0.2.13 [INFO] [stderr] Checking ansi_term v0.8.0 [INFO] [stderr] Checking regex-syntax v0.3.3 [INFO] [stderr] Checking kernel32-sys v0.2.2 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking term_size v0.1.1 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking clap v2.10.4 [INFO] [stderr] Checking thread_local v0.2.6 [INFO] [stderr] Checking aho-corasick v0.5.2 [INFO] [stderr] Checking regex v0.1.71 [INFO] [stderr] Checking swt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/word.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/word.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: value assigned to `result` is never read [INFO] [stderr] --> src/word.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let mut result = false; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/word.rs:150:37 [INFO] [stderr] | [INFO] [stderr] 150 | let ext_regexp = Regex::new(r"^\*").unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/word.rs:156:32 [INFO] [stderr] | [INFO] [stderr] 156 | let eq_pos = line.find("=").expect("Cannot find = sign"); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/word.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | &basic_words.push(word.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `basic_words.push(word.clone());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | fn teach(wordbase:&WordBase, lang: Language) -> ! { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused label `'main` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / 'main: loop { [INFO] [stderr] 15 | | let mut word = rand::thread_rng().choose(wordbase).unwrap(); [INFO] [stderr] 16 | | 'choose: loop { [INFO] [stderr] 17 | | if *word != last_word { [INFO] [stderr] ... | [INFO] [stderr] 23 | | last_word = word.clone(); [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'choose` [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / 'choose: loop { [INFO] [stderr] 17 | | if *word != last_word { [INFO] [stderr] 18 | | break; [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | word = rand::thread_rng().choose(wordbase).unwrap(); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: value assigned to `result` is never read [INFO] [stderr] --> src/word.rs:65:17 [INFO] [stderr] | [INFO] [stderr] 65 | let mut result = false; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/word.rs:150:37 [INFO] [stderr] | [INFO] [stderr] 150 | let ext_regexp = Regex::new(r"^\*").unwrap(); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/word.rs:156:32 [INFO] [stderr] | [INFO] [stderr] 156 | let eq_pos = line.find("=").expect("Cannot find = sign"); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/word.rs:209:17 [INFO] [stderr] | [INFO] [stderr] 209 | &basic_words.push(word.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `basic_words.push(word.clone());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | fn teach(wordbase:&WordBase, lang: Language) -> ! { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused label `'main` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / 'main: loop { [INFO] [stderr] 15 | | let mut word = rand::thread_rng().choose(wordbase).unwrap(); [INFO] [stderr] 16 | | 'choose: loop { [INFO] [stderr] 17 | | if *word != last_word { [INFO] [stderr] ... | [INFO] [stderr] 23 | | last_word = word.clone(); [INFO] [stderr] 24 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'choose` [INFO] [stderr] --> src/main.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / 'choose: loop { [INFO] [stderr] 17 | | if *word != last_word { [INFO] [stderr] 18 | | break; [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | word = rand::thread_rng().choose(wordbase).unwrap(); [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.18s [INFO] running `"docker" "inspect" "e109df60bf42dae96c39e75d0895a83941316c620e52983d6b6f2d6e22a7ad44"` [INFO] running `"docker" "rm" "-f" "e109df60bf42dae96c39e75d0895a83941316c620e52983d6b6f2d6e22a7ad44"` [INFO] [stdout] e109df60bf42dae96c39e75d0895a83941316c620e52983d6b6f2d6e22a7ad44