[INFO] updating cached repository mindriot101/slideshow-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mindriot101/slideshow-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mindriot101/slideshow-rust" "work/ex/clippy-test-run/sources/stable/gh/mindriot101/slideshow-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mindriot101/slideshow-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mindriot101/slideshow-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mindriot101/slideshow-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mindriot101/slideshow-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 53c71df58b885a5c87367232b868f504ea7a4dd7 [INFO] sha for GitHub repo mindriot101/slideshow-rust: 53c71df58b885a5c87367232b868f504ea7a4dd7 [INFO] validating manifest of mindriot101/slideshow-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mindriot101/slideshow-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mindriot101/slideshow-rust [INFO] finished frobbing mindriot101/slideshow-rust [INFO] frobbed toml for mindriot101/slideshow-rust written to work/ex/clippy-test-run/sources/stable/gh/mindriot101/slideshow-rust/Cargo.toml [INFO] started frobbing mindriot101/slideshow-rust [INFO] finished frobbing mindriot101/slideshow-rust [INFO] frobbed toml for mindriot101/slideshow-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mindriot101/slideshow-rust/Cargo.toml [INFO] crate mindriot101/slideshow-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mindriot101/slideshow-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mindriot101/slideshow-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8f15b8a03e19c96cdbfa456228c8def0a6e62f1925800ee2f6ded9a0b822f3ed [INFO] running `"docker" "start" "-a" "8f15b8a03e19c96cdbfa456228c8def0a6e62f1925800ee2f6ded9a0b822f3ed"` [INFO] [stderr] Checking filetime v0.1.10 [INFO] [stderr] Checking inotify v0.3.0 [INFO] [stderr] Compiling cmake v0.1.25 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Checking walkdir v0.1.8 [INFO] [stderr] Compiling glfw-sys v3.2.2 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking notify v4.0.1 [INFO] [stderr] Checking glfw v0.17.0 [INFO] [stderr] Checking opengltesting v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader.rs:70:27 [INFO] [stderr] | [INFO] [stderr] 70 | ActivatedShader { id: id } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hotloader.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | messages: messages, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `messages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hotloader.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hotloader.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | watcher: watcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `watcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader.rs:70:27 [INFO] [stderr] | [INFO] [stderr] 70 | ActivatedShader { id: id } [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hotloader.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | messages: messages, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `messages` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hotloader.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/hotloader.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | watcher: watcher, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `watcher` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hotloader.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hotloader.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | let result = match self.messages.try_recv() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 26 | | Ok(RawEvent { path: Some(path), op: Ok(op), .. }) => { [INFO] [stderr] 27 | | if op.contains(op::WRITE) { [INFO] [stderr] 28 | | Some(path) [INFO] [stderr] ... | [INFO] [stderr] 33 | | _ => None, [INFO] [stderr] 34 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/hotloader.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/hotloader.rs:25:22 [INFO] [stderr] | [INFO] [stderr] 25 | let result = match self.messages.try_recv() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 26 | | Ok(RawEvent { path: Some(path), op: Ok(op), .. }) => { [INFO] [stderr] 27 | | if op.contains(op::WRITE) { [INFO] [stderr] 28 | | Some(path) [INFO] [stderr] ... | [INFO] [stderr] 33 | | _ => None, [INFO] [stderr] 34 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:121:23 [INFO] [stderr] | [INFO] [stderr] 121 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:125:19 [INFO] [stderr] | [INFO] [stderr] 125 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:151:23 [INFO] [stderr] | [INFO] [stderr] 151 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:155:19 [INFO] [stderr] | [INFO] [stderr] 155 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:188:23 [INFO] [stderr] | [INFO] [stderr] 188 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:192:19 [INFO] [stderr] | [INFO] [stderr] 192 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/geometry.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | if let None = self.vertices { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 35 | | return Err("No vertices supplied".into()) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________- help: try this: `if self.vertices.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:121:23 [INFO] [stderr] | [INFO] [stderr] 121 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:125:19 [INFO] [stderr] | [INFO] [stderr] 125 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:151:23 [INFO] [stderr] | [INFO] [stderr] 151 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:155:19 [INFO] [stderr] | [INFO] [stderr] 155 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:188:23 [INFO] [stderr] | [INFO] [stderr] 188 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader.rs:192:19 [INFO] [stderr] | [INFO] [stderr] 192 | if success != gl::TRUE as GLint { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/geometry.rs:34:16 [INFO] [stderr] | [INFO] [stderr] 34 | if let None = self.vertices { [INFO] [stderr] | _________- ^^^^ [INFO] [stderr] 35 | | return Err("No vertices supplied".into()) [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________- help: try this: `if self.vertices.is_none()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.11s [INFO] running `"docker" "inspect" "8f15b8a03e19c96cdbfa456228c8def0a6e62f1925800ee2f6ded9a0b822f3ed"` [INFO] running `"docker" "rm" "-f" "8f15b8a03e19c96cdbfa456228c8def0a6e62f1925800ee2f6ded9a0b822f3ed"` [INFO] [stdout] 8f15b8a03e19c96cdbfa456228c8def0a6e62f1925800ee2f6ded9a0b822f3ed