[INFO] updating cached repository minamorl/nova
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/minamorl/nova
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/minamorl/nova" "work/ex/clippy-test-run/sources/stable/gh/minamorl/nova"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/minamorl/nova'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/minamorl/nova" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/minamorl/nova"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/minamorl/nova'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3c82ce4ca2b44e77cd1f4887b4663e5975955e0a
[INFO] sha for GitHub repo minamorl/nova: 3c82ce4ca2b44e77cd1f4887b4663e5975955e0a
[INFO] validating manifest of minamorl/nova on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of minamorl/nova on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing minamorl/nova
[INFO] finished frobbing minamorl/nova
[INFO] frobbed toml for minamorl/nova written to work/ex/clippy-test-run/sources/stable/gh/minamorl/nova/Cargo.toml
[INFO] started frobbing minamorl/nova
[INFO] finished frobbing minamorl/nova
[INFO] frobbed toml for minamorl/nova written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/minamorl/nova/Cargo.toml
[INFO] crate minamorl/nova has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting minamorl/nova against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/minamorl/nova:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] cb551b2ff9ceb4ed1910bb94dc5c18b1c4429e5c77f961427b7287bf6816a353
[INFO] running `"docker" "start" "-a" "cb551b2ff9ceb4ed1910bb94dc5c18b1c4429e5c77f961427b7287bf6816a353"`
[INFO] [stderr]     Checking nova v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 |     result
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:30:18
[INFO] [stderr]    |
[INFO] [stderr] 30 |       let result = serde_json::from_str(contents.as_str())
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 31 | |         .map_err(|e| InternalError::ParseFailed(e));
[INFO] [stderr]    | |___________________________________________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:31:18
[INFO] [stderr]    |
[INFO] [stderr] 31 |         .map_err(|e| InternalError::ParseFailed(e));
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `InternalError::ParseFailed`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:32:5
[INFO] [stderr]    |
[INFO] [stderr] 32 |     result
[INFO] [stderr]    |     ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:30:18
[INFO] [stderr]    |
[INFO] [stderr] 30 |       let result = serde_json::from_str(contents.as_str())
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 31 | |         .map_err(|e| InternalError::ParseFailed(e));
[INFO] [stderr]    | |___________________________________________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/main.rs:31:18
[INFO] [stderr]    |
[INFO] [stderr] 31 |         .map_err(|e| InternalError::ParseFailed(e));
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `InternalError::ParseFailed`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.48s
[INFO] running `"docker" "inspect" "cb551b2ff9ceb4ed1910bb94dc5c18b1c4429e5c77f961427b7287bf6816a353"`
[INFO] running `"docker" "rm" "-f" "cb551b2ff9ceb4ed1910bb94dc5c18b1c4429e5c77f961427b7287bf6816a353"`
[INFO] [stdout] cb551b2ff9ceb4ed1910bb94dc5c18b1c4429e5c77f961427b7287bf6816a353