[INFO] updating cached repository milliams/plot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/milliams/plot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/milliams/plot" "work/ex/clippy-test-run/sources/stable/gh/milliams/plot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/milliams/plot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/milliams/plot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/milliams/plot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/milliams/plot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 42cd595ece41b6ca9086bd0d6f6a1267df64b8d1 [INFO] sha for GitHub repo milliams/plot: 42cd595ece41b6ca9086bd0d6f6a1267df64b8d1 [INFO] validating manifest of milliams/plot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of milliams/plot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing milliams/plot [INFO] removed workspace from milliams/plot [INFO] finished frobbing milliams/plot [INFO] frobbed toml for milliams/plot written to work/ex/clippy-test-run/sources/stable/gh/milliams/plot/Cargo.toml [INFO] started frobbing milliams/plot [INFO] removed workspace from milliams/plot [INFO] finished frobbing milliams/plot [INFO] frobbed toml for milliams/plot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/milliams/plot/Cargo.toml [INFO] crate milliams/plot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting milliams/plot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/milliams/plot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d8b55b9e85ca93f570acbbd21c58a8831e979fbd4416378847e29817c3d5d714 [INFO] running `"docker" "start" "-a" "d8b55b9e85ca93f570acbbd21c58a8831e979fbd4416378847e29817c3d5d714"` [INFO] [stderr] Checking plotlib v0.1.0 [INFO] [stderr] Checking clap v2.20.5 [INFO] [stderr] Checking plot v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:21:14 [INFO] [stderr] | [INFO] [stderr] 21 | .expect(&format!("ERROR: Could not parse '{}' as an f64", line_text))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("ERROR: Could not parse '{}' as an f64", line_text))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | .expect(&format!("ERROR: Could not parse '{}' as an f64", a)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("ERROR: Could not parse '{}' as an f64", a))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .expect(&format!("ERROR: Could not parse '{}' as an f64", b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("ERROR: Could not parse '{}' as an f64", b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | .expect(&format!("ERROR: Could not parse '{}' as an f64", line_text)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("ERROR: Could not parse '{}' as an f64", line_text))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | println!("{}", total / length as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:21:14 [INFO] [stderr] | [INFO] [stderr] 21 | .expect(&format!("ERROR: Could not parse '{}' as an f64", line_text))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("ERROR: Could not parse '{}' as an f64", line_text))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | .expect(&format!("ERROR: Could not parse '{}' as an f64", a)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("ERROR: Could not parse '{}' as an f64", a))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:44:14 [INFO] [stderr] | [INFO] [stderr] 44 | .expect(&format!("ERROR: Could not parse '{}' as an f64", b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("ERROR: Could not parse '{}' as an f64", b))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/lib.rs:78:14 [INFO] [stderr] | [INFO] [stderr] 78 | .expect(&format!("ERROR: Could not parse '{}' as an f64", line_text)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("ERROR: Could not parse '{}' as an f64", line_text))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:81:28 [INFO] [stderr] | [INFO] [stderr] 81 | println!("{}", total / length as f64); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(length)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/plot.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | let config = HistogramConfig { nbins: nbins }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nbins` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/plot.rs:48:44 [INFO] [stderr] | [INFO] [stderr] 48 | let config = HistogramConfig { nbins: nbins }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nbins` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.56s [INFO] running `"docker" "inspect" "d8b55b9e85ca93f570acbbd21c58a8831e979fbd4416378847e29817c3d5d714"` [INFO] running `"docker" "rm" "-f" "d8b55b9e85ca93f570acbbd21c58a8831e979fbd4416378847e29817c3d5d714"` [INFO] [stdout] d8b55b9e85ca93f570acbbd21c58a8831e979fbd4416378847e29817c3d5d714