[INFO] updating cached repository milesrout/ch [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/milesrout/ch [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/milesrout/ch" "work/ex/clippy-test-run/sources/stable/gh/milesrout/ch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/milesrout/ch'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/milesrout/ch" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/milesrout/ch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/milesrout/ch'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 69e2a86e86defa4845b5dc51954afca341bd66c2 [INFO] sha for GitHub repo milesrout/ch: 69e2a86e86defa4845b5dc51954afca341bd66c2 [INFO] validating manifest of milesrout/ch on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of milesrout/ch on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing milesrout/ch [INFO] finished frobbing milesrout/ch [INFO] frobbed toml for milesrout/ch written to work/ex/clippy-test-run/sources/stable/gh/milesrout/ch/Cargo.toml [INFO] started frobbing milesrout/ch [INFO] finished frobbing milesrout/ch [INFO] frobbed toml for milesrout/ch written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/milesrout/ch/Cargo.toml [INFO] crate milesrout/ch has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting milesrout/ch against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/milesrout/ch:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 40a3a2262f1a338ea51cb0a051e5e7e634e510c5a6d0de9b309ff42dc561ff3b [INFO] running `"docker" "start" "-a" "40a3a2262f1a338ea51cb0a051e5e7e634e510c5a6d0de9b309ff42dc561ff3b"` [INFO] [stderr] Compiling gcc v0.3.38 [INFO] [stderr] Checking either v1.0.1 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking itertools v0.5.5 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Compiling backtrace-sys v0.1.5 [INFO] [stderr] Checking regex v0.1.80 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking ch v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:248:17 [INFO] [stderr] | [INFO] [stderr] 248 | Token { name: name, string: string, } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:248:29 [INFO] [stderr] | [INFO] [stderr] 248 | Token { name: name, string: string, } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:248:17 [INFO] [stderr] | [INFO] [stderr] 248 | Token { name: name, string: string, } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:248:29 [INFO] [stderr] | [INFO] [stderr] 248 | Token { name: name, string: string, } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `string` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_expr` [INFO] [stderr] --> src/parser.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn parse_expr(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `parse_expr` [INFO] [stderr] --> src/parser.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | pub fn parse_expr(&mut self) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lexer.rs:276:18 [INFO] [stderr] | [INFO] [stderr] 276 | .map(|r| Lexer(r)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `Lexer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lexer.rs:276:18 [INFO] [stderr] | [INFO] [stderr] 276 | .map(|r| Lexer(r)) [INFO] [stderr] | ^^^^^^^^^^^^ help: remove closure as shown: `Lexer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lexer.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | / match self { [INFO] [stderr] 325 | | &Error::Regex(ref err) => (err as &error::Error).description(), [INFO] [stderr] 326 | | &Error::NoTokens => "there are no tokens in the given string", [INFO] [stderr] 327 | | &Error::BadToken(_) => "a bad token was encountered", [INFO] [stderr] 328 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 324 | match *self { [INFO] [stderr] 325 | Error::Regex(ref err) => (err as &error::Error).description(), [INFO] [stderr] 326 | Error::NoTokens => "there are no tokens in the given string", [INFO] [stderr] 327 | Error::BadToken(_) => "a bad token was encountered", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lexer.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | / match self { [INFO] [stderr] 325 | | &Error::Regex(ref err) => (err as &error::Error).description(), [INFO] [stderr] 326 | | &Error::NoTokens => "there are no tokens in the given string", [INFO] [stderr] 327 | | &Error::BadToken(_) => "a bad token was encountered", [INFO] [stderr] 328 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 324 | match *self { [INFO] [stderr] 325 | Error::Regex(ref err) => (err as &error::Error).description(), [INFO] [stderr] 326 | Error::NoTokens => "there are no tokens in the given string", [INFO] [stderr] 327 | Error::BadToken(_) => "a bad token was encountered", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/parser.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / pub fn new(mut tokens: I) -> Result>> { [INFO] [stderr] 110 | | let first = tokens.next(); [INFO] [stderr] 111 | | first.map(|tok| Parser { [INFO] [stderr] 112 | | current_token: tok, [INFO] [stderr] 113 | | tokens: tokens.fuse(), [INFO] [stderr] 114 | | }).ok_or(ParserError::new(TooFewTokens)) [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | }).ok_or(ParserError::new(TooFewTokens)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ParserError::new(TooFewTokens))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | Ok(self.current_token = self.tokens.next() [INFO] [stderr] | ____________^ [INFO] [stderr] 128 | | .ok_or(ParserError::new(TooFewTokens))?) [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 127 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser.rs:128:14 [INFO] [stderr] | [INFO] [stderr] 128 | .ok_or(ParserError::new(TooFewTokens))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ParserError::new(TooFewTokens))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/parser.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | / pub fn new(mut tokens: I) -> Result>> { [INFO] [stderr] 110 | | let first = tokens.next(); [INFO] [stderr] 111 | | first.map(|tok| Parser { [INFO] [stderr] 112 | | current_token: tok, [INFO] [stderr] 113 | | tokens: tokens.fuse(), [INFO] [stderr] 114 | | }).ok_or(ParserError::new(TooFewTokens)) [INFO] [stderr] 115 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser.rs:114:12 [INFO] [stderr] | [INFO] [stderr] 114 | }).ok_or(ParserError::new(TooFewTokens)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ParserError::new(TooFewTokens))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | Ok(self.current_token = self.tokens.next() [INFO] [stderr] | ____________^ [INFO] [stderr] 128 | | .ok_or(ParserError::new(TooFewTokens))?) [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 127 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser.rs:128:14 [INFO] [stderr] | [INFO] [stderr] 128 | .ok_or(ParserError::new(TooFewTokens))?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ParserError::new(TooFewTokens))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/parser.rs:413:52 [INFO] [stderr] | [INFO] [stderr] 413 | } else if self.accept(TokenType::LSqBrack) { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 414 | | self.call_or_idx_expr(expr) [INFO] [stderr] 415 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/parser.rs:411:43 [INFO] [stderr] | [INFO] [stderr] 411 | if self.accept(TokenType::LBrack) { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 412 | | self.call_or_idx_expr(expr) [INFO] [stderr] 413 | | } else if self.accept(TokenType::LSqBrack) { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/parser.rs:413:52 [INFO] [stderr] | [INFO] [stderr] 413 | } else if self.accept(TokenType::LSqBrack) { [INFO] [stderr] | ____________________________________________________^ [INFO] [stderr] 414 | | self.call_or_idx_expr(expr) [INFO] [stderr] 415 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/parser.rs:411:43 [INFO] [stderr] | [INFO] [stderr] 411 | if self.accept(TokenType::LBrack) { [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 412 | | self.call_or_idx_expr(expr) [INFO] [stderr] 413 | | } else if self.accept(TokenType::LSqBrack) { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:18:10 [INFO] [stderr] | [INFO] [stderr] 18 | .expect(format!("Could not open file {:}", path.to_string_lossy()).as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not open file {:}", path.to_string_lossy()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | .expect(format!("Could not read from file {:}", path.to_string_lossy()).as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not read from file {:}", path.to_string_lossy()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:18:10 [INFO] [stderr] | [INFO] [stderr] 18 | .expect(format!("Could not open file {:}", path.to_string_lossy()).as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not open file {:}", path.to_string_lossy()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:22:10 [INFO] [stderr] | [INFO] [stderr] 22 | .expect(format!("Could not read from file {:}", path.to_string_lossy()).as_ref()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not read from file {:}", path.to_string_lossy()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: Could not compile `ch`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `ch`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "40a3a2262f1a338ea51cb0a051e5e7e634e510c5a6d0de9b309ff42dc561ff3b"` [INFO] running `"docker" "rm" "-f" "40a3a2262f1a338ea51cb0a051e5e7e634e510c5a6d0de9b309ff42dc561ff3b"` [INFO] [stdout] 40a3a2262f1a338ea51cb0a051e5e7e634e510c5a6d0de9b309ff42dc561ff3b