[INFO] updating cached repository mikeecb/ring [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mikeecb/ring [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mikeecb/ring" "work/ex/clippy-test-run/sources/stable/gh/mikeecb/ring"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mikeecb/ring'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mikeecb/ring" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mikeecb/ring"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mikeecb/ring'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 987ccd80b1e70b4856a0e11c37e0b91b368dd968 [INFO] sha for GitHub repo mikeecb/ring: 987ccd80b1e70b4856a0e11c37e0b91b368dd968 [INFO] validating manifest of mikeecb/ring on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mikeecb/ring on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mikeecb/ring [INFO] finished frobbing mikeecb/ring [INFO] frobbed toml for mikeecb/ring written to work/ex/clippy-test-run/sources/stable/gh/mikeecb/ring/Cargo.toml [INFO] started frobbing mikeecb/ring [INFO] finished frobbing mikeecb/ring [INFO] frobbed toml for mikeecb/ring written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mikeecb/ring/Cargo.toml [INFO] crate mikeecb/ring has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mikeecb/ring against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mikeecb/ring:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fa1fc8ae3efc32458c1ef78b131222fb93e14cae2c1116e72324b82de04c4bb3 [INFO] running `"docker" "start" "-a" "fa1fc8ae3efc32458c1ef78b131222fb93e14cae2c1116e72324b82de04c4bb3"` [INFO] [stderr] Compiling libc v0.2.26 [INFO] [stderr] Checking unicode-xid v0.0.3 [INFO] [stderr] Checking ipnetwork v0.12.6 [INFO] [stderr] Checking pnet_macros_support v0.1.1 [INFO] [stderr] Checking syntex_pos v0.42.0 [INFO] [stderr] Checking syntex_errors v0.42.0 [INFO] [stderr] Compiling memchr v1.0.1 [INFO] [stderr] Compiling aho-corasick v0.6.3 [INFO] [stderr] Checking syntex_syntax v0.42.0 [INFO] [stderr] Compiling regex v0.2.2 [INFO] [stderr] Checking syntex v0.42.2 [INFO] [stderr] Checking pnet_macros v0.13.1 [INFO] [stderr] Compiling pnet v0.17.1 [INFO] [stderr] Checking ring v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / fn populate_ping_packet<'a>(packet: &'a mut echo_request::MutableEchoRequestPacket, id: u16, seq_num: u16) { [INFO] [stderr] 71 | | packet.set_icmp_type(IcmpTypes::EchoRequest); [INFO] [stderr] 72 | | packet.set_icmp_code(echo_request::IcmpCodes::NoCode); [INFO] [stderr] 73 | | packet.set_identifier(id); [INFO] [stderr] ... | [INFO] [stderr] 80 | | packet.set_payload(nanos.to_string().as_bytes()); [INFO] [stderr] 81 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:231:63 [INFO] [stderr] | [INFO] [stderr] 231 | fn init_config(config: &mut Config, opts: &mut Options, args: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/main.rs:70:1 [INFO] [stderr] | [INFO] [stderr] 70 | / fn populate_ping_packet<'a>(packet: &'a mut echo_request::MutableEchoRequestPacket, id: u16, seq_num: u16) { [INFO] [stderr] 71 | | packet.set_icmp_type(IcmpTypes::EchoRequest); [INFO] [stderr] 72 | | packet.set_icmp_code(echo_request::IcmpCodes::NoCode); [INFO] [stderr] 73 | | packet.set_identifier(id); [INFO] [stderr] ... | [INFO] [stderr] 80 | | packet.set_payload(nanos.to_string().as_bytes()); [INFO] [stderr] 81 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:231:63 [INFO] [stderr] | [INFO] [stderr] 231 | fn init_config(config: &mut Config, opts: &mut Options, args: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 39.10s [INFO] running `"docker" "inspect" "fa1fc8ae3efc32458c1ef78b131222fb93e14cae2c1116e72324b82de04c4bb3"` [INFO] running `"docker" "rm" "-f" "fa1fc8ae3efc32458c1ef78b131222fb93e14cae2c1116e72324b82de04c4bb3"` [INFO] [stdout] fa1fc8ae3efc32458c1ef78b131222fb93e14cae2c1116e72324b82de04c4bb3