[INFO] updating cached repository miguelmota/ether_convert
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/miguelmota/ether_convert
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/miguelmota/ether_convert" "work/ex/clippy-test-run/sources/stable/gh/miguelmota/ether_convert"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/miguelmota/ether_convert'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/miguelmota/ether_convert" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/miguelmota/ether_convert"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/miguelmota/ether_convert'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a9c44cefe9888cc6724a26c970a5d0f8008bb777
[INFO] sha for GitHub repo miguelmota/ether_convert: a9c44cefe9888cc6724a26c970a5d0f8008bb777
[INFO] validating manifest of miguelmota/ether_convert on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of miguelmota/ether_convert on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing miguelmota/ether_convert
[INFO] finished frobbing miguelmota/ether_convert
[INFO] frobbed toml for miguelmota/ether_convert written to work/ex/clippy-test-run/sources/stable/gh/miguelmota/ether_convert/Cargo.toml
[INFO] started frobbing miguelmota/ether_convert
[INFO] finished frobbing miguelmota/ether_convert
[INFO] frobbed toml for miguelmota/ether_convert written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/miguelmota/ether_convert/Cargo.toml
[INFO] crate miguelmota/ether_convert has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting miguelmota/ether_convert against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/miguelmota/ether_convert:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 395355682dab37853b5715a7ada2b01e1913094bdb5bf9f610b8c904703d2d15
[INFO] running `"docker" "start" "-a" "395355682dab37853b5715a7ada2b01e1913094bdb5bf9f610b8c904703d2d15"`
[INFO] [stderr]     Checking ether_convert v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/main.rs:84:5
[INFO] [stderr]    |
[INFO] [stderr] 84 |     return map;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `map`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/main.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 |     return v.mul(&BigDecimal::from_str(u).unwrap());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.mul(&BigDecimal::from_str(u).unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/main.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     return v.mul(&BigDecimal::from_str(u).unwrap()).to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.mul(&BigDecimal::from_str(u).unwrap()).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/main.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     return re.replace_all(&v, "$1").to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `re.replace_all(&v, "$1").to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/main.rs:84:5
[INFO] [stderr]    |
[INFO] [stderr] 84 |     return map;
[INFO] [stderr]    |     ^^^^^^^^^^^ help: remove `return` as shown: `map`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/main.rs:88:5
[INFO] [stderr]    |
[INFO] [stderr] 88 |     return v.mul(&BigDecimal::from_str(u).unwrap());
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.mul(&BigDecimal::from_str(u).unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/main.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     return v.mul(&BigDecimal::from_str(u).unwrap()).to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.mul(&BigDecimal::from_str(u).unwrap()).to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/bin/main.rs:99:5
[INFO] [stderr]    |
[INFO] [stderr] 99 |     return re.replace_all(&v, "$1").to_string();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `re.replace_all(&v, "$1").to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/bin/main.rs:41:20
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let unit = ordermap.get(&i).unwrap();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&ordermap[&i]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/bin/main.rs:42:21
[INFO] [stderr]    |
[INFO] [stderr] 42 |         let value = map.get(unit).unwrap();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[unit]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/bin/main.rs:41:20
[INFO] [stderr]    |
[INFO] [stderr] 41 |         let unit = ordermap.get(&i).unwrap();
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&ordermap[&i]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/bin/main.rs:42:21
[INFO] [stderr]    |
[INFO] [stderr] 42 |         let value = map.get(unit).unwrap();
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[unit]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.07s
[INFO] running `"docker" "inspect" "395355682dab37853b5715a7ada2b01e1913094bdb5bf9f610b8c904703d2d15"`
[INFO] running `"docker" "rm" "-f" "395355682dab37853b5715a7ada2b01e1913094bdb5bf9f610b8c904703d2d15"`
[INFO] [stdout] 395355682dab37853b5715a7ada2b01e1913094bdb5bf9f610b8c904703d2d15