[INFO] updating cached repository michaelsugita/test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/michaelsugita/test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/michaelsugita/test" "work/ex/clippy-test-run/sources/stable/gh/michaelsugita/test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/michaelsugita/test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/michaelsugita/test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michaelsugita/test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michaelsugita/test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2907fb7e356fab7aee8453bd573b4e38eed5a34a [INFO] sha for GitHub repo michaelsugita/test: 2907fb7e356fab7aee8453bd573b4e38eed5a34a [INFO] validating manifest of michaelsugita/test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of michaelsugita/test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing michaelsugita/test [INFO] finished frobbing michaelsugita/test [INFO] frobbed toml for michaelsugita/test written to work/ex/clippy-test-run/sources/stable/gh/michaelsugita/test/Cargo.toml [INFO] started frobbing michaelsugita/test [INFO] finished frobbing michaelsugita/test [INFO] frobbed toml for michaelsugita/test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michaelsugita/test/Cargo.toml [INFO] crate michaelsugita/test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting michaelsugita/test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/michaelsugita/test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 18e87d7dedbb18c59d48eb5d76851c53973c8c7fa294d418f1e29ba970856422 [INFO] running `"docker" "start" "-a" "18e87d7dedbb18c59d48eb5d76851c53973c8c7fa294d418f1e29ba970856422"` [INFO] [stderr] Checking rgssad v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:135:82 [INFO] [stderr] | [INFO] [stderr] 135 | Ok(RGSSArchive { magic: if version == 3 { 0u32 } else { 0xDEADCAFEu32 }, version: version, entry: HashMap::::new(), stream: stream }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:135:144 [INFO] [stderr] | [INFO] [stderr] 135 | Ok(RGSSArchive { magic: if version == 3 { 0u32 } else { 0xDEADCAFEu32 }, version: version, entry: HashMap::::new(), stream: stream }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:191:33 [INFO] [stderr] | [INFO] [stderr] 191 | return Ok(RGSSArchive { magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `magic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:191:47 [INFO] [stderr] | [INFO] [stderr] 191 | return Ok(RGSSArchive { magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:191:65 [INFO] [stderr] | [INFO] [stderr] 191 | return Ok(RGSSArchive { magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:191:79 [INFO] [stderr] | [INFO] [stderr] 191 | return Ok(RGSSArchive { magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:234:17 [INFO] [stderr] | [INFO] [stderr] 234 | size: size, offset: offset, magic: start_magic [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:234:29 [INFO] [stderr] | [INFO] [stderr] 234 | size: size, offset: offset, magic: start_magic [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:241:32 [INFO] [stderr] | [INFO] [stderr] 241 | return Ok(RGSSArchive {magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `magic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:241:46 [INFO] [stderr] | [INFO] [stderr] 241 | return Ok(RGSSArchive {magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:241:64 [INFO] [stderr] | [INFO] [stderr] 241 | return Ok(RGSSArchive {magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:241:78 [INFO] [stderr] | [INFO] [stderr] 241 | return Ok(RGSSArchive {magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:135:82 [INFO] [stderr] | [INFO] [stderr] 135 | Ok(RGSSArchive { magic: if version == 3 { 0u32 } else { 0xDEADCAFEu32 }, version: version, entry: HashMap::::new(), stream: stream }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:135:144 [INFO] [stderr] | [INFO] [stderr] 135 | Ok(RGSSArchive { magic: if version == 3 { 0u32 } else { 0xDEADCAFEu32 }, version: version, entry: HashMap::::new(), stream: stream }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:191:33 [INFO] [stderr] | [INFO] [stderr] 191 | return Ok(RGSSArchive { magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `magic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:191:47 [INFO] [stderr] | [INFO] [stderr] 191 | return Ok(RGSSArchive { magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:191:65 [INFO] [stderr] | [INFO] [stderr] 191 | return Ok(RGSSArchive { magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:191:79 [INFO] [stderr] | [INFO] [stderr] 191 | return Ok(RGSSArchive { magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:234:17 [INFO] [stderr] | [INFO] [stderr] 234 | size: size, offset: offset, magic: start_magic [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:234:29 [INFO] [stderr] | [INFO] [stderr] 234 | size: size, offset: offset, magic: start_magic [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:241:32 [INFO] [stderr] | [INFO] [stderr] 241 | return Ok(RGSSArchive {magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `magic` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:241:46 [INFO] [stderr] | [INFO] [stderr] 241 | return Ok(RGSSArchive {magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:241:64 [INFO] [stderr] | [INFO] [stderr] 241 | return Ok(RGSSArchive {magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `entry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:241:78 [INFO] [stderr] | [INFO] [stderr] 241 | return Ok(RGSSArchive {magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return old; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `old` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:39:45 [INFO] [stderr] | [INFO] [stderr] 39 | *result = (((buff[0] as u32) << 0x00) & 0x000000FF) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:40:45 [INFO] [stderr] | [INFO] [stderr] 40 | (((buff[1] as u32) << 0x08) & 0x0000FF00) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_FF00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | (((buff[2] as u32) << 0x10) & 0x00FF0000) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:42:45 [INFO] [stderr] | [INFO] [stderr] 42 | (((buff[3] as u32) << 0x18) & 0xFF000000) ; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | buff[0] = (data & 0x000000FF) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | buff[1] = ((data & 0x0000FF00) >> 0x08) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_FF00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:52:24 [INFO] [stderr] | [INFO] [stderr] 52 | buff[2] = ((data & 0x00FF0000) >> 0x10) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | buff[3] = ((data & 0xFF000000) >> 0x18) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:135:65 [INFO] [stderr] | [INFO] [stderr] 135 | Ok(RGSSArchive { magic: if version == 3 { 0u32 } else { 0xDEADCAFEu32 }, version: version, entry: HashMap::::new(), stream: stream }) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xDEAD_CAFEu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / return match header[7] { [INFO] [stderr] 155 | | 1|2 => RGSSArchive::open_rgssad(stream, header[7]), [INFO] [stderr] 156 | | 3 => RGSSArchive::open_rgss3a(stream, header[7]), [INFO] [stderr] 157 | | _ => Err(Error::new(ErrorKind::InvalidData, E_INVALIDVER)), [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 154 | match header[7] { [INFO] [stderr] 155 | 1|2 => RGSSArchive::open_rgssad(stream, header[7]), [INFO] [stderr] 156 | 3 => RGSSArchive::open_rgss3a(stream, header[7]), [INFO] [stderr] 157 | _ => Err(Error::new(ErrorKind::InvalidData, E_INVALIDVER)), [INFO] [stderr] 158 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | return Ok(RGSSArchive { magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RGSSArchive { magic: magic, version: version, entry: entry, stream: stream })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:162:25 [INFO] [stderr] | [INFO] [stderr] 162 | let mut magic = 0xDEADCAFEu32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xDEAD_CAFEu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | return Ok(RGSSArchive {magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RGSSArchive {magic: magic, version: version, entry: entry, stream: stream })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:226:34 [INFO] [stderr] | [INFO] [stderr] 226 | name_buf[i] ^= ((magic >> 8*(i%4)) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `magic >> (8*(i%4))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | return File::create(path.to_str().unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `File::create(path.to_str().unwrap()).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | return old; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `old` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:39:45 [INFO] [stderr] | [INFO] [stderr] 39 | *result = (((buff[0] as u32) << 0x00) & 0x000000FF) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:40:45 [INFO] [stderr] | [INFO] [stderr] 40 | (((buff[1] as u32) << 0x08) & 0x0000FF00) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_FF00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:41:45 [INFO] [stderr] | [INFO] [stderr] 41 | (((buff[2] as u32) << 0x10) & 0x00FF0000) | [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:42:45 [INFO] [stderr] | [INFO] [stderr] 42 | (((buff[3] as u32) << 0x18) & 0xFF000000) ; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | buff[0] = (data & 0x000000FF) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | buff[1] = ((data & 0x0000FF00) >> 0x08) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_FF00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:52:24 [INFO] [stderr] | [INFO] [stderr] 52 | buff[2] = ((data & 0x00FF0000) >> 0x10) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FF_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:53:24 [INFO] [stderr] | [INFO] [stderr] 53 | buff[3] = ((data & 0xFF000000) >> 0x18) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:114:9 [INFO] [stderr] | [INFO] [stderr] 114 | return count; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `count` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:135:65 [INFO] [stderr] | [INFO] [stderr] 135 | Ok(RGSSArchive { magic: if version == 3 { 0u32 } else { 0xDEADCAFEu32 }, version: version, entry: HashMap::::new(), stream: stream }) [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xDEAD_CAFEu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | / return match header[7] { [INFO] [stderr] 155 | | 1|2 => RGSSArchive::open_rgssad(stream, header[7]), [INFO] [stderr] 156 | | 3 => RGSSArchive::open_rgss3a(stream, header[7]), [INFO] [stderr] 157 | | _ => Err(Error::new(ErrorKind::InvalidData, E_INVALIDVER)), [INFO] [stderr] 158 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 154 | match header[7] { [INFO] [stderr] 155 | 1|2 => RGSSArchive::open_rgssad(stream, header[7]), [INFO] [stderr] 156 | 3 => RGSSArchive::open_rgss3a(stream, header[7]), [INFO] [stderr] 157 | _ => Err(Error::new(ErrorKind::InvalidData, E_INVALIDVER)), [INFO] [stderr] 158 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | return Ok(RGSSArchive { magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RGSSArchive { magic: magic, version: version, entry: entry, stream: stream })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:162:25 [INFO] [stderr] | [INFO] [stderr] 162 | let mut magic = 0xDEADCAFEu32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0xDEAD_CAFEu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | return Ok(RGSSArchive {magic: magic, version: version, entry: entry, stream: stream }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(RGSSArchive {magic: magic, version: version, entry: entry, stream: stream })` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/main.rs:226:34 [INFO] [stderr] | [INFO] [stderr] 226 | name_buf[i] ^= ((magic >> 8*(i%4)) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `magic >> (8*(i%4))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:318:9 [INFO] [stderr] | [INFO] [stderr] 318 | return File::create(path.to_str().unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `File::create(path.to_str().unwrap()).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key` [INFO] [stderr] --> src/main.rs:291:21 [INFO] [stderr] | [INFO] [stderr] 291 | let key = path.strip_prefix(r).unwrap().to_str().unwrap(); [INFO] [stderr] | ^^^ help: consider using `_key` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `stream` [INFO] [stderr] --> src/main.rs:292:25 [INFO] [stderr] | [INFO] [stderr] 292 | let mut stream = File::open(&path).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider using `_stream` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/main.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | fn write(&mut self, buf: &Take) { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `key` [INFO] [stderr] --> src/main.rs:291:21 [INFO] [stderr] | [INFO] [stderr] 291 | let key = path.strip_prefix(r).unwrap().to_str().unwrap(); [INFO] [stderr] | ^^^ help: consider using `_key` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `stream` [INFO] [stderr] --> src/main.rs:292:25 [INFO] [stderr] | [INFO] [stderr] 292 | let mut stream = File::open(&path).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider using `_stream` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `buf` [INFO] [stderr] --> src/main.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | fn write(&mut self, buf: &Take) { [INFO] [stderr] | ^^^ help: consider using `_buf` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `wu32` [INFO] [stderr] --> src/main.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | fn wu32(stream: &mut File, data: &u32) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write` [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | fn write(&mut self, buf: &Take) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `magic` [INFO] [stderr] --> src/main.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | magic: u32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `version` [INFO] [stderr] --> src/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | version: u8, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if let Err(_) = stream.read_exact(&mut buff) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 36 | | return false; [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____- help: try this: `if stream.read_exact(&mut buff).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(buff[0] as u32)` [INFO] [stderr] --> src/main.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | *result = (((buff[0] as u32) << 0x00) & 0x000000FF) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | *result = (((buff[0] as u32) << 0x00) & 0x000000FF) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(buff[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | (((buff[1] as u32) << 0x08) & 0x0000FF00) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(buff[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | (((buff[2] as u32) << 0x10) & 0x00FF0000) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(buff[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | (((buff[3] as u32) << 0x18) & 0xFF000000) ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(buff[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:47:34 [INFO] [stderr] | [INFO] [stderr] 47 | fn wu32(stream: &mut File, data: &u32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if let Err(_) = stream.write_all(&buff[..]) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 56 | | return false; [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____- help: try this: `if stream.write_all(&buff[..]).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/main.rs:101:23 [INFO] [stderr] | [INFO] [stderr] 101 | let dat = buf[..len*4].as_mut_ptr() as *mut u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: function is never used: `wu32` [INFO] [stderr] --> src/main.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | fn wu32(stream: &mut File, data: &u32) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `write` [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | fn write(&mut self, buf: &Take) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `magic` [INFO] [stderr] --> src/main.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | magic: u32, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `version` [INFO] [stderr] --> src/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | version: u8, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | stream.write_all(&[b'R', b'G', b'S', b'S', b'A', b'D', version]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:35:12 [INFO] [stderr] | [INFO] [stderr] 35 | if let Err(_) = stream.read_exact(&mut buff) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 36 | | return false; [INFO] [stderr] 37 | | } [INFO] [stderr] | |_____- help: try this: `if stream.read_exact(&mut buff).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(buff[0] as u32)` [INFO] [stderr] --> src/main.rs:39:16 [INFO] [stderr] | [INFO] [stderr] 39 | *result = (((buff[0] as u32) << 0x00) & 0x000000FF) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:39:17 [INFO] [stderr] | [INFO] [stderr] 39 | *result = (((buff[0] as u32) << 0x00) & 0x000000FF) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(buff[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | (((buff[1] as u32) << 0x08) & 0x0000FF00) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(buff[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | (((buff[2] as u32) << 0x10) & 0x00FF0000) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(buff[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | (((buff[3] as u32) << 0x18) & 0xFF000000) ; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u32::from(buff[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:47:34 [INFO] [stderr] | [INFO] [stderr] 47 | fn wu32(stream: &mut File, data: &u32) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:55:12 [INFO] [stderr] | [INFO] [stderr] 55 | if let Err(_) = stream.write_all(&buff[..]) { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 56 | | return false; [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____- help: try this: `if stream.write_all(&buff[..]).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `name_buf`. [INFO] [stderr] --> src/main.rs:172:22 [INFO] [stderr] | [INFO] [stderr] 172 | for i in 0..(name_len as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut u32`) [INFO] [stderr] --> src/main.rs:101:23 [INFO] [stderr] | [INFO] [stderr] 101 | let dat = buf[..len*4].as_mut_ptr() as *mut u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 172 | for in name_buf.iter_mut().take((name_len as usize)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:174:35 [INFO] [stderr] | [INFO] [stderr] 174 | if name_buf[i] == '\\' as u8 { name_buf[i] = '/' as u8 } [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\\' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:174:62 [INFO] [stderr] | [INFO] [stderr] 174 | if name_buf[i] == '\\' as u8 { name_buf[i] = '/' as u8 } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'/' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:177:20 [INFO] [stderr] | [INFO] [stderr] 177 | if let Err(_) = name_buf { break } [INFO] [stderr] | -------^^^^^^--------------------- help: try this: `if name_buf.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:186:43 [INFO] [stderr] | [INFO] [stderr] 186 | stream.seek(SeekFrom::Current(data.size as i64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(data.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | stream.write_all(&[b'R', b'G', b'S', b'S', b'A', b'D', version]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `name_buf` [INFO] [stderr] --> src/main.rs:225:22 [INFO] [stderr] | [INFO] [stderr] 225 | for i in 0..(name_len as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 225 | for (i, ) in name_buf.iter_mut().enumerate().take((name_len as usize)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:227:35 [INFO] [stderr] | [INFO] [stderr] 227 | if name_buf[i] == '\\' as u8 { name_buf[i] = '/' as u8 } [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\\' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:227:62 [INFO] [stderr] | [INFO] [stderr] 227 | if name_buf[i] == '\\' as u8 { name_buf[i] = '/' as u8 } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'/' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:230:20 [INFO] [stderr] | [INFO] [stderr] 230 | if let Err(_) = name_buf { break } [INFO] [stderr] | -------^^^^^^--------------------- help: try this: `if name_buf.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:248:45 [INFO] [stderr] | [INFO] [stderr] 248 | stream.seek(SeekFrom::Start(entry.offset as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(entry.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:252:41 [INFO] [stderr] | [INFO] [stderr] 252 | stream: stream.take(entry.size as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(entry.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `name_buf`. [INFO] [stderr] --> src/main.rs:172:22 [INFO] [stderr] | [INFO] [stderr] 172 | for i in 0..(name_len as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 172 | for in name_buf.iter_mut().take((name_len as usize)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:174:35 [INFO] [stderr] | [INFO] [stderr] 174 | if name_buf[i] == '\\' as u8 { name_buf[i] = '/' as u8 } [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\\' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:174:62 [INFO] [stderr] | [INFO] [stderr] 174 | if name_buf[i] == '\\' as u8 { name_buf[i] = '/' as u8 } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'/' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:177:20 [INFO] [stderr] | [INFO] [stderr] 177 | if let Err(_) = name_buf { break } [INFO] [stderr] | -------^^^^^^--------------------- help: try this: `if name_buf.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:186:43 [INFO] [stderr] | [INFO] [stderr] 186 | stream.seek(SeekFrom::Current(data.size as i64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(data.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `name_buf` [INFO] [stderr] --> src/main.rs:225:22 [INFO] [stderr] | [INFO] [stderr] 225 | for i in 0..(name_len as usize) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 225 | for (i, ) in name_buf.iter_mut().enumerate().take((name_len as usize)) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:227:35 [INFO] [stderr] | [INFO] [stderr] 227 | if name_buf[i] == '\\' as u8 { name_buf[i] = '/' as u8 } [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'\\' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/main.rs:227:62 [INFO] [stderr] | [INFO] [stderr] 227 | if name_buf[i] == '\\' as u8 { name_buf[i] = '/' as u8 } [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'/' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:230:20 [INFO] [stderr] | [INFO] [stderr] 230 | if let Err(_) = name_buf { break } [INFO] [stderr] | -------^^^^^^--------------------- help: try this: `if name_buf.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:248:45 [INFO] [stderr] | [INFO] [stderr] 248 | stream.seek(SeekFrom::Start(entry.offset as u64))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(entry.offset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:252:41 [INFO] [stderr] | [INFO] [stderr] 252 | stream: stream.take(entry.size as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u64::from(entry.size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rgssad`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `rgssad`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "18e87d7dedbb18c59d48eb5d76851c53973c8c7fa294d418f1e29ba970856422"` [INFO] running `"docker" "rm" "-f" "18e87d7dedbb18c59d48eb5d76851c53973c8c7fa294d418f1e29ba970856422"` [INFO] [stdout] 18e87d7dedbb18c59d48eb5d76851c53973c8c7fa294d418f1e29ba970856422