[INFO] updating cached repository michaelsdunn1/bitcoin [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/michaelsdunn1/bitcoin [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/michaelsdunn1/bitcoin" "work/ex/clippy-test-run/sources/stable/gh/michaelsdunn1/bitcoin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/michaelsdunn1/bitcoin'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/michaelsdunn1/bitcoin" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michaelsdunn1/bitcoin"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michaelsdunn1/bitcoin'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 73c262ebdd755038e08fa132c518922ccbd5c246 [INFO] sha for GitHub repo michaelsdunn1/bitcoin: 73c262ebdd755038e08fa132c518922ccbd5c246 [INFO] validating manifest of michaelsdunn1/bitcoin on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of michaelsdunn1/bitcoin on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing michaelsdunn1/bitcoin [INFO] finished frobbing michaelsdunn1/bitcoin [INFO] frobbed toml for michaelsdunn1/bitcoin written to work/ex/clippy-test-run/sources/stable/gh/michaelsdunn1/bitcoin/Cargo.toml [INFO] started frobbing michaelsdunn1/bitcoin [INFO] finished frobbing michaelsdunn1/bitcoin [INFO] frobbed toml for michaelsdunn1/bitcoin written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michaelsdunn1/bitcoin/Cargo.toml [INFO] crate michaelsdunn1/bitcoin has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting michaelsdunn1/bitcoin against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/michaelsdunn1/bitcoin:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 57fffa115c50f44d5113a357dedb584e294f430b1697ff67c84850d9295384fd [INFO] running `"docker" "start" "-a" "57fffa115c50f44d5113a357dedb584e294f430b1697ff67c84850d9295384fd"` [INFO] [stderr] Checking byte-tools v0.1.3 [INFO] [stderr] Checking base16 v0.1.1 [INFO] [stderr] Checking base58 v0.1.0 [INFO] [stderr] Compiling secp256k1 v0.11.1 [INFO] [stderr] Checking generic-array v0.7.3 [INFO] [stderr] Checking ripemd160 v0.7.0 [INFO] [stderr] Checking digest-buffer v0.3.1 [INFO] [stderr] Checking digest v0.5.2 [INFO] [stderr] Checking sha2 v0.5.3 [INFO] [stderr] Checking bitcoin v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Secp256k1` [INFO] [stderr] --> src/keys.rs:15:23 [INFO] [stderr] | [INFO] [stderr] 15 | use self::secp256k1::{Secp256k1, SecretKey, PublicKey}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/keys.rs:104:26 [INFO] [stderr] | [INFO] [stderr] 104 | assert_eq!(checksum, 4286807748u32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `4_286_807_748u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/keys.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn decode_base58_check(s: &String) -> (u8, String, u32) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/keys.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | &buf.clone_from_slice(hasher.result().as_slice()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf.clone_from_slice(hasher.result().as_slice());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/keys.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | &buf.clone_from_slice(hasher.result().as_slice()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf.clone_from_slice(hasher.result().as_slice());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/keys.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | pub fn decode_base58_check(s: &String) -> (u8, String, u32) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/keys.rs:74:5 [INFO] [stderr] | [INFO] [stderr] 74 | &buf.clone_from_slice(hasher.result().as_slice()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf.clone_from_slice(hasher.result().as_slice());` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/keys.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | &buf.clone_from_slice(hasher.result().as_slice()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `buf.clone_from_slice(hasher.result().as_slice());` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.93s [INFO] running `"docker" "inspect" "57fffa115c50f44d5113a357dedb584e294f430b1697ff67c84850d9295384fd"` [INFO] running `"docker" "rm" "-f" "57fffa115c50f44d5113a357dedb584e294f430b1697ff67c84850d9295384fd"` [INFO] [stdout] 57fffa115c50f44d5113a357dedb584e294f430b1697ff67c84850d9295384fd