[INFO] updating cached repository michaelmelanson/fab-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/michaelmelanson/fab-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/michaelmelanson/fab-rs" "work/ex/clippy-test-run/sources/stable/gh/michaelmelanson/fab-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/michaelmelanson/fab-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/michaelmelanson/fab-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michaelmelanson/fab-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michaelmelanson/fab-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cd17836710344a00827a1d213e6cd3dbe765ca09 [INFO] sha for GitHub repo michaelmelanson/fab-rs: cd17836710344a00827a1d213e6cd3dbe765ca09 [INFO] validating manifest of michaelmelanson/fab-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of michaelmelanson/fab-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing michaelmelanson/fab-rs [INFO] finished frobbing michaelmelanson/fab-rs [INFO] frobbed toml for michaelmelanson/fab-rs written to work/ex/clippy-test-run/sources/stable/gh/michaelmelanson/fab-rs/Cargo.toml [INFO] started frobbing michaelmelanson/fab-rs [INFO] finished frobbing michaelmelanson/fab-rs [INFO] frobbed toml for michaelmelanson/fab-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michaelmelanson/fab-rs/Cargo.toml [INFO] crate michaelmelanson/fab-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting michaelmelanson/fab-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/michaelmelanson/fab-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4ddc6ac8e8de0dbfde2de262c7208fe4ff97a5aecc848cae68d7de5eb24a7e9a [INFO] running `"docker" "start" "-a" "4ddc6ac8e8de0dbfde2de262c7208fe4ff97a5aecc848cae68d7de5eb24a7e9a"` [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking fab v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/makefile.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | fn parse_line(original: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/makefile.rs:93:30 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn parse_makefile(input: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/plan.rs:117:18 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn find_rule<'a>(makefile: &Makefile, target: &Target) -> Rule { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/makefile.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | fn parse_line(original: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/makefile.rs:93:30 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn parse_makefile(input: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/plan.rs:117:18 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn find_rule<'a>(makefile: &Makefile, target: &Target) -> Rule { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/makefile.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | fn parse_line(original: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/makefile.rs:93:30 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn parse_makefile(input: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/plan.rs:117:18 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn find_rule<'a>(makefile: &Makefile, target: &Target) -> Rule { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/makefile.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | fn parse_line(original: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/makefile.rs:93:30 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn parse_makefile(input: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/plan.rs:117:18 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn find_rule<'a>(makefile: &Makefile, target: &Target) -> Rule { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.77s [INFO] running `"docker" "inspect" "4ddc6ac8e8de0dbfde2de262c7208fe4ff97a5aecc848cae68d7de5eb24a7e9a"` [INFO] running `"docker" "rm" "-f" "4ddc6ac8e8de0dbfde2de262c7208fe4ff97a5aecc848cae68d7de5eb24a7e9a"` [INFO] [stdout] 4ddc6ac8e8de0dbfde2de262c7208fe4ff97a5aecc848cae68d7de5eb24a7e9a