[INFO] updating cached repository michael-robbins/filemapper [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/michael-robbins/filemapper [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/michael-robbins/filemapper" "work/ex/clippy-test-run/sources/stable/gh/michael-robbins/filemapper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/michael-robbins/filemapper'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/michael-robbins/filemapper" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michael-robbins/filemapper"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michael-robbins/filemapper'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a92a4ed3b7e2cea28bc2dd07f752ee2cd316967b [INFO] sha for GitHub repo michael-robbins/filemapper: a92a4ed3b7e2cea28bc2dd07f752ee2cd316967b [INFO] validating manifest of michael-robbins/filemapper on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of michael-robbins/filemapper on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing michael-robbins/filemapper [INFO] finished frobbing michael-robbins/filemapper [INFO] frobbed toml for michael-robbins/filemapper written to work/ex/clippy-test-run/sources/stable/gh/michael-robbins/filemapper/Cargo.toml [INFO] started frobbing michael-robbins/filemapper [INFO] finished frobbing michael-robbins/filemapper [INFO] frobbed toml for michael-robbins/filemapper written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michael-robbins/filemapper/Cargo.toml [INFO] crate michael-robbins/filemapper has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting michael-robbins/filemapper against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/michael-robbins/filemapper:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e357ebd8086172cf6c559020bd933ae2eb877b1b69e1225bbefc8b32b7290f00 [INFO] running `"docker" "start" "-a" "e357ebd8086172cf6c559020bd933ae2eb877b1b69e1225bbefc8b32b7290f00"` [INFO] [stderr] Compiling serde v1.0.68 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Checking file_mapper v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | source_file: source_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | mapping_files: mapping_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mapping_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping_file.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | delimiter: delimiter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delimiter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping_file.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | source_key_index: source_key_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_key_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping_file.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | target_key_index: target_key_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_key_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/source_file.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | delimiter: delimiter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delimiter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | cache_size: cache_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cache_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | source_file: source_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | mapping_files: mapping_files, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `mapping_files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping_file.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | delimiter: delimiter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delimiter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping_file.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | source_key_index: source_key_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `source_key_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mapping_file.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | target_key_index: target_key_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `target_key_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/source_file.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | delimiter: delimiter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delimiter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cache.rs:25:17 [INFO] [stderr] | [INFO] [stderr] 25 | cache_size: cache_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cache_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/config.rs:103:11 [INFO] [stderr] | [INFO] [stderr] 103 | match delimiter.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `delimiter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/mapping_file.rs:67:47 [INFO] [stderr] | [INFO] [stderr] 67 | let target_line = target_line.expect(&format!("Unable to read line from mapping file {}", self.filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to read line from mapping file {}", self.filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/mapping_file.rs:70:52 [INFO] [stderr] | [INFO] [stderr] 70 | .expect(&format!("Unable to parse the target key from mapping file {}", self.filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Unable to parse the target key from mapping file {}", self.filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/config.rs:103:11 [INFO] [stderr] | [INFO] [stderr] 103 | match delimiter.as_ref() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try this: `delimiter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/mapping_file.rs:67:47 [INFO] [stderr] | [INFO] [stderr] 67 | let target_line = target_line.expect(&format!("Unable to read line from mapping file {}", self.filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Unable to read line from mapping file {}", self.filename))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/mapping_file.rs:70:52 [INFO] [stderr] | [INFO] [stderr] 70 | .expect(&format!("Unable to parse the target key from mapping file {}", self.filename)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("Unable to parse the target key from mapping file {}", self.filename))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.40s [INFO] running `"docker" "inspect" "e357ebd8086172cf6c559020bd933ae2eb877b1b69e1225bbefc8b32b7290f00"` [INFO] running `"docker" "rm" "-f" "e357ebd8086172cf6c559020bd933ae2eb877b1b69e1225bbefc8b32b7290f00"` [INFO] [stdout] e357ebd8086172cf6c559020bd933ae2eb877b1b69e1225bbefc8b32b7290f00