[INFO] updating cached repository michael-ar/rust-footy-cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/michael-ar/rust-footy-cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/michael-ar/rust-footy-cli" "work/ex/clippy-test-run/sources/stable/gh/michael-ar/rust-footy-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/michael-ar/rust-footy-cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/michael-ar/rust-footy-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michael-ar/rust-footy-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michael-ar/rust-footy-cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d5c702e6b185fa3d11cd091eb6369a8b59a6b10d [INFO] sha for GitHub repo michael-ar/rust-footy-cli: d5c702e6b185fa3d11cd091eb6369a8b59a6b10d [INFO] validating manifest of michael-ar/rust-footy-cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of michael-ar/rust-footy-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing michael-ar/rust-footy-cli [INFO] finished frobbing michael-ar/rust-footy-cli [INFO] frobbed toml for michael-ar/rust-footy-cli written to work/ex/clippy-test-run/sources/stable/gh/michael-ar/rust-footy-cli/Cargo.toml [INFO] started frobbing michael-ar/rust-footy-cli [INFO] finished frobbing michael-ar/rust-footy-cli [INFO] frobbed toml for michael-ar/rust-footy-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/michael-ar/rust-footy-cli/Cargo.toml [INFO] crate michael-ar/rust-footy-cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting michael-ar/rust-footy-cli against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/michael-ar/rust-footy-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 086dd11ea5632d0eb121982dffde254b02d9b3831f86a0f2258253627b86cdd0 [INFO] running `"docker" "start" "-a" "086dd11ea5632d0eb121982dffde254b02d9b3831f86a0f2258253627b86cdd0"` [INFO] [stderr] Checking encoding_rs v0.7.2 [INFO] [stderr] Checking termios v0.2.2 [INFO] [stderr] Checking clicolors-control v0.2.0 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking smallvec v0.6.4 [INFO] [stderr] Checking clap v2.29.4 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking libflate v0.1.16 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking chrono v0.4.5 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.2 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking parking_lot v0.6.3 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking dialoguer v0.1.0 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.6 [INFO] [stderr] Checking footy v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/configure.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | token [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/configure.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | let token = Input::new( [INFO] [stderr] | _________________^ [INFO] [stderr] 47 | | "Insert your API token (available free from https://www.football-data.org/)", [INFO] [stderr] 48 | | ).interact() [INFO] [stderr] 49 | | .unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/configure.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | token [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/configure.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | let token = Input::new( [INFO] [stderr] | _________________^ [INFO] [stderr] 47 | | "Insert your API token (available free from https://www.football-data.org/)", [INFO] [stderr] 48 | | ).interact() [INFO] [stderr] 49 | | .unwrap(); [INFO] [stderr] | |_________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/utils.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | let mut path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/utils.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | let mut path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | let mut path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/utils.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | let mut path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/utils.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | let mut path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:36:24 [INFO] [stderr] | [INFO] [stderr] 36 | let mut path = env::home_dir().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/configure.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | for ref standing in standings.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/configure.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | for ref standing in standings.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^ --------------------- help: try: `let standing = &standings.into_iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/requests.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn get_fixtures(league: &String) -> (Option, Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/requests.rs:63:32 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn get_team_fixtures(team: &String) -> (Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/requests.rs:111:27 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn get_league(league: &String) -> League { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/configure.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | for ref standing in standings.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/configure.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | for ref standing in standings.into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^ --------------------- help: try: `let standing = &standings.into_iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/requests.rs:23:29 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn get_fixtures(league: &String) -> (Option, Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/requests.rs:63:32 [INFO] [stderr] | [INFO] [stderr] 63 | pub fn get_team_fixtures(team: &String) -> (Vec) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/requests.rs:111:27 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn get_league(league: &String) -> League { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn format_date(date: &String) -> (String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/utils.rs:10:26 [INFO] [stderr] | [INFO] [stderr] 10 | pub fn format_date(date: &String) -> (String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.21s [INFO] running `"docker" "inspect" "086dd11ea5632d0eb121982dffde254b02d9b3831f86a0f2258253627b86cdd0"` [INFO] running `"docker" "rm" "-f" "086dd11ea5632d0eb121982dffde254b02d9b3831f86a0f2258253627b86cdd0"` [INFO] [stdout] 086dd11ea5632d0eb121982dffde254b02d9b3831f86a0f2258253627b86cdd0