[INFO] updating cached repository mgax/dedup
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mgax/dedup
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mgax/dedup" "work/ex/clippy-test-run/sources/stable/gh/mgax/dedup"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mgax/dedup'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mgax/dedup" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mgax/dedup"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mgax/dedup'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3a647cc46255876b23652711f3bc66cf2b16b2b9
[INFO] sha for GitHub repo mgax/dedup: 3a647cc46255876b23652711f3bc66cf2b16b2b9
[INFO] validating manifest of mgax/dedup on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mgax/dedup on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mgax/dedup
[INFO] finished frobbing mgax/dedup
[INFO] frobbed toml for mgax/dedup written to work/ex/clippy-test-run/sources/stable/gh/mgax/dedup/Cargo.toml
[INFO] started frobbing mgax/dedup
[INFO] finished frobbing mgax/dedup
[INFO] frobbed toml for mgax/dedup written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mgax/dedup/Cargo.toml
[INFO] crate mgax/dedup has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mgax/dedup against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mgax/dedup:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9772e21b28e994eaf4ff87d10bb015832f631c920eedca10e09c67fd1cab16dc
[INFO] running `"docker" "start" "-a" "9772e21b28e994eaf4ff87d10bb015832f631c920eedca10e09c67fd1cab16dc"`
[INFO] [stderr]    Compiling rust-crypto v0.2.36
[INFO] [stderr]     Checking regex v0.2.0
[INFO] [stderr]     Checking dedup v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/memory_repo.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             block_size: block_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/deduplicator.rs:124:13
[INFO] [stderr]     |
[INFO] [stderr] 124 |             repo: repo,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `repo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/deduplicator.rs:125:13
[INFO] [stderr]     |
[INFO] [stderr] 125 |             reader: reader,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/memory_repo.rs:50:13
[INFO] [stderr]    |
[INFO] [stderr] 50 |             block_size: block_size,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_size`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/deduplicator.rs:124:13
[INFO] [stderr]     |
[INFO] [stderr] 124 |             repo: repo,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `repo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/deduplicator.rs:125:13
[INFO] [stderr]     |
[INFO] [stderr] 125 |             reader: reader,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `reader`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/deduplicator.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         return hash;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/deduplicator.rs:138:9
[INFO] [stderr]     |
[INFO] [stderr] 138 |         return Ok(stats);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(stats)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deduplicator.rs:110:28
[INFO] [stderr]     |
[INFO] [stderr] 110 |                         if buffer.len() > 0 {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:20:41
[INFO] [stderr]    |
[INFO] [stderr] 20 |     fn write_block(&mut self, block_id: &Vec<u8>, block: Vec<u8>);
[INFO] [stderr]    |                                         ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:21:40
[INFO] [stderr]    |
[INFO] [stderr] 21 |     fn contains_block(&self, block_id: &Vec<u8>) -> bool;
[INFO] [stderr]    |                                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:22:36
[INFO] [stderr]    |
[INFO] [stderr] 22 |     fn read_block(&self, block_id: &Vec<u8>) -> Result<&Vec<u8>, LoadError>;
[INFO] [stderr]    |                                    ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/deduplicator.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 |         return hash;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/deduplicator.rs:138:9
[INFO] [stderr]     |
[INFO] [stderr] 138 |         return Ok(stats);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(stats)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]  --> src/testsuite.rs:8:5
[INFO] [stderr]   |
[INFO] [stderr] 8 |     return cursor.into_inner();
[INFO] [stderr]   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cursor.into_inner()`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/deduplicator.rs:110:28
[INFO] [stderr]     |
[INFO] [stderr] 110 |                         if buffer.len() > 0 {
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buffer.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/testsuite.rs:12:15
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let fox = "the quick brown fox jumps over the lazy dog".as_bytes();
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"the quick brown fox jumps over the lazy dog"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/testsuite.rs:18:19
[INFO] [stderr]    |
[INFO] [stderr] 18 |     let fox_one = "the quick brown fox jumps over the lazy dog".as_bytes();
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"the quick brown fox jumps over the lazy dog"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/testsuite.rs:19:19
[INFO] [stderr]    |
[INFO] [stderr] 19 |     let fox_two = "the qqq brown rabbit jumpd over the lazy dog".as_bytes();
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"the qqq brown rabbit jumpd over the lazy dog"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/testsuite.rs:35:15
[INFO] [stderr]    |
[INFO] [stderr] 35 |     let fox = "the quick brown fox jumps over the lazy dog".as_bytes();
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"the quick brown fox jumps over the lazy dog"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:20:41
[INFO] [stderr]    |
[INFO] [stderr] 20 |     fn write_block(&mut self, block_id: &Vec<u8>, block: Vec<u8>);
[INFO] [stderr]    |                                         ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:21:40
[INFO] [stderr]    |
[INFO] [stderr] 21 |     fn contains_block(&self, block_id: &Vec<u8>) -> bool;
[INFO] [stderr]    |                                        ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/lib.rs:22:36
[INFO] [stderr]    |
[INFO] [stderr] 22 |     fn read_block(&self, block_id: &Vec<u8>) -> Result<&Vec<u8>, LoadError>;
[INFO] [stderr]    |                                    ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/bin/stresstest.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             tmpfile.write(&buffer).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `dedup`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> src/bin/stresstest.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 |             tmpfile.write(&buffer).unwrap();
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `dedup`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "9772e21b28e994eaf4ff87d10bb015832f631c920eedca10e09c67fd1cab16dc"`
[INFO] running `"docker" "rm" "-f" "9772e21b28e994eaf4ff87d10bb015832f631c920eedca10e09c67fd1cab16dc"`
[INFO] [stdout] 9772e21b28e994eaf4ff87d10bb015832f631c920eedca10e09c67fd1cab16dc