[INFO] updating cached repository mgattozzi/ReVim [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mgattozzi/ReVim [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mgattozzi/ReVim" "work/ex/clippy-test-run/sources/stable/gh/mgattozzi/ReVim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mgattozzi/ReVim'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mgattozzi/ReVim" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mgattozzi/ReVim"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mgattozzi/ReVim'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 848308e706d3721a91ec8a9e01c02cabd71d3551 [INFO] sha for GitHub repo mgattozzi/ReVim: 848308e706d3721a91ec8a9e01c02cabd71d3551 [INFO] validating manifest of mgattozzi/ReVim on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mgattozzi/ReVim on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mgattozzi/ReVim [INFO] finished frobbing mgattozzi/ReVim [INFO] frobbed toml for mgattozzi/ReVim written to work/ex/clippy-test-run/sources/stable/gh/mgattozzi/ReVim/Cargo.toml [INFO] started frobbing mgattozzi/ReVim [INFO] finished frobbing mgattozzi/ReVim [INFO] frobbed toml for mgattozzi/ReVim written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mgattozzi/ReVim/Cargo.toml [INFO] crate mgattozzi/ReVim has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mgattozzi/ReVim against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mgattozzi/ReVim:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 88bf90297a2fa3eb05d313242bb3d48dbd74ff6d89d392fe317f22efed309c80 [INFO] running `"docker" "start" "-a" "88bf90297a2fa3eb05d313242bb3d48dbd74ff6d89d392fe317f22efed309c80"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking error-chain v0.11.0-rc.2 [INFO] [stderr] Checking revim v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | / match key? { [INFO] [stderr] 95 | | Key::Esc => mode = Mode::Normal, [INFO] [stderr] 96 | | _ => {}, [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Key::Esc = key? { mode = Mode::Normal }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | / match key? { [INFO] [stderr] 101 | | Key::Esc => mode = Mode::Normal, [INFO] [stderr] 102 | | _ => {}, [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Key::Esc = key? { mode = Mode::Normal }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | / match key? { [INFO] [stderr] 107 | | Key::Esc => mode = Mode::Normal, [INFO] [stderr] 108 | | _ => {}, [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Key::Esc = key? { mode = Mode::Normal }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | / match key? { [INFO] [stderr] 113 | | Key::Esc => mode = Mode::Normal, [INFO] [stderr] 114 | | _ => {}, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Key::Esc = key? { mode = Mode::Normal }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | x.unwrap_or(String::new()).to_owned() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `x.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | / match key? { [INFO] [stderr] 95 | | Key::Esc => mode = Mode::Normal, [INFO] [stderr] 96 | | _ => {}, [INFO] [stderr] 97 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Key::Esc = key? { mode = Mode::Normal }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:100:17 [INFO] [stderr] | [INFO] [stderr] 100 | / match key? { [INFO] [stderr] 101 | | Key::Esc => mode = Mode::Normal, [INFO] [stderr] 102 | | _ => {}, [INFO] [stderr] 103 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Key::Esc = key? { mode = Mode::Normal }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | / match key? { [INFO] [stderr] 107 | | Key::Esc => mode = Mode::Normal, [INFO] [stderr] 108 | | _ => {}, [INFO] [stderr] 109 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Key::Esc = key? { mode = Mode::Normal }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | / match key? { [INFO] [stderr] 113 | | Key::Esc => mode = Mode::Normal, [INFO] [stderr] 114 | | _ => {}, [INFO] [stderr] 115 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Key::Esc = key? { mode = Mode::Normal }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:150:33 [INFO] [stderr] | [INFO] [stderr] 150 | x.unwrap_or(String::new()).to_owned() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `x.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.07s [INFO] running `"docker" "inspect" "88bf90297a2fa3eb05d313242bb3d48dbd74ff6d89d392fe317f22efed309c80"` [INFO] running `"docker" "rm" "-f" "88bf90297a2fa3eb05d313242bb3d48dbd74ff6d89d392fe317f22efed309c80"` [INFO] [stdout] 88bf90297a2fa3eb05d313242bb3d48dbd74ff6d89d392fe317f22efed309c80