[INFO] updating cached repository mfs/shady
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mfs/shady
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mfs/shady" "work/ex/clippy-test-run/sources/stable/gh/mfs/shady"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mfs/shady'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mfs/shady" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfs/shady"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfs/shady'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5081e36a64b449294ad0bc82a62ef1d324ad3086
[INFO] sha for GitHub repo mfs/shady: 5081e36a64b449294ad0bc82a62ef1d324ad3086
[INFO] validating manifest of mfs/shady on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mfs/shady on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mfs/shady
[INFO] finished frobbing mfs/shady
[INFO] frobbed toml for mfs/shady written to work/ex/clippy-test-run/sources/stable/gh/mfs/shady/Cargo.toml
[INFO] started frobbing mfs/shady
[INFO] finished frobbing mfs/shady
[INFO] frobbed toml for mfs/shady written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfs/shady/Cargo.toml
[INFO] crate mfs/shady has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mfs/shady against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mfs/shady:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 55c432342198e3337c541243ae6eda845d7de399500d80122994b14c04660701
[INFO] running `"docker" "start" "-a" "55c432342198e3337c541243ae6eda845d7de399500d80122994b14c04660701"`
[INFO] [stderr]     Checking inotify v0.3.0
[INFO] [stderr]     Checking filetime v0.1.10
[INFO] [stderr]    Compiling backtrace-sys v0.1.10
[INFO] [stderr]     Checking net2 v0.2.29
[INFO] [stderr]     Checking nix v0.5.1
[INFO] [stderr]    Compiling glium v0.16.0
[INFO] [stderr]     Checking miow v0.1.5
[INFO] [stderr]     Checking mio v0.5.1
[INFO] [stderr]     Checking notify v4.0.1
[INFO] [stderr]     Checking backtrace v0.2.3
[INFO] [stderr]     Checking shady v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/shaders.rs:2:41
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub const DEFAULT_FRAGMENT_SHADER_SRC: &'static str = r#"
[INFO] [stderr]   |                                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/shaders.rs:19:31
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub const VERTEX_SHADER_SRC: &'static str = r#"
[INFO] [stderr]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     program
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:31:19
[INFO] [stderr]    |
[INFO] [stderr] 31 |       let program = glium::Program::from_source(display, shaders::VERTEX_SHADER_SRC,
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 32 | |                                               &fragment_shader_src, None);
[INFO] [stderr]    | |_________________________________________________________________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:53:19
[INFO] [stderr]    |
[INFO] [stderr] 53 |         Ok(p)  => return p,
[INFO] [stderr]    |                   ^^^^^^^^ help: remove `return` as shown: `p`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/shaders.rs:2:41
[INFO] [stderr]   |
[INFO] [stderr] 2 | pub const DEFAULT_FRAGMENT_SHADER_SRC: &'static str = r#"
[INFO] [stderr]   |                                        -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/shaders.rs:19:31
[INFO] [stderr]    |
[INFO] [stderr] 19 | pub const VERTEX_SHADER_SRC: &'static str = r#"
[INFO] [stderr]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/main.rs:33:5
[INFO] [stderr]    |
[INFO] [stderr] 33 |     program
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/main.rs:31:19
[INFO] [stderr]    |
[INFO] [stderr] 31 |       let program = glium::Program::from_source(display, shaders::VERTEX_SHADER_SRC,
[INFO] [stderr]    |  ___________________^
[INFO] [stderr] 32 | |                                               &fragment_shader_src, None);
[INFO] [stderr]    | |_________________________________________________________________________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:53:19
[INFO] [stderr]    |
[INFO] [stderr] 53 |         Ok(p)  => return p,
[INFO] [stderr]    |                   ^^^^^^^^ help: remove `return` as shown: `p`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 36.85s
[INFO] running `"docker" "inspect" "55c432342198e3337c541243ae6eda845d7de399500d80122994b14c04660701"`
[INFO] running `"docker" "rm" "-f" "55c432342198e3337c541243ae6eda845d7de399500d80122994b14c04660701"`
[INFO] [stdout] 55c432342198e3337c541243ae6eda845d7de399500d80122994b14c04660701