[INFO] updating cached repository mfs/dupr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mfs/dupr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mfs/dupr" "work/ex/clippy-test-run/sources/stable/gh/mfs/dupr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mfs/dupr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mfs/dupr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfs/dupr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfs/dupr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 931e91b70178bb9ef2bb65deadd0dd81341697e3 [INFO] sha for GitHub repo mfs/dupr: 931e91b70178bb9ef2bb65deadd0dd81341697e3 [INFO] validating manifest of mfs/dupr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mfs/dupr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mfs/dupr [INFO] finished frobbing mfs/dupr [INFO] frobbed toml for mfs/dupr written to work/ex/clippy-test-run/sources/stable/gh/mfs/dupr/Cargo.toml [INFO] started frobbing mfs/dupr [INFO] finished frobbing mfs/dupr [INFO] frobbed toml for mfs/dupr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfs/dupr/Cargo.toml [INFO] crate mfs/dupr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mfs/dupr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mfs/dupr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e757125bf367096d6fd050da5b100100d5e1ff643105bb503be004a5eb6ecd2d [INFO] running `"docker" "start" "-a" "e757125bf367096d6fd050da5b100100d5e1ff643105bb503be004a5eb6ecd2d"` [INFO] [stderr] Checking same-file v0.1.3 [INFO] [stderr] Checking twox-hash v1.1.0 [INFO] [stderr] Checking walkdir v1.0.7 [INFO] [stderr] Checking dupr v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:66:19 [INFO] [stderr] | [INFO] [stderr] 66 | let walkdir = match matches.is_present("recurse") { [INFO] [stderr] | ___________________^ [INFO] [stderr] 67 | | true => WalkDir::new(dir).into_iter().enumerate(), [INFO] [stderr] 68 | | false => WalkDir::new(dir).max_depth(1).into_iter().enumerate(), [INFO] [stderr] 69 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if matches.is_present("recurse") { WalkDir::new(dir).into_iter().enumerate() } else { WalkDir::new(dir).max_depth(1).into_iter().enumerate() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:106:14 [INFO] [stderr] | [INFO] [stderr] 106 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:154:42 [INFO] [stderr] | [INFO] [stderr] 154 | inode_paths.entry(dev_inode).or_insert(Vec::new()).push( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | .or_insert(BTreeSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTreeSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:66:19 [INFO] [stderr] | [INFO] [stderr] 66 | let walkdir = match matches.is_present("recurse") { [INFO] [stderr] | ___________________^ [INFO] [stderr] 67 | | true => WalkDir::new(dir).into_iter().enumerate(), [INFO] [stderr] 68 | | false => WalkDir::new(dir).max_depth(1).into_iter().enumerate(), [INFO] [stderr] 69 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if matches.is_present("recurse") { WalkDir::new(dir).into_iter().enumerate() } else { WalkDir::new(dir).max_depth(1).into_iter().enumerate() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:106:14 [INFO] [stderr] | [INFO] [stderr] 106 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:154:42 [INFO] [stderr] | [INFO] [stderr] 154 | inode_paths.entry(dev_inode).or_insert(Vec::new()).push( [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:163:22 [INFO] [stderr] | [INFO] [stderr] 163 | .or_insert(BTreeSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(BTreeSet::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.50s [INFO] running `"docker" "inspect" "e757125bf367096d6fd050da5b100100d5e1ff643105bb503be004a5eb6ecd2d"` [INFO] running `"docker" "rm" "-f" "e757125bf367096d6fd050da5b100100d5e1ff643105bb503be004a5eb6ecd2d"` [INFO] [stdout] e757125bf367096d6fd050da5b100100d5e1ff643105bb503be004a5eb6ecd2d