[INFO] updating cached repository mfs/box
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mfs/box
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mfs/box" "work/ex/clippy-test-run/sources/stable/gh/mfs/box"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mfs/box'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mfs/box" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfs/box"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfs/box'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3cef007c04a03b7abdb96611f209166ede476017
[INFO] sha for GitHub repo mfs/box: 3cef007c04a03b7abdb96611f209166ede476017
[INFO] validating manifest of mfs/box on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mfs/box on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mfs/box
[INFO] finished frobbing mfs/box
[INFO] frobbed toml for mfs/box written to work/ex/clippy-test-run/sources/stable/gh/mfs/box/Cargo.toml
[INFO] started frobbing mfs/box
[INFO] finished frobbing mfs/box
[INFO] frobbed toml for mfs/box written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfs/box/Cargo.toml
[INFO] crate mfs/box has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mfs/box against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mfs/box:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1611240c416b59a51079ca7741fce5d6622854ad0ef5520371dd19d70566f3a8
[INFO] running `"docker" "start" "-a" "1611240c416b59a51079ca7741fce5d6622854ad0ef5520371dd19d70566f3a8"`
[INFO] [stderr]     Checking box v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cpu.rs:46:13
[INFO] [stderr]    |
[INFO] [stderr] 46 |             hardware: hardware
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `hardware`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/cpu.rs:453:9
[INFO] [stderr]     |
[INFO] [stderr] 453 | /         write!(f, "r{:02}: {:x} r{:02}: {:x}   r{:02}: {:x} r{:02}: {:x}   r{:02}: {:x} r{:02}: {:x}   r{:02}: {:x} r{:02}: {:x}\n",
[INFO] [stderr] 454 | |                8, self.index_registers[8], 9, self.index_registers[9],
[INFO] [stderr] 455 | |                10, self.index_registers[10], 11, self.index_registers[11],
[INFO] [stderr] 456 | |                12, self.index_registers[12], 13, self.index_registers[13],
[INFO] [stderr] 457 | |                14, self.index_registers[14], 15, self.index_registers[15])
[INFO] [stderr]     | |__________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/cpu.rs:46:13
[INFO] [stderr]    |
[INFO] [stderr] 46 |             hardware: hardware
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `hardware`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead
[INFO] [stderr]    --> src/cpu.rs:453:9
[INFO] [stderr]     |
[INFO] [stderr] 453 | /         write!(f, "r{:02}: {:x} r{:02}: {:x}   r{:02}: {:x} r{:02}: {:x}   r{:02}: {:x} r{:02}: {:x}   r{:02}: {:x} r{:02}: {:x}\n",
[INFO] [stderr] 454 | |                8, self.index_registers[8], 9, self.index_registers[9],
[INFO] [stderr] 455 | |                10, self.index_registers[10], 11, self.index_registers[11],
[INFO] [stderr] 456 | |                12, self.index_registers[12], 13, self.index_registers[13],
[INFO] [stderr] 457 | |                14, self.index_registers[14], 15, self.index_registers[15])
[INFO] [stderr]     | |__________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::write_with_newline)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/bin/assembler.rs:7:22
[INFO] [stderr]   |
[INFO] [stderr] 7 | const INSTRUCTIONS: &'static [&'static str] = &[
[INFO] [stderr]   |                     -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/bin/assembler.rs:7:32
[INFO] [stderr]   |
[INFO] [stderr] 7 | const INSTRUCTIONS: &'static [&'static str] = &[
[INFO] [stderr]   |                               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/bin/assembler.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |     let mut reader = BufReader::new(f);
[INFO] [stderr]    |         ----^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `INSTRUCTIONS`
[INFO] [stderr]   --> src/bin/assembler.rs:7:1
[INFO] [stderr]    |
[INFO] [stderr] 7  | / const INSTRUCTIONS: &'static [&'static str] = &[
[INFO] [stderr] 8  | |     "nop", "jcn", "fim", "src", "fin", "jin", "jun", "jms", "inc", "isz", "add", "sub", "ld",
[INFO] [stderr] 9  | |     "xch", "bbl", "ldm", "wrm", "wmp", "wrr", "wr0", "wr1", "wr2", "wr3", "sbm", "rdm", "rdr",
[INFO] [stderr] 10 | |     "adm", "rd0", "rd1", "rd2", "rd3", "clb", "iac", "cmc", "cma", "ral", "rar", "tcc", "dac",
[INFO] [stderr] 11 | |     "tcs", "stc", "daa", "kbp", "dcl"
[INFO] [stderr] 12 | | ];
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: enum is never used: `Token`
[INFO] [stderr]   --> src/bin/assembler.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | enum Token {
[INFO] [stderr]    | ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/bin/assembler.rs:7:22
[INFO] [stderr]   |
[INFO] [stderr] 7 | const INSTRUCTIONS: &'static [&'static str] = &[
[INFO] [stderr]   |                     -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/bin/assembler.rs:7:32
[INFO] [stderr]   |
[INFO] [stderr] 7 | const INSTRUCTIONS: &'static [&'static str] = &[
[INFO] [stderr]   |                               -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/cpu.rs:388:28
[INFO] [stderr]     |
[INFO] [stderr] 388 |         self.accumulator = self.accumulator >> 1 + self.carry << 3;
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `self.accumulator >> (1 + self.carry)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::precedence)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]   --> src/bin/assembler.rs:24:9
[INFO] [stderr]    |
[INFO] [stderr] 24 |     let mut reader = BufReader::new(f);
[INFO] [stderr]    |         ----^^^^^^
[INFO] [stderr]    |         |
[INFO] [stderr]    |         help: remove this `mut`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: constant item is never used: `INSTRUCTIONS`
[INFO] [stderr]   --> src/bin/assembler.rs:7:1
[INFO] [stderr]    |
[INFO] [stderr] 7  | / const INSTRUCTIONS: &'static [&'static str] = &[
[INFO] [stderr] 8  | |     "nop", "jcn", "fim", "src", "fin", "jin", "jun", "jms", "inc", "isz", "add", "sub", "ld",
[INFO] [stderr] 9  | |     "xch", "bbl", "ldm", "wrm", "wmp", "wrr", "wr0", "wr1", "wr2", "wr3", "sbm", "rdm", "rdr",
[INFO] [stderr] 10 | |     "adm", "rd0", "rd1", "rd2", "rd3", "clb", "iac", "cmc", "cma", "ral", "rar", "tcc", "dac",
[INFO] [stderr] 11 | |     "tcs", "stc", "daa", "kbp", "dcl"
[INFO] [stderr] 12 | | ];
[INFO] [stderr]    | |__^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: enum is never used: `Token`
[INFO] [stderr]   --> src/bin/assembler.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | enum Token {
[INFO] [stderr]    | ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: operator precedence can trip the unwary
[INFO] [stderr]    --> src/cpu.rs:388:28
[INFO] [stderr]     |
[INFO] [stderr] 388 |         self.accumulator = self.accumulator >> 1 + self.carry << 3;
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `self.accumulator >> (1 + self.carry)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::precedence)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence
[INFO] [stderr] 
[INFO] [stderr] error: this boolean expression contains a logic bug
[INFO] [stderr]    --> src/cpu.rs:209:32
[INFO] [stderr]     |
[INFO] [stderr] 209 |         let test_signal_cond = false && (opa & 0b0001 == 0b0001); // TODO implement
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::logic_bug)] on by default
[INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression
[INFO] [stderr]    --> src/cpu.rs:209:41
[INFO] [stderr]     |
[INFO] [stderr] 209 |         let test_signal_cond = false && (opa & 0b0001 == 0b0001); // TODO implement
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:215:49
[INFO] [stderr]     |
[INFO] [stderr] 215 |             self.program_counter = (ph << 8) + ((a2 as u16) << 4) + (a1 as u16);
[INFO] [stderr]     |                                                 ^^^^^^^^^^^ help: try: `u16::from(a2)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:215:69
[INFO] [stderr]     |
[INFO] [stderr] 215 |             self.program_counter = (ph << 8) + ((a2 as u16) << 4) + (a1 as u16);
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^ help: try: `u16::from(a1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:238:45
[INFO] [stderr]     |
[INFO] [stderr] 238 |         self.program_counter = (ph << 8) + ((pm as u16) << 4) + (pl as u16);
[INFO] [stderr]     |                                             ^^^^^^^^^^^ help: try: `u16::from(pm)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:238:65
[INFO] [stderr]     |
[INFO] [stderr] 238 |         self.program_counter = (ph << 8) + ((pm as u16) << 4) + (pl as u16);
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^ help: try: `u16::from(pl)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:243:33
[INFO] [stderr]     |
[INFO] [stderr] 243 |         self.program_counter = ((opa as u16) << 8)
[INFO] [stderr]     |                                 ^^^^^^^^^^^^ help: try: `u16::from(opa)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:244:33
[INFO] [stderr]     |
[INFO] [stderr] 244 |                              + ((a2 as u16) << 4)
[INFO] [stderr]     |                                 ^^^^^^^^^^^ help: try: `u16::from(a2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:245:32
[INFO] [stderr]     |
[INFO] [stderr] 245 |                              + a1 as u16;
[INFO] [stderr]     |                                ^^^^^^^^^ help: try: `u16::from(a1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:251:33
[INFO] [stderr]     |
[INFO] [stderr] 251 |         self.program_counter = ((opa as u16) << 8)
[INFO] [stderr]     |                                 ^^^^^^^^^^^^ help: try: `u16::from(opa)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:252:33
[INFO] [stderr]     |
[INFO] [stderr] 252 |                              + ((a2 as u16) << 4)
[INFO] [stderr]     |                                 ^^^^^^^^^^^ help: try: `u16::from(a2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:253:32
[INFO] [stderr]     |
[INFO] [stderr] 253 |                              + a1 as u16;
[INFO] [stderr]     |                                ^^^^^^^^^ help: try: `u16::from(a1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:262:49
[INFO] [stderr]     |
[INFO] [stderr] 262 |             self.program_counter = (ph << 8) + ((a2 as u16) << 4) + (a1 as u16);
[INFO] [stderr]     |                                                 ^^^^^^^^^^^ help: try: `u16::from(a2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:262:69
[INFO] [stderr]     |
[INFO] [stderr] 262 |             self.program_counter = (ph << 8) + ((a2 as u16) << 4) + (a1 as u16);
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^ help: try: `u16::from(a1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping `self.accumulator` and `self.index_registers[opa as usize]` manually
[INFO] [stderr]    --> src/cpu.rs:294:9
[INFO] [stderr]     |
[INFO] [stderr] 294 | /         let tmp: u8 = self.accumulator;
[INFO] [stderr] 295 | |         self.accumulator = self.index_registers[opa as usize];
[INFO] [stderr] 296 | |         self.index_registers[opa as usize] = tmp;
[INFO] [stderr]     | |________________________________________________^ help: try: `std::mem::swap(&mut self.accumulator, &mut self.index_registers[opa as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]     = note: or maybe you should use `std::mem::replace`?
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `rom`
[INFO] [stderr]   --> src/rom.rs:35:18
[INFO] [stderr]    |
[INFO] [stderr] 35 |         for x in 0..rom.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 35 |         for (x, <item>) in rom.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/rom.rs:35:18
[INFO] [stderr]    |
[INFO] [stderr] 35 |         for x in 0..rom.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^ help: try replacing the loop by: `r.words[..rom.len()].clone_from_slice(&rom[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `box`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: this boolean expression contains a logic bug
[INFO] [stderr]    --> src/cpu.rs:209:32
[INFO] [stderr]     |
[INFO] [stderr] 209 |         let test_signal_cond = false && (opa & 0b0001 == 0b0001); // TODO implement
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: it would look like the following: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::logic_bug)] on by default
[INFO] [stderr] help: this expression can be optimized out by applying boolean operations to the outer expression
[INFO] [stderr]    --> src/cpu.rs:209:41
[INFO] [stderr]     |
[INFO] [stderr] 209 |         let test_signal_cond = false && (opa & 0b0001 == 0b0001); // TODO implement
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#logic_bug
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:215:49
[INFO] [stderr]     |
[INFO] [stderr] 215 |             self.program_counter = (ph << 8) + ((a2 as u16) << 4) + (a1 as u16);
[INFO] [stderr]     |                                                 ^^^^^^^^^^^ help: try: `u16::from(a2)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:215:69
[INFO] [stderr]     |
[INFO] [stderr] 215 |             self.program_counter = (ph << 8) + ((a2 as u16) << 4) + (a1 as u16);
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^ help: try: `u16::from(a1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:238:45
[INFO] [stderr]     |
[INFO] [stderr] 238 |         self.program_counter = (ph << 8) + ((pm as u16) << 4) + (pl as u16);
[INFO] [stderr]     |                                             ^^^^^^^^^^^ help: try: `u16::from(pm)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:238:65
[INFO] [stderr]     |
[INFO] [stderr] 238 |         self.program_counter = (ph << 8) + ((pm as u16) << 4) + (pl as u16);
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^ help: try: `u16::from(pl)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:243:33
[INFO] [stderr]     |
[INFO] [stderr] 243 |         self.program_counter = ((opa as u16) << 8)
[INFO] [stderr]     |                                 ^^^^^^^^^^^^ help: try: `u16::from(opa)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:244:33
[INFO] [stderr]     |
[INFO] [stderr] 244 |                              + ((a2 as u16) << 4)
[INFO] [stderr]     |                                 ^^^^^^^^^^^ help: try: `u16::from(a2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:245:32
[INFO] [stderr]     |
[INFO] [stderr] 245 |                              + a1 as u16;
[INFO] [stderr]     |                                ^^^^^^^^^ help: try: `u16::from(a1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:251:33
[INFO] [stderr]     |
[INFO] [stderr] 251 |         self.program_counter = ((opa as u16) << 8)
[INFO] [stderr]     |                                 ^^^^^^^^^^^^ help: try: `u16::from(opa)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:252:33
[INFO] [stderr]     |
[INFO] [stderr] 252 |                              + ((a2 as u16) << 4)
[INFO] [stderr]     |                                 ^^^^^^^^^^^ help: try: `u16::from(a2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:253:32
[INFO] [stderr]     |
[INFO] [stderr] 253 |                              + a1 as u16;
[INFO] [stderr]     |                                ^^^^^^^^^ help: try: `u16::from(a1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:262:49
[INFO] [stderr]     |
[INFO] [stderr] 262 |             self.program_counter = (ph << 8) + ((a2 as u16) << 4) + (a1 as u16);
[INFO] [stderr]     |                                                 ^^^^^^^^^^^ help: try: `u16::from(a2)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]    --> src/cpu.rs:262:69
[INFO] [stderr]     |
[INFO] [stderr] 262 |             self.program_counter = (ph << 8) + ((a2 as u16) << 4) + (a1 as u16);
[INFO] [stderr]     |                                                                     ^^^^^^^^^^^ help: try: `u16::from(a1)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping `self.accumulator` and `self.index_registers[opa as usize]` manually
[INFO] [stderr]    --> src/cpu.rs:294:9
[INFO] [stderr]     |
[INFO] [stderr] 294 | /         let tmp: u8 = self.accumulator;
[INFO] [stderr] 295 | |         self.accumulator = self.index_registers[opa as usize];
[INFO] [stderr] 296 | |         self.index_registers[opa as usize] = tmp;
[INFO] [stderr]     | |________________________________________________^ help: try: `std::mem::swap(&mut self.accumulator, &mut self.index_registers[opa as usize])`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]     = note: or maybe you should use `std::mem::replace`?
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `x` is used to index `rom`
[INFO] [stderr]   --> src/rom.rs:35:18
[INFO] [stderr]    |
[INFO] [stderr] 35 |         for x in 0..rom.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 35 |         for (x, <item>) in rom.iter().enumerate() {
[INFO] [stderr]    |             ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/rom.rs:35:18
[INFO] [stderr]    |
[INFO] [stderr] 35 |         for x in 0..rom.len() {
[INFO] [stderr]    |                  ^^^^^^^^^^^^ help: try replacing the loop by: `r.words[..rom.len()].clone_from_slice(&rom[..])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `box`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "1611240c416b59a51079ca7741fce5d6622854ad0ef5520371dd19d70566f3a8"`
[INFO] running `"docker" "rm" "-f" "1611240c416b59a51079ca7741fce5d6622854ad0ef5520371dd19d70566f3a8"`
[INFO] [stdout] 1611240c416b59a51079ca7741fce5d6622854ad0ef5520371dd19d70566f3a8