[INFO] updating cached repository mfontanini/rpki-validator
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/mfontanini/rpki-validator
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/mfontanini/rpki-validator" "work/ex/clippy-test-run/sources/stable/gh/mfontanini/rpki-validator"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mfontanini/rpki-validator'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/mfontanini/rpki-validator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfontanini/rpki-validator"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfontanini/rpki-validator'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a133f7dad930290ad51d65dbecf862d7063099f0
[INFO] sha for GitHub repo mfontanini/rpki-validator: a133f7dad930290ad51d65dbecf862d7063099f0
[INFO] validating manifest of mfontanini/rpki-validator on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of mfontanini/rpki-validator on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing mfontanini/rpki-validator
[INFO] finished frobbing mfontanini/rpki-validator
[INFO] frobbed toml for mfontanini/rpki-validator written to work/ex/clippy-test-run/sources/stable/gh/mfontanini/rpki-validator/Cargo.toml
[INFO] started frobbing mfontanini/rpki-validator
[INFO] finished frobbing mfontanini/rpki-validator
[INFO] frobbed toml for mfontanini/rpki-validator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfontanini/rpki-validator/Cargo.toml
[INFO] crate mfontanini/rpki-validator has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting mfontanini/rpki-validator against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mfontanini/rpki-validator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 8441677a6254106d39eea5ec14b7b571debe664ae8449a701e596f599cc6dd9d
[INFO] running `"docker" "start" "-a" "8441677a6254106d39eea5ec14b7b571debe664ae8449a701e596f599cc6dd9d"`
[INFO] [stderr]    Compiling protobuf v2.0.5
[INFO] [stderr]    Compiling prometheus v0.4.2
[INFO] [stderr]     Checking xml-rs v0.8.0
[INFO] [stderr]     Checking spin v0.4.9
[INFO] [stderr]     Checking bencher v0.1.5
[INFO] [stderr]    Compiling actix-web v0.7.7
[INFO] [stderr]     Checking mio v0.6.16
[INFO] [stderr]     Checking simple_logger v0.5.0
[INFO] [stderr]     Checking tokio-io v0.1.8
[INFO] [stderr]     Checking http v0.1.13
[INFO] [stderr]     Checking toml v0.4.8
[INFO] [stderr]    Compiling syn v0.15.3
[INFO] [stderr]     Checking tokio-threadpool v0.1.6
[INFO] [stderr]     Checking bcder v0.1.0
[INFO] [stderr]     Checking tokio-codec v0.1.0
[INFO] [stderr]     Checking tokio-reactor v0.1.5
[INFO] [stderr]     Checking mio-uds v0.6.7
[INFO] [stderr]     Checking tokio-fs v0.1.3
[INFO] [stderr]     Checking tokio-uds v0.2.1
[INFO] [stderr]     Checking tokio-udp v0.1.2
[INFO] [stderr]     Checking tokio-tcp v0.1.1
[INFO] [stderr]     Checking tokio-signal v0.2.5
[INFO] [stderr]     Checking rpki v0.1.0
[INFO] [stderr]     Checking trust-dns-proto v0.4.0
[INFO] [stderr]     Checking tokio v0.1.8
[INFO] [stderr]    Compiling serde_derive v1.0.79
[INFO] [stderr]     Checking h2 v0.1.12
[INFO] [stderr]     Checking trust-dns-resolver v0.9.1
[INFO] [stderr]     Checking actix v0.7.4
[INFO] [stderr]     Checking ipnetwork v0.13.1
[INFO] [stderr]     Checking rpki-validator v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/processor.rs:210:17
[INFO] [stderr]     |
[INFO] [stderr] 210 |                 return Ok(Arc::new(AlwaysProcess{}));
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Arc::new(AlwaysProcess{}))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/processor.rs:217:17
[INFO] [stderr]     |
[INFO] [stderr] 217 |                 return Ok(Arc::new(output));
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Arc::new(output))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/validation.rs:35:18
[INFO] [stderr]    |
[INFO] [stderr] 35 |               else {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 36 | |                 if !has_valid_origin {
[INFO] [stderr] 37 | |                     invalid_origin.push(record);
[INFO] [stderr] 38 | |                 }
[INFO] [stderr] ...  |
[INFO] [stderr] 41 | |                 }
[INFO] [stderr] 42 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 35 |             else if !has_valid_origin {
[INFO] [stderr] 36 |     invalid_origin.push(record);
[INFO] [stderr] 37 | }
[INFO] [stderr] 38 | else if !has_valid_length {
[INFO] [stderr] 39 |     invalid_length.push(record);
[INFO] [stderr] 40 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/processor.rs:210:17
[INFO] [stderr]     |
[INFO] [stderr] 210 |                 return Ok(Arc::new(AlwaysProcess{}));
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Arc::new(AlwaysProcess{}))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/processor.rs:217:17
[INFO] [stderr]     |
[INFO] [stderr] 217 |                 return Ok(Arc::new(output));
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Arc::new(output))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/validation.rs:35:18
[INFO] [stderr]    |
[INFO] [stderr] 35 |               else {
[INFO] [stderr]    |  __________________^
[INFO] [stderr] 36 | |                 if !has_valid_origin {
[INFO] [stderr] 37 | |                     invalid_origin.push(record);
[INFO] [stderr] 38 | |                 }
[INFO] [stderr] ...  |
[INFO] [stderr] 41 | |                 }
[INFO] [stderr] 42 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 35 |             else if !has_valid_origin {
[INFO] [stderr] 36 |     invalid_origin.push(record);
[INFO] [stderr] 37 | }
[INFO] [stderr] 38 | else if !has_valid_length {
[INFO] [stderr] 39 |     invalid_length.push(record);
[INFO] [stderr] 40 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:63:28
[INFO] [stderr]    |
[INFO] [stderr] 63 |     env::var("CACHE_PATH").unwrap_or("/tmp/rpki-validator-cache".to_string())
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "/tmp/rpki-validator-cache".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:83:26
[INFO] [stderr]    |
[INFO] [stderr] 83 |     env::var("TAL_PATH").unwrap_or("tal".to_string())
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "tal".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:115:48
[INFO] [stderr]     |
[INFO] [stderr] 115 |             endpoint: env::var("API_ENDPOINT").unwrap_or("127.0.0.1:8080".to_string())
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "127.0.0.1:8080".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/executor.rs:158:41
[INFO] [stderr]     |
[INFO] [stderr] 158 |                 Some(scheduled_work) => scheduled_work.execution_time() <= &Instant::now(),
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------
[INFO] [stderr]     |                                                                            |
[INFO] [stderr]     |                                                                            help: use the right value directly: `Instant::now()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `metrics::Metrics`
[INFO] [stderr]   --> src/metrics.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     pub fn new() -> Self {
[INFO] [stderr] 14 | |         let update_time_buckets = vec![
[INFO] [stderr] 15 | |             1.0, 2.0, 3.0, 5.0, 7.5, 10.0, 15.0, 20.0, 40.0, 60.0, 80.0, 120.0, 160.0, 200.0
[INFO] [stderr] 16 | |         ];
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |         }
[INFO] [stderr] 47 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | impl Default for metrics::Metrics {
[INFO] [stderr] 13 |     fn default() -> Self {
[INFO] [stderr] 14 |         Self::new()
[INFO] [stderr] 15 |     }
[INFO] [stderr] 16 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/metrics.rs:63:50
[INFO] [stderr]    |
[INFO] [stderr] 63 |         let elapsed = elapsed.as_secs() as f64 + elapsed.subsec_millis() as f64 * 0.001;
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_millis())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/processor.rs:177:9
[INFO] [stderr]     |
[INFO] [stderr] 177 | /         match self.policy_type {
[INFO] [stderr] 178 | |             ProcessingPolicyType::ProcessExisting => {
[INFO] [stderr] 179 | |                 return Ok(Arc::new(AlwaysProcess{}))
[INFO] [stderr] 180 | |             },
[INFO] [stderr] 181 | |             _ => (),
[INFO] [stderr] 182 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 177 |         if let ProcessingPolicyType::ProcessExisting = self.policy_type {
[INFO] [stderr] 178 |     return Ok(Arc::new(AlwaysProcess{}))
[INFO] [stderr] 179 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/processor.rs:506:20
[INFO] [stderr]     |
[INFO] [stderr] 506 |               if let Err(_) = self.check_crl(cert.as_ref(), issuer_cert, store) {
[INFO] [stderr]     |  _____________-      ^^^^^^
[INFO] [stderr] 507 | |                 info!("Certificate for URI {:?} has been revoked", uri);
[INFO] [stderr] 508 | |                 continue
[INFO] [stderr] 509 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if self.check_crl(cert.as_ref(), issuer_cert, store).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/processor.rs:547:20
[INFO] [stderr]     |
[INFO] [stderr] 547 |               if let Err(_) = crl.validate(issuer_cert) {
[INFO] [stderr]     |  _____________-      ^^^^^^
[INFO] [stderr] 548 | |                 continue
[INFO] [stderr] 549 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if crl.validate(issuer_cert).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]    --> src/processor.rs:551:41
[INFO] [stderr]     |
[INFO] [stderr] 551 |             let revoked = crl.contains(&cert.as_ref().serial_number());
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^ help: try this: `cert`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/processor.rs:593:20
[INFO] [stderr]     |
[INFO] [stderr] 593 |               if let Err(_) = self.check_crl(cert.as_ref(), issuer_cert, store) {
[INFO] [stderr]     |  _____________-      ^^^^^^
[INFO] [stderr] 594 | |                 info!("Certificate {:?} has been revoked", self.get_path(uri));
[INFO] [stderr] 595 | |                 return Ok(None)
[INFO] [stderr] 596 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if self.check_crl(cert.as_ref(), issuer_cert, store).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/processor.rs:604:20
[INFO] [stderr]     |
[INFO] [stderr] 604 |               if let Err(_) = hash.verify(&bytes) {
[INFO] [stderr]     |  _____________-      ^^^^^^
[INFO] [stderr] 605 | |                 return Ok(None)
[INFO] [stderr] 606 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if hash.verify(&bytes).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `storage::RecordStorage`
[INFO] [stderr]    --> src/storage.rs:95:5
[INFO] [stderr]     |
[INFO] [stderr] 95  | /     pub fn new() -> Self {
[INFO] [stderr] 96  | |         RecordStorage {
[INFO] [stderr] 97  | |             prefix_records: HashMap::new(),
[INFO] [stderr] 98  | |             known_paths: HashSet::new(),
[INFO] [stderr] 99  | |             trust_anchor_total_records: HashMap::new(),
[INFO] [stderr] 100 | |         }
[INFO] [stderr] 101 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 83  | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Negation by multiplying with -1
[INFO] [stderr]    --> src/storage.rs:153:55
[INFO] [stderr]     |
[INFO] [stderr] 153 |             self.set_total_records_diff(trust_anchor, removed * -1);
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::neg_multiply)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u128 may become silently lossy if types change
[INFO] [stderr]    --> src/storage.rs:159:31
[INFO] [stderr]     |
[INFO] [stderr] 159 |             IpAddr::V4(a) => (u32::from(a) as u128, 32, Self::MIN_IPV4_PREFIX_LENGTH),
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(u32::from(a))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/storage.rs:163:42
[INFO] [stderr]     |
[INFO] [stderr] 163 |         let mut mask : u128 = (2u128.pow(mask_length as u32) - 1) << (max_mask - mask_length);
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(mask_length)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/storage.rs:184:13
[INFO] [stderr]     |
[INFO] [stderr] 184 |             mask = mask << 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `mask <<= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:63:28
[INFO] [stderr]    |
[INFO] [stderr] 63 |     env::var("CACHE_PATH").unwrap_or("/tmp/rpki-validator-cache".to_string())
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "/tmp/rpki-validator-cache".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/config.rs:83:26
[INFO] [stderr]    |
[INFO] [stderr] 83 |     env::var("TAL_PATH").unwrap_or("tal".to_string())
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "tal".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/config.rs:115:48
[INFO] [stderr]     |
[INFO] [stderr] 115 |             endpoint: env::var("API_ENDPOINT").unwrap_or("127.0.0.1:8080".to_string())
[INFO] [stderr]     |                                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "127.0.0.1:8080".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/executor.rs:158:41
[INFO] [stderr]     |
[INFO] [stderr] 158 |                 Some(scheduled_work) => scheduled_work.execution_time() <= &Instant::now(),
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^---------------
[INFO] [stderr]     |                                                                            |
[INFO] [stderr]     |                                                                            help: use the right value directly: `Instant::now()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/executor.rs:222:27
[INFO] [stderr]     |
[INFO] [stderr] 222 |             instants.push(instant.clone());
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `instant`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `metrics::Metrics`
[INFO] [stderr]   --> src/metrics.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 | /     pub fn new() -> Self {
[INFO] [stderr] 14 | |         let update_time_buckets = vec![
[INFO] [stderr] 15 | |             1.0, 2.0, 3.0, 5.0, 7.5, 10.0, 15.0, 20.0, 40.0, 60.0, 80.0, 120.0, 160.0, 200.0
[INFO] [stderr] 16 | |         ];
[INFO] [stderr] ...  |
[INFO] [stderr] 46 | |         }
[INFO] [stderr] 47 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 12 | impl Default for metrics::Metrics {
[INFO] [stderr] 13 |     fn default() -> Self {
[INFO] [stderr] 14 |         Self::new()
[INFO] [stderr] 15 |     }
[INFO] [stderr] 16 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/metrics.rs:63:50
[INFO] [stderr]    |
[INFO] [stderr] 63 |         let elapsed = elapsed.as_secs() as f64 + elapsed.subsec_millis() as f64 * 0.001;
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_millis())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/processor.rs:177:9
[INFO] [stderr]     |
[INFO] [stderr] 177 | /         match self.policy_type {
[INFO] [stderr] 178 | |             ProcessingPolicyType::ProcessExisting => {
[INFO] [stderr] 179 | |                 return Ok(Arc::new(AlwaysProcess{}))
[INFO] [stderr] 180 | |             },
[INFO] [stderr] 181 | |             _ => (),
[INFO] [stderr] 182 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 177 |         if let ProcessingPolicyType::ProcessExisting = self.policy_type {
[INFO] [stderr] 178 |     return Ok(Arc::new(AlwaysProcess{}))
[INFO] [stderr] 179 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/processor.rs:506:20
[INFO] [stderr]     |
[INFO] [stderr] 506 |               if let Err(_) = self.check_crl(cert.as_ref(), issuer_cert, store) {
[INFO] [stderr]     |  _____________-      ^^^^^^
[INFO] [stderr] 507 | |                 info!("Certificate for URI {:?} has been revoked", uri);
[INFO] [stderr] 508 | |                 continue
[INFO] [stderr] 509 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if self.check_crl(cert.as_ref(), issuer_cert, store).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/processor.rs:547:20
[INFO] [stderr]     |
[INFO] [stderr] 547 |               if let Err(_) = crl.validate(issuer_cert) {
[INFO] [stderr]     |  _____________-      ^^^^^^
[INFO] [stderr] 548 | |                 continue
[INFO] [stderr] 549 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if crl.validate(issuer_cert).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: this call to `as_ref` does nothing
[INFO] [stderr]    --> src/processor.rs:551:41
[INFO] [stderr]     |
[INFO] [stderr] 551 |             let revoked = crl.contains(&cert.as_ref().serial_number());
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^ help: try this: `cert`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_asref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/processor.rs:593:20
[INFO] [stderr]     |
[INFO] [stderr] 593 |               if let Err(_) = self.check_crl(cert.as_ref(), issuer_cert, store) {
[INFO] [stderr]     |  _____________-      ^^^^^^
[INFO] [stderr] 594 | |                 info!("Certificate {:?} has been revoked", self.get_path(uri));
[INFO] [stderr] 595 | |                 return Ok(None)
[INFO] [stderr] 596 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if self.check_crl(cert.as_ref(), issuer_cert, store).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_err()`
[INFO] [stderr]    --> src/processor.rs:604:20
[INFO] [stderr]     |
[INFO] [stderr] 604 |               if let Err(_) = hash.verify(&bytes) {
[INFO] [stderr]     |  _____________-      ^^^^^^
[INFO] [stderr] 605 | |                 return Ok(None)
[INFO] [stderr] 606 | |             }
[INFO] [stderr]     | |_____________- help: try this: `if hash.verify(&bytes).is_err()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `storage::RecordStorage`
[INFO] [stderr]    --> src/storage.rs:95:5
[INFO] [stderr]     |
[INFO] [stderr] 95  | /     pub fn new() -> Self {
[INFO] [stderr] 96  | |         RecordStorage {
[INFO] [stderr] 97  | |             prefix_records: HashMap::new(),
[INFO] [stderr] 98  | |             known_paths: HashSet::new(),
[INFO] [stderr] 99  | |             trust_anchor_total_records: HashMap::new(),
[INFO] [stderr] 100 | |         }
[INFO] [stderr] 101 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 83  | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Negation by multiplying with -1
[INFO] [stderr]    --> src/storage.rs:153:55
[INFO] [stderr]     |
[INFO] [stderr] 153 |             self.set_total_records_diff(trust_anchor, removed * -1);
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::neg_multiply)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#neg_multiply
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u128 may become silently lossy if types change
[INFO] [stderr]    --> src/storage.rs:159:31
[INFO] [stderr]     |
[INFO] [stderr] 159 |             IpAddr::V4(a) => (u32::from(a) as u128, 32, Self::MIN_IPV4_PREFIX_LENGTH),
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(u32::from(a))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/storage.rs:163:42
[INFO] [stderr]     |
[INFO] [stderr] 163 |         let mut mask : u128 = (2u128.pow(mask_length as u32) - 1) << (max_mask - mask_length);
[INFO] [stderr]     |                                          ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(mask_length)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/storage.rs:184:13
[INFO] [stderr]     |
[INFO] [stderr] 184 |             mask = mask << 1;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `mask <<= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:389:5
[INFO] [stderr]     |
[INFO] [stderr] 389 |     return true;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:389:5
[INFO] [stderr]     |
[INFO] [stderr] 389 |     return true;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `true`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:373:33
[INFO] [stderr]     |
[INFO] [stderr] 373 |             Duration::from_secs(config.rsync.interval as u64 * 60),
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.rsync.interval)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:373:33
[INFO] [stderr]     |
[INFO] [stderr] 373 |             Duration::from_secs(config.rsync.interval as u64 * 60),
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(config.rsync.interval)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 15s
[INFO] running `"docker" "inspect" "8441677a6254106d39eea5ec14b7b571debe664ae8449a701e596f599cc6dd9d"`
[INFO] running `"docker" "rm" "-f" "8441677a6254106d39eea5ec14b7b571debe664ae8449a701e596f599cc6dd9d"`
[INFO] [stdout] 8441677a6254106d39eea5ec14b7b571debe664ae8449a701e596f599cc6dd9d