[INFO] updating cached repository mfenniak/cloud-persistent-storage [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mfenniak/cloud-persistent-storage [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mfenniak/cloud-persistent-storage" "work/ex/clippy-test-run/sources/stable/gh/mfenniak/cloud-persistent-storage"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mfenniak/cloud-persistent-storage'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mfenniak/cloud-persistent-storage" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfenniak/cloud-persistent-storage"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfenniak/cloud-persistent-storage'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9c577e64c10bbc1f825ef2a84ff2aa1205283258 [INFO] sha for GitHub repo mfenniak/cloud-persistent-storage: 9c577e64c10bbc1f825ef2a84ff2aa1205283258 [INFO] validating manifest of mfenniak/cloud-persistent-storage on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mfenniak/cloud-persistent-storage on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mfenniak/cloud-persistent-storage [INFO] finished frobbing mfenniak/cloud-persistent-storage [INFO] frobbed toml for mfenniak/cloud-persistent-storage written to work/ex/clippy-test-run/sources/stable/gh/mfenniak/cloud-persistent-storage/Cargo.toml [INFO] started frobbing mfenniak/cloud-persistent-storage [INFO] finished frobbing mfenniak/cloud-persistent-storage [INFO] frobbed toml for mfenniak/cloud-persistent-storage written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfenniak/cloud-persistent-storage/Cargo.toml [INFO] crate mfenniak/cloud-persistent-storage has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mfenniak/cloud-persistent-storage against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mfenniak/cloud-persistent-storage:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 930ad18f0955525e268bd224091d675430d4c49d25716a062c2b7031ca847007 [INFO] running `"docker" "start" "-a" "930ad18f0955525e268bd224091d675430d4c49d25716a062c2b7031ca847007"` [INFO] [stderr] Compiling openssl v0.9.9 [INFO] [stderr] Compiling lazy_static v0.2.4 [INFO] [stderr] Compiling httparse v1.2.1 [INFO] [stderr] Compiling ring v0.6.3 [INFO] [stderr] Checking serde v0.9.11 [INFO] [stderr] Checking md5 v0.3.3 [INFO] [stderr] Compiling openssl-sys v0.9.9 [INFO] [stderr] Checking serde_json v0.8.6 [INFO] [stderr] Compiling idna v0.1.0 [INFO] [stderr] Compiling serde_codegen_internals v0.14.1 [INFO] [stderr] Checking num v0.1.37 [INFO] [stderr] Compiling Inflector v0.7.0 [INFO] [stderr] Checking serde_urlencoded v0.3.0 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Compiling serde_derive v0.9.11 [INFO] [stderr] Compiling url v1.4.0 [INFO] [stderr] Compiling hyper v0.10.5 [INFO] [stderr] Checking native-tls v0.1.1 [INFO] [stderr] Checking reqwest v0.3.0 [INFO] [stderr] Checking hyper-native-tls v0.2.2 [INFO] [stderr] Checking serde_json v0.9.9 [INFO] [stderr] Checking serde_yaml v0.6.2 [INFO] [stderr] Checking rusoto_credential v0.5.0 [INFO] [stderr] Compiling rusoto_codegen v0.7.1 [INFO] [stderr] Compiling rusoto v0.23.1 [INFO] [stderr] Checking aws_instance_metadata v0.1.1 [INFO] [stderr] Checking cloud-persistent-storage v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ebs.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:262:55 [INFO] [stderr] | [INFO] [stderr] 262 | ebs_tags: ebs_tags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ebs_tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:281:55 [INFO] [stderr] | [INFO] [stderr] 281 | ebs_tags: ebs_tags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ebs_tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ebs.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:262:55 [INFO] [stderr] | [INFO] [stderr] 262 | ebs_tags: ebs_tags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ebs_tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:281:55 [INFO] [stderr] | [INFO] [stderr] 281 | ebs_tags: ebs_tags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `ebs_tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:293:40 [INFO] [stderr] | [INFO] [stderr] 293 | const EXAMPLE_MINIMAL_EBS_CONFIG: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:300:37 [INFO] [stderr] | [INFO] [stderr] 300 | const EXAMPLE_FULL_EBS_CONFIG: &'static str = r#" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / fn main() { [INFO] [stderr] 26 | | env_logger::init().unwrap(); [INFO] [stderr] 27 | | [INFO] [stderr] 28 | | let args: Vec = env::args().collect(); [INFO] [stderr] ... | [INFO] [stderr] 116 | | } [INFO] [stderr] 117 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/config.rs:349:25 [INFO] [stderr] | [INFO] [stderr] 349 | assert!(ebs_config.ebs_tags.get("tag-a").unwrap() == "value-a"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&ebs_config.ebs_tags["tag-a"]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / fn main() { [INFO] [stderr] 26 | | env_logger::init().unwrap(); [INFO] [stderr] 27 | | [INFO] [stderr] 28 | | let args: Vec = env::args().collect(); [INFO] [stderr] ... | [INFO] [stderr] 116 | | } [INFO] [stderr] 117 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 20s [INFO] running `"docker" "inspect" "930ad18f0955525e268bd224091d675430d4c49d25716a062c2b7031ca847007"` [INFO] running `"docker" "rm" "-f" "930ad18f0955525e268bd224091d675430d4c49d25716a062c2b7031ca847007"` [INFO] [stdout] 930ad18f0955525e268bd224091d675430d4c49d25716a062c2b7031ca847007