[INFO] updating cached repository mfeckie/alpha_sparkle [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mfeckie/alpha_sparkle [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mfeckie/alpha_sparkle" "work/ex/clippy-test-run/sources/stable/gh/mfeckie/alpha_sparkle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mfeckie/alpha_sparkle'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mfeckie/alpha_sparkle" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfeckie/alpha_sparkle"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfeckie/alpha_sparkle'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 575f2d3305617462ddf413996f670974fbf9f752 [INFO] sha for GitHub repo mfeckie/alpha_sparkle: 575f2d3305617462ddf413996f670974fbf9f752 [INFO] validating manifest of mfeckie/alpha_sparkle on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mfeckie/alpha_sparkle on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mfeckie/alpha_sparkle [INFO] finished frobbing mfeckie/alpha_sparkle [INFO] frobbed toml for mfeckie/alpha_sparkle written to work/ex/clippy-test-run/sources/stable/gh/mfeckie/alpha_sparkle/Cargo.toml [INFO] started frobbing mfeckie/alpha_sparkle [INFO] finished frobbing mfeckie/alpha_sparkle [INFO] frobbed toml for mfeckie/alpha_sparkle written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfeckie/alpha_sparkle/Cargo.toml [INFO] crate mfeckie/alpha_sparkle has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mfeckie/alpha_sparkle against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mfeckie/alpha_sparkle:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c74afe633327b7b233a02ac0121e0be21879123cad8a1eb0f591c5468f0171e [INFO] running `"docker" "start" "-a" "9c74afe633327b7b233a02ac0121e0be21879123cad8a1eb0f591c5468f0171e"` [INFO] [stderr] Checking alpha_sparkle v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | if input == "A".to_owned() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `"A"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `ALPHABET` [INFO] [stderr] --> src/main.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | for i in 1..iterations { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for (i, ) in ALPHABET.iter().enumerate().take(iterations).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/main.rs:16:17 [INFO] [stderr] | [INFO] [stderr] 16 | if input == "A".to_owned() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `"A"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `ALPHABET` [INFO] [stderr] --> src/main.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | for i in 1..iterations { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for (i, ) in ALPHABET.iter().enumerate().take(iterations).skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.82s [INFO] running `"docker" "inspect" "9c74afe633327b7b233a02ac0121e0be21879123cad8a1eb0f591c5468f0171e"` [INFO] running `"docker" "rm" "-f" "9c74afe633327b7b233a02ac0121e0be21879123cad8a1eb0f591c5468f0171e"` [INFO] [stdout] 9c74afe633327b7b233a02ac0121e0be21879123cad8a1eb0f591c5468f0171e