[INFO] updating cached repository mfalda/INI_validator [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mfalda/INI_validator [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mfalda/INI_validator" "work/ex/clippy-test-run/sources/stable/gh/mfalda/INI_validator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mfalda/INI_validator'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mfalda/INI_validator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfalda/INI_validator"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfalda/INI_validator'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b2910bb9c4c1922bf4a9dae5eb8a8af274ddd766 [INFO] sha for GitHub repo mfalda/INI_validator: b2910bb9c4c1922bf4a9dae5eb8a8af274ddd766 [INFO] validating manifest of mfalda/INI_validator on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mfalda/INI_validator on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mfalda/INI_validator [INFO] finished frobbing mfalda/INI_validator [INFO] frobbed toml for mfalda/INI_validator written to work/ex/clippy-test-run/sources/stable/gh/mfalda/INI_validator/Cargo.toml [INFO] started frobbing mfalda/INI_validator [INFO] finished frobbing mfalda/INI_validator [INFO] frobbed toml for mfalda/INI_validator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfalda/INI_validator/Cargo.toml [INFO] crate mfalda/INI_validator has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mfalda/INI_validator against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mfalda/INI_validator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bbc2eeb5cbe542f83f8cc8ffca5e7258c7061021e807636a6387bed88860435c [INFO] running `"docker" "start" "-a" "bbc2eeb5cbe542f83f8cc8ffca5e7258c7061021e807636a6387bed88860435c"` [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking INI_validator v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/main.rs:77:20 [INFO] [stderr] | [INFO] [stderr] 77 | if entries.len() <= level - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 77 | if entries.len() < level { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:329:21 [INFO] [stderr] | [INFO] [stderr] 329 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/main.rs:77:20 [INFO] [stderr] | [INFO] [stderr] 77 | if entries.len() <= level - 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 77 | if entries.len() < level { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:329:21 [INFO] [stderr] | [INFO] [stderr] 329 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: crate `INI_validator` should have a snake case name such as `ini_validator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / fn read_ini<'a>(inp: &str, vrb: bool, sections: &'a mut Vec) -> (Vec>, &'a mut Vec) [INFO] [stderr] 42 | | { [INFO] [stderr] 43 | | let mut entries = Vec::new(); [INFO] [stderr] 44 | | let f = File::open(inp).expect("Cannot open file!"); [INFO] [stderr] ... | [INFO] [stderr] 132 | | (entries, sections) [INFO] [stderr] 133 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: crate `INI_validator` should have a snake case name such as `ini_validator` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/main.rs:41:1 [INFO] [stderr] | [INFO] [stderr] 41 | / fn read_ini<'a>(inp: &str, vrb: bool, sections: &'a mut Vec) -> (Vec>, &'a mut Vec) [INFO] [stderr] 42 | | { [INFO] [stderr] 43 | | let mut entries = Vec::new(); [INFO] [stderr] 44 | | let f = File::open(inp).expect("Cannot open file!"); [INFO] [stderr] ... | [INFO] [stderr] 132 | | (entries, sections) [INFO] [stderr] 133 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> src/main.rs:71:34 [INFO] [stderr] | [INFO] [stderr] 71 | let num_points = sec.to_string().into_bytes().iter() [INFO] [stderr] | __________________________________^ [INFO] [stderr] 72 | | .filter(|&c| *c == b'.').count(); [INFO] [stderr] | |____________________________________________________^ help: Consider using the bytecount crate: `bytecount::count(sec.to_string().into_bytes(), b'.')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] warning: You appear to be counting bytes the naive way [INFO] [stderr] --> src/main.rs:71:34 [INFO] [stderr] | [INFO] [stderr] 71 | let num_points = sec.to_string().into_bytes().iter() [INFO] [stderr] | __________________________________^ [INFO] [stderr] 72 | | .filter(|&c| *c == b'.').count(); [INFO] [stderr] | |____________________________________________________^ help: Consider using the bytecount crate: `bytecount::count(sec.to_string().into_bytes(), b'.')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::naive_bytecount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#naive_bytecount [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / for (num, e) in list[1..list.len() - 1].split(',').enumerate() { [INFO] [stderr] 145 | | match e.parse::() { [INFO] [stderr] 146 | | Ok(_) => [INFO] [stderr] 147 | | return Ok(true), [INFO] [stderr] ... | [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | / for (num, e) in list[1..list.len() - 1].split(',').enumerate() { [INFO] [stderr] 156 | | match e.parse::() { [INFO] [stderr] 157 | | Ok(_) => [INFO] [stderr] 158 | | return Ok(true), [INFO] [stderr] ... | [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | / for (num, e) in list[1..list.len() - 1].split(',').enumerate() { [INFO] [stderr] 145 | | match e.parse::() { [INFO] [stderr] 146 | | Ok(_) => [INFO] [stderr] 147 | | return Ok(true), [INFO] [stderr] ... | [INFO] [stderr] 151 | | } [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | / for (num, e) in list[1..list.len() - 1].split(',').enumerate() { [INFO] [stderr] 156 | | match e.parse::() { [INFO] [stderr] 157 | | Ok(_) => [INFO] [stderr] 158 | | return Ok(true), [INFO] [stderr] ... | [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:264:35 [INFO] [stderr] | [INFO] [stderr] 264 | for (num, entries) in entries.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:319:36 [INFO] [stderr] | [INFO] [stderr] 319 | for (num, entries1) in entries.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:264:35 [INFO] [stderr] | [INFO] [stderr] 264 | for (num, entries) in entries.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/main.rs:319:36 [INFO] [stderr] | [INFO] [stderr] 319 | for (num, entries1) in entries.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: Could not compile `INI_validator`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `INI_validator`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "bbc2eeb5cbe542f83f8cc8ffca5e7258c7061021e807636a6387bed88860435c"` [INFO] running `"docker" "rm" "-f" "bbc2eeb5cbe542f83f8cc8ffca5e7258c7061021e807636a6387bed88860435c"` [INFO] [stdout] bbc2eeb5cbe542f83f8cc8ffca5e7258c7061021e807636a6387bed88860435c