[INFO] updating cached repository mfaerevaag/otter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mfaerevaag/otter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mfaerevaag/otter" "work/ex/clippy-test-run/sources/stable/gh/mfaerevaag/otter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mfaerevaag/otter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mfaerevaag/otter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfaerevaag/otter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfaerevaag/otter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6737996d1a9cc876ba572a4cab3c8e28b50b6a40 [INFO] sha for GitHub repo mfaerevaag/otter: 6737996d1a9cc876ba572a4cab3c8e28b50b6a40 [INFO] validating manifest of mfaerevaag/otter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mfaerevaag/otter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mfaerevaag/otter [INFO] finished frobbing mfaerevaag/otter [INFO] frobbed toml for mfaerevaag/otter written to work/ex/clippy-test-run/sources/stable/gh/mfaerevaag/otter/Cargo.toml [INFO] started frobbing mfaerevaag/otter [INFO] finished frobbing mfaerevaag/otter [INFO] frobbed toml for mfaerevaag/otter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mfaerevaag/otter/Cargo.toml [INFO] crate mfaerevaag/otter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mfaerevaag/otter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mfaerevaag/otter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c30b17409877cec44dbc8756c6ffe62c87381ff1ef03fe95493c7adc03478cf0 [INFO] running `"docker" "start" "-a" "c30b17409877cec44dbc8756c6ffe62c87381ff1ef03fe95493c7adc03478cf0"` [INFO] [stderr] Checking matches v0.1.3 [INFO] [stderr] Compiling openssl v0.9.1 [INFO] [stderr] Checking httparse v1.1.2 [INFO] [stderr] Checking net2 v0.2.26 [INFO] [stderr] Compiling openssl-sys v0.9.1 [INFO] [stderr] Checking unicode-bidi v0.2.3 [INFO] [stderr] Checking miow v0.1.3 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking idna v0.1.0 [INFO] [stderr] Checking url v1.2.3 [INFO] [stderr] Checking ws v0.5.3 [INFO] [stderr] Checking secret-chat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/socket.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | nick: nick, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `nick` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/socket.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | out: out, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/socket.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | engine: engine, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `engine` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/socket.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | out: out, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/socket.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | out: out, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/socket.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | nick: nick, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `nick` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/socket.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | out: out, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/server/socket.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | engine: engine, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `engine` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server/state.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | rooms: Arc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server/state.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | sockets.insert(String::from(nick.clone()), Arc::new(Mutex::new(sock.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `nick.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server/command.rs:16:40 [INFO] [stderr] | [INFO] [stderr] 16 | let tok: Vec<&str> = msg.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/server/state.rs:13:12 [INFO] [stderr] | [INFO] [stderr] 13 | rooms: Arc>>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/server/state.rs:34:28 [INFO] [stderr] | [INFO] [stderr] 34 | sockets.insert(String::from(nick.clone()), Arc::new(Mutex::new(sock.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `nick.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server/command.rs:16:40 [INFO] [stderr] | [INFO] [stderr] 16 | let tok: Vec<&str> = msg.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/client/socket.rs:42:52 [INFO] [stderr] | [INFO] [stderr] 42 | let tok: Vec<&str> = trimmed.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/client/socket.rs:78:40 [INFO] [stderr] | [INFO] [stderr] 78 | let tok: Vec<&str> = msg.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/client/socket.rs:42:52 [INFO] [stderr] | [INFO] [stderr] 42 | let tok: Vec<&str> = trimmed.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/client/socket.rs:78:40 [INFO] [stderr] | [INFO] [stderr] 78 | let tok: Vec<&str> = msg.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.30s [INFO] running `"docker" "inspect" "c30b17409877cec44dbc8756c6ffe62c87381ff1ef03fe95493c7adc03478cf0"` [INFO] running `"docker" "rm" "-f" "c30b17409877cec44dbc8756c6ffe62c87381ff1ef03fe95493c7adc03478cf0"` [INFO] [stdout] c30b17409877cec44dbc8756c6ffe62c87381ff1ef03fe95493c7adc03478cf0