[INFO] updating cached repository methodin/txtof [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/methodin/txtof [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/methodin/txtof" "work/ex/clippy-test-run/sources/stable/gh/methodin/txtof"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/methodin/txtof'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/methodin/txtof" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/methodin/txtof"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/methodin/txtof'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 59d0fce3ad85e442e167633cff9778cbcdef438a [INFO] sha for GitHub repo methodin/txtof: 59d0fce3ad85e442e167633cff9778cbcdef438a [INFO] validating manifest of methodin/txtof on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of methodin/txtof on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing methodin/txtof [INFO] finished frobbing methodin/txtof [INFO] frobbed toml for methodin/txtof written to work/ex/clippy-test-run/sources/stable/gh/methodin/txtof/Cargo.toml [INFO] started frobbing methodin/txtof [INFO] finished frobbing methodin/txtof [INFO] frobbed toml for methodin/txtof written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/methodin/txtof/Cargo.toml [INFO] crate methodin/txtof has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting methodin/txtof against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/methodin/txtof:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 19f1b6a9ec15cdc4f5571c35328f82afb73ffeb280589d349a5168c2f6205b96 [INFO] running `"docker" "start" "-a" "19f1b6a9ec15cdc4f5571c35328f82afb73ffeb280589d349a5168c2f6205b96"` [INFO] [stderr] Checking libc v0.2.26 [INFO] [stderr] Checking num-traits v0.1.39 [INFO] [stderr] Checking pest v0.3.3 [INFO] [stderr] Checking quick-error v1.2.0 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking handlebars v0.27.0 [INFO] [stderr] Checking txtof v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | let mut page: Page = Page { name: name, rows: Vec::new() }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:117:37 [INFO] [stderr] | [INFO] [stderr] 117 | let mut page: Page = Page { name: name, rows: Vec::new() }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | until: until, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `until` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | work_type: work_type [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `work_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:276:21 [INFO] [stderr] | [INFO] [stderr] 276 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | placeholder: placeholder [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `placeholder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | until: until, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `until` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | work_type: work_type [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `work_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:276:21 [INFO] [stderr] | [INFO] [stderr] 276 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:277:21 [INFO] [stderr] | [INFO] [stderr] 277 | placeholder: placeholder [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `placeholder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | let ref mut buffer = self.buffers[len-1]; [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------- help: try: `let buffer = &mut self.buffers[len-1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | for ref buf in self.buffers.iter() { [INFO] [stderr] | ^^^^^^^ ------------------- help: try: `let buf = &self.buffers.iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | self.cols.get_mut(index as usize).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.cols[index as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | for ref col in self.cols.iter() { [INFO] [stderr] | ^^^^^^^ ---------------- help: try: `let col = &self.cols.iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | let formatted = format!("{}", col.out(template)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `col.out(template).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | let ref mut buffer = self.buffers[len-1]; [INFO] [stderr] | ----^^^^^^^^^^^^^^----------------------- help: try: `let buffer = &mut self.buffers[len-1];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | for ref buf in self.buffers.iter() { [INFO] [stderr] | ^^^^^^^ ------------------- help: try: `let buf = &self.buffers.iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | self.rows.get_mut(len-1).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.rows[len-1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:86:9 [INFO] [stderr] | [INFO] [stderr] 86 | self.cols.get_mut(index as usize).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.cols[index as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | for ref row in self.rows.iter() { [INFO] [stderr] | ^^^^^^^ ---------------- help: try: `let row = &self.rows.iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | let formatted = format!("{}", row.out(template)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `row.out(template).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:171:33 [INFO] [stderr] | [INFO] [stderr] 171 | fn from_vec(&mut self, vec: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | fn from_vec(&mut self, vec: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | for ref col in self.cols.iter() { [INFO] [stderr] | ^^^^^^^ ---------------- help: try: `let col = &self.cols.iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:102:29 [INFO] [stderr] | [INFO] [stderr] 102 | let formatted = format!("{}", col.out(template)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `col.out(template).to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | self.rows.get_mut(len-1).unwrap() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.rows[len-1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | for ref row in self.rows.iter() { [INFO] [stderr] | ^^^^^^^ ---------------- help: try: `let row = &self.rows.iter();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:135:29 [INFO] [stderr] | [INFO] [stderr] 135 | let formatted = format!("{}", row.out(template)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `row.out(template).to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:171:33 [INFO] [stderr] | [INFO] [stderr] 171 | fn from_vec(&mut self, vec: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/main.rs:171:17 [INFO] [stderr] | [INFO] [stderr] 171 | fn from_vec(&mut self, vec: &Vec<&str>) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | let ref template = match self.work_type { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 242 | let template = &(match self.work_type { [INFO] [stderr] 243 | Type::Button(ref t) => match t { [INFO] [stderr] 244 | &ButtonType::Button => template.button.as_str(), [INFO] [stderr] 245 | &ButtonType::A => template.a.as_str(), [INFO] [stderr] 246 | _ => "" [INFO] [stderr] 247 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:243:36 [INFO] [stderr] | [INFO] [stderr] 243 | Type::Button(ref t) => match t { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 244 | | &ButtonType::Button => template.button.as_str(), [INFO] [stderr] 245 | | &ButtonType::A => template.a.as_str(), [INFO] [stderr] 246 | | _ => "" [INFO] [stderr] 247 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 243 | Type::Button(ref t) => match *t { [INFO] [stderr] 244 | ButtonType::Button => template.button.as_str(), [INFO] [stderr] 245 | ButtonType::A => template.a.as_str(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:252:35 [INFO] [stderr] | [INFO] [stderr] 252 | Type::Input(ref t) => match t { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 253 | | &InputType::Text => template.text.as_str(), [INFO] [stderr] 254 | | &InputType::Radio => template.radio.as_str(), [INFO] [stderr] 255 | | &InputType::Checkbox => template.checkbox.as_str(), [INFO] [stderr] 256 | | &InputType::Textarea => template.textarea.as_str() [INFO] [stderr] 257 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 252 | Type::Input(ref t) => match *t { [INFO] [stderr] 253 | InputType::Text => template.text.as_str(), [INFO] [stderr] 254 | InputType::Radio => template.radio.as_str(), [INFO] [stderr] 255 | InputType::Checkbox => template.checkbox.as_str(), [INFO] [stderr] 256 | InputType::Textarea => template.textarea.as_str() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:268:57 [INFO] [stderr] | [INFO] [stderr] 268 | let split: Vec = self.str.split("?").map(|s| s.to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:287:72 [INFO] [stderr] | [INFO] [stderr] 287 | Type::Select => to_json(&ManyConfig {value: self.str.split(",").map(|s| s.to_owned()).collect()}), [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | let ref template = match self.work_type { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 242 | let template = &(match self.work_type { [INFO] [stderr] 243 | Type::Button(ref t) => match t { [INFO] [stderr] 244 | &ButtonType::Button => template.button.as_str(), [INFO] [stderr] 245 | &ButtonType::A => template.a.as_str(), [INFO] [stderr] 246 | _ => "" [INFO] [stderr] 247 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:243:36 [INFO] [stderr] | [INFO] [stderr] 243 | Type::Button(ref t) => match t { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 244 | | &ButtonType::Button => template.button.as_str(), [INFO] [stderr] 245 | | &ButtonType::A => template.a.as_str(), [INFO] [stderr] 246 | | _ => "" [INFO] [stderr] 247 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 243 | Type::Button(ref t) => match *t { [INFO] [stderr] 244 | ButtonType::Button => template.button.as_str(), [INFO] [stderr] 245 | ButtonType::A => template.a.as_str(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:252:35 [INFO] [stderr] | [INFO] [stderr] 252 | Type::Input(ref t) => match t { [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 253 | | &InputType::Text => template.text.as_str(), [INFO] [stderr] 254 | | &InputType::Radio => template.radio.as_str(), [INFO] [stderr] 255 | | &InputType::Checkbox => template.checkbox.as_str(), [INFO] [stderr] 256 | | &InputType::Textarea => template.textarea.as_str() [INFO] [stderr] 257 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 252 | Type::Input(ref t) => match *t { [INFO] [stderr] 253 | InputType::Text => template.text.as_str(), [INFO] [stderr] 254 | InputType::Radio => template.radio.as_str(), [INFO] [stderr] 255 | InputType::Checkbox => template.checkbox.as_str(), [INFO] [stderr] 256 | InputType::Textarea => template.textarea.as_str() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:268:57 [INFO] [stderr] | [INFO] [stderr] 268 | let split: Vec = self.str.split("?").map(|s| s.to_string()).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'?'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:287:72 [INFO] [stderr] | [INFO] [stderr] 287 | Type::Select => to_json(&ManyConfig {value: self.str.split(",").map(|s| s.to_owned()).collect()}), [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:321:37 [INFO] [stderr] | [INFO] [stderr] 321 | let v: Vec<&str> = buffer.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:373:17 [INFO] [stderr] | [INFO] [stderr] 373 | Err(_) => panic!("Unable to open template file"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:381:47 [INFO] [stderr] | [INFO] [stderr] 381 | let sp: Vec<&str> = content.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:385:14 [INFO] [stderr] | [INFO] [stderr] 385 | _ => match env::var("template") { [INFO] [stderr] | ______________^ [INFO] [stderr] 386 | | Ok(val) => { [INFO] [stderr] 387 | | let tv: Vec<&str> = val.split(",").collect(); [INFO] [stderr] 388 | | template.from_vec(&tv); [INFO] [stderr] 389 | | }, [INFO] [stderr] 390 | | _ => {} [INFO] [stderr] 391 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 385 | _ => if let Ok(val) = env::var("template") { [INFO] [stderr] 386 | let tv: Vec<&str> = val.split(",").collect(); [INFO] [stderr] 387 | template.from_vec(&tv); [INFO] [stderr] 388 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:387:47 [INFO] [stderr] | [INFO] [stderr] 387 | let tv: Vec<&str> = val.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:321:37 [INFO] [stderr] | [INFO] [stderr] 321 | let v: Vec<&str> = buffer.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:373:17 [INFO] [stderr] | [INFO] [stderr] 373 | Err(_) => panic!("Unable to open template file"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:381:47 [INFO] [stderr] | [INFO] [stderr] 381 | let sp: Vec<&str> = content.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:385:14 [INFO] [stderr] | [INFO] [stderr] 385 | _ => match env::var("template") { [INFO] [stderr] | ______________^ [INFO] [stderr] 386 | | Ok(val) => { [INFO] [stderr] 387 | | let tv: Vec<&str> = val.split(",").collect(); [INFO] [stderr] 388 | | template.from_vec(&tv); [INFO] [stderr] 389 | | }, [INFO] [stderr] 390 | | _ => {} [INFO] [stderr] 391 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 385 | _ => if let Ok(val) = env::var("template") { [INFO] [stderr] 386 | let tv: Vec<&str> = val.split(",").collect(); [INFO] [stderr] 387 | template.from_vec(&tv); [INFO] [stderr] 388 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:387:47 [INFO] [stderr] | [INFO] [stderr] 387 | let tv: Vec<&str> = val.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.86s [INFO] running `"docker" "inspect" "19f1b6a9ec15cdc4f5571c35328f82afb73ffeb280589d349a5168c2f6205b96"` [INFO] running `"docker" "rm" "-f" "19f1b6a9ec15cdc4f5571c35328f82afb73ffeb280589d349a5168c2f6205b96"` [INFO] [stdout] 19f1b6a9ec15cdc4f5571c35328f82afb73ffeb280589d349a5168c2f6205b96