[INFO] updating cached repository methodin/tiger [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/methodin/tiger [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/methodin/tiger" "work/ex/clippy-test-run/sources/stable/gh/methodin/tiger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/methodin/tiger'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/methodin/tiger" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/methodin/tiger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/methodin/tiger'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 24cd5f7adf93f7a5ba1e4f64a0fe2e44306882c9 [INFO] sha for GitHub repo methodin/tiger: 24cd5f7adf93f7a5ba1e4f64a0fe2e44306882c9 [INFO] validating manifest of methodin/tiger on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of methodin/tiger on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing methodin/tiger [INFO] finished frobbing methodin/tiger [INFO] frobbed toml for methodin/tiger written to work/ex/clippy-test-run/sources/stable/gh/methodin/tiger/Cargo.toml [INFO] started frobbing methodin/tiger [INFO] finished frobbing methodin/tiger [INFO] frobbed toml for methodin/tiger written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/methodin/tiger/Cargo.toml [INFO] crate methodin/tiger has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting methodin/tiger against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/methodin/tiger:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] caa1158e954a489b83be829bb03fd9f3fe7536699bb6ec66a4855fbcf14ed680 [INFO] running `"docker" "start" "-a" "caa1158e954a489b83be829bb03fd9f3fe7536699bb6ec66a4855fbcf14ed680"` [INFO] [stderr] Compiling either v1.1.0 [INFO] [stderr] Compiling scopeguard v0.3.2 [INFO] [stderr] Compiling openssl v0.9.14 [INFO] [stderr] Compiling futures v0.1.14 [INFO] [stderr] Checking untrusted v0.5.0 [INFO] [stderr] Checking cfg-if v0.1.1 [INFO] [stderr] Checking uuid v0.5.0 [INFO] [stderr] Checking md5 v0.3.4 [INFO] [stderr] Compiling openssl-sys v0.9.14 [INFO] [stderr] Compiling num_cpus v1.5.1 [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Checking thread-id v3.1.0 [INFO] [stderr] Checking xml-rs v0.6.0 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking bincode v0.8.0 [INFO] [stderr] Checking nix v0.8.1 [INFO] [stderr] Checking net2 v0.2.29 [INFO] [stderr] Checking idna v0.1.2 [INFO] [stderr] Compiling coco v0.1.1 [INFO] [stderr] Checking nom v3.1.0 [INFO] [stderr] Checking retry v0.4.0 [INFO] [stderr] Compiling rusoto_core v0.26.0 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking chrono v0.3.1 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking url v1.5.0 [INFO] [stderr] Compiling rayon-core v1.2.1 [INFO] [stderr] Checking hyper v0.10.12 [INFO] [stderr] Checking serde_urlencoded v0.4.3 [INFO] [stderr] Compiling rayon v0.7.1 [INFO] [stderr] Checking mysql v11.1.2 [INFO] [stderr] Checking native-tls v0.1.2 [INFO] [stderr] Compiling ring v0.9.7 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking reqwest v0.4.0 [INFO] [stderr] Checking rusoto_credential v0.7.0 [INFO] [stderr] Checking rusoto_s3 v0.26.0 [INFO] [stderr] Checking tiger v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/change.rs:111:57 [INFO] [stderr] | [INFO] [stderr] 111 | println!("Creating new up file {}/{}", &change_dir, "up.sql"); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/change.rs:117:57 [INFO] [stderr] | [INFO] [stderr] 117 | println!("Creating new up file {}/{}", &change_dir, "down.sql"); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/change.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | up_content: up_content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `up_content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | down_content: down_content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `down_content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/change.rs:111:57 [INFO] [stderr] | [INFO] [stderr] 111 | println!("Creating new up file {}/{}", &change_dir, "up.sql"); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/change.rs:117:57 [INFO] [stderr] | [INFO] [stderr] 117 | println!("Creating new up file {}/{}", &change_dir, "down.sql"); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/change.rs:123:9 [INFO] [stderr] | [INFO] [stderr] 123 | hash: hash, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | up_content: up_content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `up_content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | down_content: down_content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `down_content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/project.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | Err(_) => panic!("Could not serialize project file"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/project.rs:141:25 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn create(name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/project.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | if let Ok(_) = fs::metadata(&project_dir) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 148 | | println!("Project {} already exists", name); [INFO] [stderr] 149 | | return; [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________- help: try this: `if fs::metadata(&project_dir).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/project.rs:179:18 [INFO] [stderr] | [INFO] [stderr] 179 | .expect(format!("Could not remove dir {}", &change_dir).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not remove dir {}", &change_dir))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/execute.rs:41:8 [INFO] [stderr] | [INFO] [stderr] 41 | if pres.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pres.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/execute.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | for ref change in pres.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^ --------------- help: try: `let change = &pres.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/execute.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | if posts.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!posts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/execute.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | for ref change in posts.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^ ---------------- help: try: `let change = &posts.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/execute.rs:105:8 [INFO] [stderr] | [INFO] [stderr] 105 | if changes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `changes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/change.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | Err(_) => panic!("couldn't read {}", target), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/change.rs:149:10 [INFO] [stderr] | [INFO] [stderr] 149 | .expect(format!("Could not remove dir {}", &change_dir).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not remove dir {}", &change_dir))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/package.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn load(file_name: &String, config: &Config) -> Project { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 86 | pub fn load(file_name: &str, config: &Config) -> Project { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `file_name.clone()` to [INFO] [stderr] | [INFO] [stderr] 95 | req.key = format!("{}.bin", file_name.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/config.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | Err(_) => panic!("couldn't read {}", config), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | assert!(args.len() > 0, "You must provide at least one parameter"); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/project.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | Err(_) => panic!("Could not serialize project file"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/project.rs:141:25 [INFO] [stderr] | [INFO] [stderr] 141 | pub fn create(name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/project.rs:147:16 [INFO] [stderr] | [INFO] [stderr] 147 | if let Ok(_) = fs::metadata(&project_dir) { [INFO] [stderr] | _________- ^^^^^ [INFO] [stderr] 148 | | println!("Project {} already exists", name); [INFO] [stderr] 149 | | return; [INFO] [stderr] 150 | | } [INFO] [stderr] | |_________- help: try this: `if fs::metadata(&project_dir).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/project.rs:179:18 [INFO] [stderr] | [INFO] [stderr] 179 | .expect(format!("Could not remove dir {}", &change_dir).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not remove dir {}", &change_dir))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/execute.rs:41:8 [INFO] [stderr] | [INFO] [stderr] 41 | if pres.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!pres.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/execute.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | for ref change in pres.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^ --------------- help: try: `let change = &pres.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/execute.rs:52:8 [INFO] [stderr] | [INFO] [stderr] 52 | if posts.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!posts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/execute.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | for ref change in posts.iter_mut() { [INFO] [stderr] | ^^^^^^^^^^ ---------------- help: try: `let change = &posts.iter_mut();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/execute.rs:105:8 [INFO] [stderr] | [INFO] [stderr] 105 | if changes.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `changes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/change.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | Err(_) => panic!("couldn't read {}", target), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/change.rs:149:10 [INFO] [stderr] | [INFO] [stderr] 149 | .expect(format!("Could not remove dir {}", &change_dir).as_str()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not remove dir {}", &change_dir))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/package.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn load(file_name: &String, config: &Config) -> Project { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 86 | pub fn load(file_name: &str, config: &Config) -> Project { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `file_name.clone()` to [INFO] [stderr] | [INFO] [stderr] 95 | req.key = format!("{}.bin", file_name.to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/config.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | Err(_) => panic!("couldn't read {}", config), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:38:21 [INFO] [stderr] | [INFO] [stderr] 38 | assert!(args.len() > 0, "You must provide at least one parameter"); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 51.17s [INFO] running `"docker" "inspect" "caa1158e954a489b83be829bb03fd9f3fe7536699bb6ec66a4855fbcf14ed680"` [INFO] running `"docker" "rm" "-f" "caa1158e954a489b83be829bb03fd9f3fe7536699bb6ec66a4855fbcf14ed680"` [INFO] [stdout] caa1158e954a489b83be829bb03fd9f3fe7536699bb6ec66a4855fbcf14ed680