[INFO] updating cached repository mesalock-linux/mkpkg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mesalock-linux/mkpkg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mesalock-linux/mkpkg" "work/ex/clippy-test-run/sources/stable/gh/mesalock-linux/mkpkg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mesalock-linux/mkpkg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mesalock-linux/mkpkg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mesalock-linux/mkpkg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mesalock-linux/mkpkg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 90e74a32583bd1ef1b0c85a65b62fc5587dd44aa [INFO] sha for GitHub repo mesalock-linux/mkpkg: 90e74a32583bd1ef1b0c85a65b62fc5587dd44aa [INFO] validating manifest of mesalock-linux/mkpkg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mesalock-linux/mkpkg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mesalock-linux/mkpkg [INFO] finished frobbing mesalock-linux/mkpkg [INFO] frobbed toml for mesalock-linux/mkpkg written to work/ex/clippy-test-run/sources/stable/gh/mesalock-linux/mkpkg/Cargo.toml [INFO] started frobbing mesalock-linux/mkpkg [INFO] finished frobbing mesalock-linux/mkpkg [INFO] frobbed toml for mesalock-linux/mkpkg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mesalock-linux/mkpkg/Cargo.toml [INFO] crate mesalock-linux/mkpkg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mesalock-linux/mkpkg against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mesalock-linux/mkpkg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cb1451f99c65ba297c16153b90ad44c842d982bdde17dcef9c217b4e44066990 [INFO] running `"docker" "start" "-a" "cb1451f99c65ba297c16153b90ad44c842d982bdde17dcef9c217b4e44066990"` [INFO] [stderr] Compiling proc-macro2 v0.4.23 [INFO] [stderr] Checking term_size v1.0.0-beta1 [INFO] [stderr] Checking filetime v0.2.3 [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Compiling curl-sys v0.4.15 [INFO] [stderr] Compiling lzma-sys v0.1.11 [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Checking relay v0.1.1 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking clicolors-control v0.2.0 [INFO] [stderr] Checking uuid v0.6.5 [INFO] [stderr] Checking want v0.0.4 [INFO] [stderr] Checking tar v0.4.19 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking tempfile v3.0.4 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Checking xz2 v0.1.6 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling quote v0.6.10 [INFO] [stderr] Checking bzip2 v0.3.3 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Compiling syn v0.15.20 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking crossbeam-channel v0.3.1 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.3 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking crossbeam v0.5.0 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Compiling libgit2-sys v0.7.10 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking hyper-tls v0.1.4 [INFO] [stderr] Checking reqwest v0.8.8 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking mkpkg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | licenses: licenses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `licenses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/package.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | env: env, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | licenses: licenses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `licenses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/network.rs:353:13 [INFO] [stderr] | [INFO] [stderr] 353 | instance_length: _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Bytes { range: Some((from, to)), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused import: `crossbeam` [INFO] [stderr] --> src/progress.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use crossbeam; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/progress.rs:210:24 [INFO] [stderr] | [INFO] [stderr] 210 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 211 | | if current_queue + 1 < queues.len() { [INFO] [stderr] 212 | | queues[current_queue + 1].push(buildfile); [INFO] [stderr] 213 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 210 | } else if current_queue + 1 < queues.len() { [INFO] [stderr] 211 | queues[current_queue + 1].push(buildfile); [INFO] [stderr] 212 | } else { [INFO] [stderr] 213 | // XXX: is it clearer if the total bar increases even on failure? [INFO] [stderr] 214 | total_bar.inc(1); [INFO] [stderr] 215 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/progress.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | progbar [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/progress.rs:244:23 [INFO] [stderr] | [INFO] [stderr] 244 | let progbar = ProgressBar::new(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/network.rs:353:13 [INFO] [stderr] | [INFO] [stderr] 353 | instance_length: _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Bytes { range: Some((from, to)), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused import: `crossbeam` [INFO] [stderr] --> src/progress.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use crossbeam; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/progress.rs:210:24 [INFO] [stderr] | [INFO] [stderr] 210 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 211 | | if current_queue + 1 < queues.len() { [INFO] [stderr] 212 | | queues[current_queue + 1].push(buildfile); [INFO] [stderr] 213 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 216 | | } [INFO] [stderr] 217 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 210 | } else if current_queue + 1 < queues.len() { [INFO] [stderr] 211 | queues[current_queue + 1].push(buildfile); [INFO] [stderr] 212 | } else { [INFO] [stderr] 213 | // XXX: is it clearer if the total bar increases even on failure? [INFO] [stderr] 214 | total_bar.inc(1); [INFO] [stderr] 215 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/progress.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | progbar [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/progress.rs:244:23 [INFO] [stderr] | [INFO] [stderr] 244 | let progbar = ProgressBar::new(0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `with_urls` [INFO] [stderr] --> src/package.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | pub(crate) fn with_urls(urls: Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `description` [INFO] [stderr] --> src/package.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | pub fn description(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `license` [INFO] [stderr] --> src/package.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | pub fn license(&self) -> &[String] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `skip_check` [INFO] [stderr] --> src/package.rs:203:5 [INFO] [stderr] | [INFO] [stderr] 203 | pub fn skip_check(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `build_dir` [INFO] [stderr] --> src/package.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn build_dir(&self, config: &Config) -> PathBuf { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/archive.rs:129:19 [INFO] [stderr] | [INFO] [stderr] 129 | ).map_err(|e| ArchiveError::Compress(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ArchiveError::Compress` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/archive.rs:154:26 [INFO] [stderr] | [INFO] [stderr] 154 | .map_err(|e| ArchiveError::Package(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ArchiveError::Package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/archive.rs:205:34 [INFO] [stderr] | [INFO] [stderr] 205 | .map_err(|e| ArchiveError::Util(e))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ArchiveError::Util` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/archive.rs:263:53 [INFO] [stderr] | [INFO] [stderr] 263 | let mut file = tempfile::tempfile().map_err(|e| ArchiveError::TempFile(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ArchiveError::TempFile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/archive.rs:273:57 [INFO] [stderr] | [INFO] [stderr] 273 | io::copy(&mut decoder, &mut writer).map_err(|e| ArchiveError::Decompress(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ArchiveError::Decompress` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/archive.rs:277:22 [INFO] [stderr] | [INFO] [stderr] 277 | .map_err(|e| ArchiveError::Decompress(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ArchiveError::Decompress` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/builder.rs:72:54 [INFO] [stderr] | [INFO] [stderr] 72 | let init_fn = move |total_bar: &ProgressBar, bar: &ProgressBar| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/builder.rs:93:30 [INFO] [stderr] | [INFO] [stderr] 93 | .map_err(|e| BuildError::Archive(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BuildError::Archive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/builder.rs:145:30 [INFO] [stderr] | [INFO] [stderr] 145 | .map_err(|e| BuildError::Archive(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BuildError::Archive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/builder.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | / fn run_step( [INFO] [stderr] 154 | | &self, [INFO] [stderr] 155 | | progbar: &ProgressBar, [INFO] [stderr] 156 | | config: &Config, [INFO] [stderr] ... | [INFO] [stderr] 202 | | Ok(()) [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/network.rs:86:54 [INFO] [stderr] | [INFO] [stderr] 86 | let init_fn = move |total_bar: &ProgressBar, bar: &ProgressBar| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/network.rs:130:67 [INFO] [stderr] | [INFO] [stderr] 130 | let filename = BuildFile::file_path(src_item).map_err(|e| NetworkError::Package(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `NetworkError::Package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/network.rs:164:65 [INFO] [stderr] | [INFO] [stderr] 164 | util::copy_dir(&filepath, &target_path).map_err(|e| NetworkError::Util(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `NetworkError::Util` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network.rs:186:34 [INFO] [stderr] | [INFO] [stderr] 186 | let mut sideband_check = progress_check.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `progress_check` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/package.rs:329:16 [INFO] [stderr] | [INFO] [stderr] 329 | if filename.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `filename.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/progress.rs:95:19 [INFO] [stderr] | [INFO] [stderr] 95 | } else if self.iter_fns.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.iter_fns.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/progress.rs:133:29 [INFO] [stderr] | [INFO] [stderr] 133 | for bar in bars { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/progress.rs:163:12 [INFO] [stderr] | [INFO] [stderr] 163 | if errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/progress.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | / fn progress_handler<'b>( [INFO] [stderr] 172 | | &self, [INFO] [stderr] 173 | | config: &Config, [INFO] [stderr] 174 | | init_fns: &[&'a InitFn<'a>], [INFO] [stderr] ... | [INFO] [stderr] 226 | | } [INFO] [stderr] 227 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/util.rs:87:35 [INFO] [stderr] | [INFO] [stderr] 87 | let entry = entry.map_err(|e| UtilError::DirEntry(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `UtilError::DirEntry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: method is never used: `with_urls` [INFO] [stderr] --> src/package.rs:158:5 [INFO] [stderr] | [INFO] [stderr] 158 | pub(crate) fn with_urls(urls: Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `description` [INFO] [stderr] --> src/package.rs:187:5 [INFO] [stderr] | [INFO] [stderr] 187 | pub fn description(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `license` [INFO] [stderr] --> src/package.rs:191:5 [INFO] [stderr] | [INFO] [stderr] 191 | pub fn license(&self) -> &[String] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `skip_check` [INFO] [stderr] --> src/package.rs:203:5 [INFO] [stderr] | [INFO] [stderr] 203 | pub fn skip_check(&self) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `build_dir` [INFO] [stderr] --> src/package.rs:227:5 [INFO] [stderr] | [INFO] [stderr] 227 | pub fn build_dir(&self, config: &Config) -> PathBuf { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/archive.rs:129:19 [INFO] [stderr] | [INFO] [stderr] 129 | ).map_err(|e| ArchiveError::Compress(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ArchiveError::Compress` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/archive.rs:154:26 [INFO] [stderr] | [INFO] [stderr] 154 | .map_err(|e| ArchiveError::Package(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ArchiveError::Package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/archive.rs:205:34 [INFO] [stderr] | [INFO] [stderr] 205 | .map_err(|e| ArchiveError::Util(e))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ArchiveError::Util` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/archive.rs:263:53 [INFO] [stderr] | [INFO] [stderr] 263 | let mut file = tempfile::tempfile().map_err(|e| ArchiveError::TempFile(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ArchiveError::TempFile` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/archive.rs:273:57 [INFO] [stderr] | [INFO] [stderr] 273 | io::copy(&mut decoder, &mut writer).map_err(|e| ArchiveError::Decompress(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ArchiveError::Decompress` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/archive.rs:277:22 [INFO] [stderr] | [INFO] [stderr] 277 | .map_err(|e| ArchiveError::Decompress(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ArchiveError::Decompress` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/builder.rs:72:54 [INFO] [stderr] | [INFO] [stderr] 72 | let init_fn = move |total_bar: &ProgressBar, bar: &ProgressBar| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/builder.rs:93:30 [INFO] [stderr] | [INFO] [stderr] 93 | .map_err(|e| BuildError::Archive(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BuildError::Archive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/builder.rs:145:30 [INFO] [stderr] | [INFO] [stderr] 145 | .map_err(|e| BuildError::Archive(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `BuildError::Archive` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/builder.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | / fn run_step( [INFO] [stderr] 154 | | &self, [INFO] [stderr] 155 | | progbar: &ProgressBar, [INFO] [stderr] 156 | | config: &Config, [INFO] [stderr] ... | [INFO] [stderr] 202 | | Ok(()) [INFO] [stderr] 203 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/network.rs:86:54 [INFO] [stderr] | [INFO] [stderr] 86 | let init_fn = move |total_bar: &ProgressBar, bar: &ProgressBar| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/network.rs:130:67 [INFO] [stderr] | [INFO] [stderr] 130 | let filename = BuildFile::file_path(src_item).map_err(|e| NetworkError::Package(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `NetworkError::Package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/network.rs:164:65 [INFO] [stderr] | [INFO] [stderr] 164 | util::copy_dir(&filepath, &target_path).map_err(|e| NetworkError::Util(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `NetworkError::Util` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/network.rs:186:34 [INFO] [stderr] | [INFO] [stderr] 186 | let mut sideband_check = progress_check.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `progress_check` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/package.rs:329:16 [INFO] [stderr] | [INFO] [stderr] 329 | if filename.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `filename.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/progress.rs:95:19 [INFO] [stderr] | [INFO] [stderr] 95 | } else if self.iter_fns.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.iter_fns.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/progress.rs:133:29 [INFO] [stderr] | [INFO] [stderr] 133 | for bar in bars { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/progress.rs:163:12 [INFO] [stderr] | [INFO] [stderr] 163 | if errors.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!errors.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/progress.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | / fn progress_handler<'b>( [INFO] [stderr] 172 | | &self, [INFO] [stderr] 173 | | config: &Config, [INFO] [stderr] 174 | | init_fns: &[&'a InitFn<'a>], [INFO] [stderr] ... | [INFO] [stderr] 226 | | } [INFO] [stderr] 227 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/util.rs:87:35 [INFO] [stderr] | [INFO] [stderr] 87 | let entry = entry.map_err(|e| UtilError::DirEntry(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `UtilError::DirEntry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 27s [INFO] running `"docker" "inspect" "cb1451f99c65ba297c16153b90ad44c842d982bdde17dcef9c217b4e44066990"` [INFO] running `"docker" "rm" "-f" "cb1451f99c65ba297c16153b90ad44c842d982bdde17dcef9c217b4e44066990"` [INFO] [stdout] cb1451f99c65ba297c16153b90ad44c842d982bdde17dcef9c217b4e44066990