[INFO] updating cached repository mesalock-linux/mgetty [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mesalock-linux/mgetty [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mesalock-linux/mgetty" "work/ex/clippy-test-run/sources/stable/gh/mesalock-linux/mgetty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mesalock-linux/mgetty'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mesalock-linux/mgetty" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mesalock-linux/mgetty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mesalock-linux/mgetty'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f90b45706c8f2bd39f04def007698cba04b3a65b [INFO] sha for GitHub repo mesalock-linux/mgetty: f90b45706c8f2bd39f04def007698cba04b3a65b [INFO] validating manifest of mesalock-linux/mgetty on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mesalock-linux/mgetty on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mesalock-linux/mgetty [INFO] finished frobbing mesalock-linux/mgetty [INFO] frobbed toml for mesalock-linux/mgetty written to work/ex/clippy-test-run/sources/stable/gh/mesalock-linux/mgetty/Cargo.toml [INFO] started frobbing mesalock-linux/mgetty [INFO] finished frobbing mesalock-linux/mgetty [INFO] frobbed toml for mesalock-linux/mgetty written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mesalock-linux/mgetty/Cargo.toml [INFO] crate mesalock-linux/mgetty has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mesalock-linux/mgetty against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mesalock-linux/mgetty:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7b99a0983b9d58867ba41f40916f18afd8df89d1b323fb7a6b7db491048272fe [INFO] running `"docker" "start" "-a" "7b99a0983b9d58867ba41f40916f18afd8df89d1b323fb7a6b7db491048272fe"` [INFO] [stderr] Checking mgetty v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `nix::sys::termios` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use nix::sys::termios; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/main.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | libc::fchmod(0, 0620); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 23 | libc::fchmod(0, 620); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 23 | libc::fchmod(0, 0o620); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:26:8 [INFO] [stderr] | [INFO] [stderr] 26 | if unistd::isatty(0).expect("isatty failed") == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!unistd::isatty(0).expect("isatty failed")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: unused import: `nix::sys::termios` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | use nix::sys::termios; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> src/main.rs:23:25 [INFO] [stderr] | [INFO] [stderr] 23 | libc::fchmod(0, 0620); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 23 | libc::fchmod(0, 620); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 23 | libc::fchmod(0, 0o620); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:26:8 [INFO] [stderr] | [INFO] [stderr] 26 | if unistd::isatty(0).expect("isatty failed") == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!unistd::isatty(0).expect("isatty failed")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.03s [INFO] running `"docker" "inspect" "7b99a0983b9d58867ba41f40916f18afd8df89d1b323fb7a6b7db491048272fe"` [INFO] running `"docker" "rm" "-f" "7b99a0983b9d58867ba41f40916f18afd8df89d1b323fb7a6b7db491048272fe"` [INFO] [stdout] 7b99a0983b9d58867ba41f40916f18afd8df89d1b323fb7a6b7db491048272fe