[INFO] updating cached repository mesalock-linux/loginutils [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mesalock-linux/loginutils [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mesalock-linux/loginutils" "work/ex/clippy-test-run/sources/stable/gh/mesalock-linux/loginutils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mesalock-linux/loginutils'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mesalock-linux/loginutils" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mesalock-linux/loginutils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mesalock-linux/loginutils'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6419ee19b12952454e4bfd55ce076b6abaf3e14e [INFO] sha for GitHub repo mesalock-linux/loginutils: 6419ee19b12952454e4bfd55ce076b6abaf3e14e [INFO] validating manifest of mesalock-linux/loginutils on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mesalock-linux/loginutils on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mesalock-linux/loginutils [INFO] finished frobbing mesalock-linux/loginutils [INFO] frobbed toml for mesalock-linux/loginutils written to work/ex/clippy-test-run/sources/stable/gh/mesalock-linux/loginutils/Cargo.toml [INFO] started frobbing mesalock-linux/loginutils [INFO] finished frobbing mesalock-linux/loginutils [INFO] frobbed toml for mesalock-linux/loginutils written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mesalock-linux/loginutils/Cargo.toml [INFO] crate mesalock-linux/loginutils has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mesalock-linux/loginutils against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mesalock-linux/loginutils:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aba3ac33328cdae02fca664355a0acbcb4a87dd363b3b1fb72f10fcc89fa05c2 [INFO] running `"docker" "start" "-a" "aba3ac33328cdae02fca664355a0acbcb4a87dd363b3b1fb72f10fcc89fa05c2"` [INFO] [stderr] Checking isatty v0.1.6 [INFO] [stderr] Checking termios v0.3.0 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking pwhash v0.1.2 [INFO] [stderr] Checking loginutils v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/login.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | const ENV_USER: &'static [u8] = b"USER\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/login.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | const ENV_LOGNAME: &'static [u8] = b"LOGNAME\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/login.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | const ENV_HOME: &'static [u8] = b"HOME\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/login.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | const ENV_SHELL: &'static [u8] = b"SHELL\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/login.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | const ENV_USER: &'static [u8] = b"USER\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/login.rs:20:21 [INFO] [stderr] | [INFO] [stderr] 20 | const ENV_LOGNAME: &'static [u8] = b"LOGNAME\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/login.rs:21:18 [INFO] [stderr] | [INFO] [stderr] 21 | const ENV_HOME: &'static [u8] = b"HOME\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/login.rs:22:19 [INFO] [stderr] | [INFO] [stderr] 22 | const ENV_SHELL: &'static [u8] = b"SHELL\0"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/login.rs:126:32 [INFO] [stderr] | [INFO] [stderr] 126 | return Err(From::from(io::Error::last_os_error())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `io::Error::last_os_error()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/bin/login.rs:250:29 [INFO] [stderr] | [INFO] [stderr] 250 | && libc::access(CString::new(path).unwrap().as_ptr(), libc::R_OK) == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/bin/login.rs:250:29 [INFO] [stderr] | [INFO] [stderr] 250 | && libc::access(CString::new(path).unwrap().as_ptr(), libc::R_OK) == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bin/login.rs:307:20 [INFO] [stderr] | [INFO] [stderr] 307 | if let Ok(_) = file.read_to_string(&mut message) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 308 | | println!("{}", message); [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____________- help: try this: `if file.read_to_string(&mut message).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bin/login.rs:126:32 [INFO] [stderr] | [INFO] [stderr] 126 | return Err(From::from(io::Error::last_os_error())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `From::from()`: `io::Error::last_os_error()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `loginutils`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/bin/login.rs:250:29 [INFO] [stderr] | [INFO] [stderr] 250 | && libc::access(CString::new(path).unwrap().as_ptr(), libc::R_OK) == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/bin/login.rs:250:29 [INFO] [stderr] | [INFO] [stderr] 250 | && libc::access(CString::new(path).unwrap().as_ptr(), libc::R_OK) == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stderr] --> src/bin/login.rs:307:20 [INFO] [stderr] | [INFO] [stderr] 307 | if let Ok(_) = file.read_to_string(&mut message) { [INFO] [stderr] | _____________- ^^^^^ [INFO] [stderr] 308 | | println!("{}", message); [INFO] [stderr] 309 | | } [INFO] [stderr] | |_____________- help: try this: `if file.read_to_string(&mut message).is_ok()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `loginutils`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "aba3ac33328cdae02fca664355a0acbcb4a87dd363b3b1fb72f10fcc89fa05c2"` [INFO] running `"docker" "rm" "-f" "aba3ac33328cdae02fca664355a0acbcb4a87dd363b3b1fb72f10fcc89fa05c2"` [INFO] [stdout] aba3ac33328cdae02fca664355a0acbcb4a87dd363b3b1fb72f10fcc89fa05c2