[INFO] updating cached repository mersinvald/batch_resolve [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mersinvald/batch_resolve [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mersinvald/batch_resolve" "work/ex/clippy-test-run/sources/stable/gh/mersinvald/batch_resolve"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mersinvald/batch_resolve'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mersinvald/batch_resolve" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mersinvald/batch_resolve"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mersinvald/batch_resolve'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2d75b712b85610b6791e649872495e572c091771 [INFO] sha for GitHub repo mersinvald/batch_resolve: 2d75b712b85610b6791e649872495e572c091771 [INFO] validating manifest of mersinvald/batch_resolve on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mersinvald/batch_resolve on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mersinvald/batch_resolve [INFO] finished frobbing mersinvald/batch_resolve [INFO] frobbed toml for mersinvald/batch_resolve written to work/ex/clippy-test-run/sources/stable/gh/mersinvald/batch_resolve/Cargo.toml [INFO] started frobbing mersinvald/batch_resolve [INFO] finished frobbing mersinvald/batch_resolve [INFO] frobbed toml for mersinvald/batch_resolve written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mersinvald/batch_resolve/Cargo.toml [INFO] crate mersinvald/batch_resolve has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mersinvald/batch_resolve against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mersinvald/batch_resolve:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 175d323a49afe81a704beb3d28c9024050b7b22282b559ea6a5b18815f77cf16 [INFO] running `"docker" "start" "-a" "175d323a49afe81a704beb3d28c9024050b7b22282b559ea6a5b18815f77cf16"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: path `/opt/crater/workdir/src/main.rs` was erroneously implicitly accepted for binary `batch_resolve`, [INFO] [stderr] please set bin.path in Cargo.toml [INFO] [stderr] Compiling openssl v0.9.11 [INFO] [stderr] Compiling trust-dns v0.10.1 [INFO] [stderr] Checking untrusted v0.3.2 [INFO] [stderr] Checking serde v1.0.3 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking net2 v0.2.29 [INFO] [stderr] Checking clicolors-control v0.1.0 [INFO] [stderr] Checking parking_lot_core v0.2.1 [INFO] [stderr] Checking clap v2.24.1 [INFO] [stderr] Checking openssl-sys v0.9.11 [INFO] [stderr] Compiling serde_derive_internals v0.15.0 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking env_logger v0.4.2 [INFO] [stderr] Checking bytes v0.4.3 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking parking_lot v0.4.3 [INFO] [stderr] Checking mio v0.6.7 [INFO] [stderr] Checking tokio-io v0.1.1 [INFO] [stderr] Checking indicatif v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.3 [INFO] [stderr] Checking tokio-core v0.1.7 [INFO] [stderr] Checking toml v0.4.0 [INFO] [stderr] Checking batch_resolve_cli v0.3.5 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/batch.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/batch.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/batch.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | qtype: qtype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `qtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/resolver.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | loop_handle: loop_handle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `loop_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/resolver.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | name_server: name_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/resolver.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | status_tx: status_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/resolver_threadpool.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | worker_qps: worker_qps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `worker_qps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/resolver_threadpool.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | tasks_cnt: tasks_cnt, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tasks_cnt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/batch.rs:73:21 [INFO] [stderr] | [INFO] [stderr] 73 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/batch.rs:144:13 [INFO] [stderr] | [INFO] [stderr] 144 | input: input, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `input` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/batch.rs:145:13 [INFO] [stderr] | [INFO] [stderr] 145 | qtype: qtype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `qtype` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/resolver.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | loop_handle: loop_handle, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `loop_handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/resolver.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | name_server: name_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `name_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/resolver.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | status_tx: status_tx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_tx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/resolver_threadpool.rs:96:13 [INFO] [stderr] | [INFO] [stderr] 96 | worker_qps: worker_qps, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `worker_qps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/resolve/resolver_threadpool.rs:98:13 [INFO] [stderr] | [INFO] [stderr] 98 | tasks_cnt: tasks_cnt, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tasks_cnt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/resolve/batch.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | / arg_enum!{ [INFO] [stderr] 111 | | #[derive(Copy, Clone, Debug)] [INFO] [stderr] 112 | | pub enum QueryType { [INFO] [stderr] 113 | | A, [INFO] [stderr] ... | [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/resolve/batch.rs:110:1 [INFO] [stderr] | [INFO] [stderr] 110 | / arg_enum!{ [INFO] [stderr] 111 | | #[derive(Copy, Clone, Debug)] [INFO] [stderr] 112 | | pub enum QueryType { [INFO] [stderr] 113 | | A, [INFO] [stderr] ... | [INFO] [stderr] 117 | | } [INFO] [stderr] 118 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/resolve/resolver.rs:184:20 [INFO] [stderr] | [INFO] [stderr] 184 | if !state.answer.is_none() || state.nameservers.is_empty() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.answer.is_some() || state.nameservers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/resolve/resolver.rs:384:14 [INFO] [stderr] | [INFO] [stderr] 384 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:97:67 [INFO] [stderr] | [INFO] [stderr] 97 | let inputs = values_t!(matches.values_of("inputs"), String).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:98:67 [INFO] [stderr] | [INFO] [stderr] 98 | let outputs = values_t!(matches.values_of("outputs"), String).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:99:70 [INFO] [stderr] | [INFO] [stderr] 99 | let qtypes = values_t!(matches.values_of("queries"), QueryType).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | s = status.lock().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `status.lock().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/resolve/resolver.rs:184:20 [INFO] [stderr] | [INFO] [stderr] 184 | if !state.answer.is_none() || state.nameservers.is_empty() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `state.answer.is_some() || state.nameservers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/resolve/resolver.rs:384:14 [INFO] [stderr] | [INFO] [stderr] 384 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:97:67 [INFO] [stderr] | [INFO] [stderr] 97 | let inputs = values_t!(matches.values_of("inputs"), String).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:98:67 [INFO] [stderr] | [INFO] [stderr] 98 | let outputs = values_t!(matches.values_of("outputs"), String).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:99:70 [INFO] [stderr] | [INFO] [stderr] 99 | let qtypes = values_t!(matches.values_of("queries"), QueryType).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/main.rs:206:17 [INFO] [stderr] | [INFO] [stderr] 206 | s = status.lock().unwrap().clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `status.lock().unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.57s [INFO] running `"docker" "inspect" "175d323a49afe81a704beb3d28c9024050b7b22282b559ea6a5b18815f77cf16"` [INFO] running `"docker" "rm" "-f" "175d323a49afe81a704beb3d28c9024050b7b22282b559ea6a5b18815f77cf16"` [INFO] [stdout] 175d323a49afe81a704beb3d28c9024050b7b22282b559ea6a5b18815f77cf16