[INFO] updating cached repository meepoSenpai/trebuchet-rs
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/meepoSenpai/trebuchet-rs
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/meepoSenpai/trebuchet-rs" "work/ex/clippy-test-run/sources/stable/gh/meepoSenpai/trebuchet-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/meepoSenpai/trebuchet-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/meepoSenpai/trebuchet-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/meepoSenpai/trebuchet-rs"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/meepoSenpai/trebuchet-rs'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 542b57b2dabd8bdf5e3eed46a726cfb2be3fd4db
[INFO] sha for GitHub repo meepoSenpai/trebuchet-rs: 542b57b2dabd8bdf5e3eed46a726cfb2be3fd4db
[INFO] validating manifest of meepoSenpai/trebuchet-rs on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of meepoSenpai/trebuchet-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing meepoSenpai/trebuchet-rs
[INFO] finished frobbing meepoSenpai/trebuchet-rs
[INFO] frobbed toml for meepoSenpai/trebuchet-rs written to work/ex/clippy-test-run/sources/stable/gh/meepoSenpai/trebuchet-rs/Cargo.toml
[INFO] started frobbing meepoSenpai/trebuchet-rs
[INFO] finished frobbing meepoSenpai/trebuchet-rs
[INFO] frobbed toml for meepoSenpai/trebuchet-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/meepoSenpai/trebuchet-rs/Cargo.toml
[INFO] crate meepoSenpai/trebuchet-rs has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting meepoSenpai/trebuchet-rs against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/meepoSenpai/trebuchet-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9ffca5742a1d4e2770806d9894f364c1f367aca3924ea5d91f6e51377deeb04e
[INFO] running `"docker" "start" "-a" "9ffca5742a1d4e2770806d9894f364c1f367aca3924ea5d91f6e51377deeb04e"`
[INFO] [stderr]    Compiling version_check v0.1.2
[INFO] [stderr]     Checking memchr v1.0.1
[INFO] [stderr]     Checking serde_json v0.9.10
[INFO] [stderr]    Compiling serde_codegen_internals v0.14.2
[INFO] [stderr]     Checking serde_urlencoded v0.4.3
[INFO] [stderr]     Checking aho-corasick v0.6.3
[INFO] [stderr]    Compiling unicase v1.4.2
[INFO] [stderr]    Compiling serde_derive v0.9.15
[INFO] [stderr]     Checking regex v0.2.2
[INFO] [stderr]     Checking hyper v0.10.12
[INFO] [stderr]     Checking hyper-native-tls v0.2.4
[INFO] [stderr]     Checking reqwest v0.4.0
[INFO] [stderr]     Checking ddg v0.3.0
[INFO] [stderr]     Checking trebuchet-rs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/web_search.rs:5:18
[INFO] [stderr]   |
[INFO] [stderr] 5 | const APP_NAME: &'static str = "trebuchet-rs";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/web_search.rs:64:18
[INFO] [stderr]    |
[INFO] [stderr] 64 |         Ok(t) => return Some(t),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(t)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/web_search.rs:65:19
[INFO] [stderr]    |
[INFO] [stderr] 65 |         Err(_) => return None,
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:13:24
[INFO] [stderr]    |
[INFO] [stderr] 13 | const VALID_PREFIXES: &'static str = "Valid command-prefixes: ['run:', 'quack:', 'web:', 'file:', 'related:']";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/web_search.rs:5:18
[INFO] [stderr]   |
[INFO] [stderr] 5 | const APP_NAME: &'static str = "trebuchet-rs";
[INFO] [stderr]   |                 -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/web_search.rs:64:18
[INFO] [stderr]    |
[INFO] [stderr] 64 |         Ok(t) => return Some(t),
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(t)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/web_search.rs:65:19
[INFO] [stderr]    |
[INFO] [stderr] 65 |         Err(_) => return None,
[INFO] [stderr]    |                   ^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:13:24
[INFO] [stderr]    |
[INFO] [stderr] 13 | const VALID_PREFIXES: &'static str = "Valid command-prefixes: ['run:', 'quack:', 'web:', 'file:', 'related:']";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `try_launch`
[INFO] [stderr]   --> src/launch.rs:13:1
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub fn try_launch(name: &str) -> Result<(), Box<Error>> {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/file_search.rs:21:24
[INFO] [stderr]    |
[INFO] [stderr] 21 | pub fn search_for_file<'a>(search: &str) -> Result<Vec<String>, Box<Error>> {
[INFO] [stderr]    |                        ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/web_search.rs:16:17
[INFO] [stderr]    |
[INFO] [stderr] 16 | /                 match r {
[INFO] [stderr] 17 | |                     &ddg::RelatedTopic::TopicResult(ref topic) => {
[INFO] [stderr] 18 | |                         print_topic_result(i, topic);
[INFO] [stderr] 19 | |                     }
[INFO] [stderr] ...  |
[INFO] [stderr] 23 | |                     }
[INFO] [stderr] 24 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 16 |                 match *r {
[INFO] [stderr] 17 |                     ddg::RelatedTopic::TopicResult(ref topic) => {
[INFO] [stderr] 18 |                         print_topic_result(i, topic);
[INFO] [stderr] 19 |                     }
[INFO] [stderr] 20 | 
[INFO] [stderr] 21 |                     ddg::RelatedTopic::Topic(_) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/web_search.rs:49:33
[INFO] [stderr]    |
[INFO] [stderr] 49 |                                 *counter = *counter + 1;
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `try_launch`
[INFO] [stderr]   --> src/launch.rs:13:1
[INFO] [stderr]    |
[INFO] [stderr] 13 | pub fn try_launch(name: &str) -> Result<(), Box<Error>> {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this lifetime isn't used in the function definition
[INFO] [stderr]   --> src/file_search.rs:21:24
[INFO] [stderr]    |
[INFO] [stderr] 21 | pub fn search_for_file<'a>(search: &str) -> Result<Vec<String>, Box<Error>> {
[INFO] [stderr]    |                        ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::extra_unused_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/web_search.rs:16:17
[INFO] [stderr]    |
[INFO] [stderr] 16 | /                 match r {
[INFO] [stderr] 17 | |                     &ddg::RelatedTopic::TopicResult(ref topic) => {
[INFO] [stderr] 18 | |                         print_topic_result(i, topic);
[INFO] [stderr] 19 | |                     }
[INFO] [stderr] ...  |
[INFO] [stderr] 23 | |                     }
[INFO] [stderr] 24 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 16 |                 match *r {
[INFO] [stderr] 17 |                     ddg::RelatedTopic::TopicResult(ref topic) => {
[INFO] [stderr] 18 |                         print_topic_result(i, topic);
[INFO] [stderr] 19 |                     }
[INFO] [stderr] 20 | 
[INFO] [stderr] 21 |                     ddg::RelatedTopic::Topic(_) => {
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/web_search.rs:49:33
[INFO] [stderr]    |
[INFO] [stderr] 49 |                                 *counter = *counter + 1;
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 21.56s
[INFO] running `"docker" "inspect" "9ffca5742a1d4e2770806d9894f364c1f367aca3924ea5d91f6e51377deeb04e"`
[INFO] running `"docker" "rm" "-f" "9ffca5742a1d4e2770806d9894f364c1f367aca3924ea5d91f6e51377deeb04e"`
[INFO] [stdout] 9ffca5742a1d4e2770806d9894f364c1f367aca3924ea5d91f6e51377deeb04e