[INFO] updating cached repository meamuri/population-data-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/meamuri/population-data-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/meamuri/population-data-rs" "work/ex/clippy-test-run/sources/stable/gh/meamuri/population-data-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/meamuri/population-data-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/meamuri/population-data-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/meamuri/population-data-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/meamuri/population-data-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] afc40e519fb443d96ad929ba27a5848bfa36ab43 [INFO] sha for GitHub repo meamuri/population-data-rs: afc40e519fb443d96ad929ba27a5848bfa36ab43 [INFO] validating manifest of meamuri/population-data-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of meamuri/population-data-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing meamuri/population-data-rs [INFO] finished frobbing meamuri/population-data-rs [INFO] frobbed toml for meamuri/population-data-rs written to work/ex/clippy-test-run/sources/stable/gh/meamuri/population-data-rs/Cargo.toml [INFO] started frobbing meamuri/population-data-rs [INFO] finished frobbing meamuri/population-data-rs [INFO] frobbed toml for meamuri/population-data-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/meamuri/population-data-rs/Cargo.toml [INFO] crate meamuri/population-data-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting meamuri/population-data-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/meamuri/population-data-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ba265a9d3998273e1ffce1a088d0e554561307c5c155ef211f88fc83005fd0d5 [INFO] running `"docker" "start" "-a" "ba265a9d3998273e1ffce1a088d0e554561307c5c155ef211f88fc83005fd0d5"` [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking hostname v0.1.3 [INFO] [stderr] Checking serde_json v1.0.2 [INFO] [stderr] Checking base64 v0.4.2 [INFO] [stderr] Checking semver v0.7.0 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking csv-core v0.1.2 [INFO] [stderr] Checking csv v1.0.0-beta.3 [INFO] [stderr] Checking textnonce v0.6.0 [INFO] [stderr] Checking bson v0.9.0 [INFO] [stderr] Checking mongodb v0.3.1 [INFO] [stderr] Checking population_data_rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dao/mod.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/dao/mod.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | year: year, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `year` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | const FILE_BOTH: &'static str = "data/unsd-citypopulation-year-both.csv"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | const FILE_DIFF: &'static str = "data/unsd-citypopulation-year-fm.csv"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/computing/loader.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | *&record[1].parse::().unwrap_or_default(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `record[1].parse::().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/computing/loader.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | *&record[9].parse::().unwrap_or_default(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `record[9].parse::().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:7:19 [INFO] [stderr] | [INFO] [stderr] 7 | const FILE_BOTH: &'static str = "data/unsd-citypopulation-year-both.csv"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/app.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | const FILE_DIFF: &'static str = "data/unsd-citypopulation-year-fm.csv"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/computing/loader.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | *&record[1].parse::().unwrap_or_default(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `record[1].parse::().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/computing/loader.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | *&record[9].parse::().unwrap_or_default(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `record[9].parse::().unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/app.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | Err(_) => { panic!("ooops") }, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/app.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | Err(_) => { panic!("ooops") }, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/app.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | Err(_) => { panic!("ooops") }, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/app.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | Err(_) => { panic!("ooops") }, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/computing/loader.rs:39:53 [INFO] [stderr] | [INFO] [stderr] 39 | let city = checker.entry(city_name.clone()).or_insert(val.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| val.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/computing/loader.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | let f_records: Vec = records.iter() [INFO] [stderr] | ________________________________^ [INFO] [stderr] 54 | | .filter(|city| city.get_part() == 'f') [INFO] [stderr] 55 | | .map(|city| city.clone()) [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 53 | let f_records: Vec = records.iter() [INFO] [stderr] 54 | .filter(|city| city.get_part() == 'f').cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/computing/loader.rs:57:32 [INFO] [stderr] | [INFO] [stderr] 57 | let m_records: Vec = records.iter() [INFO] [stderr] | ________________________________^ [INFO] [stderr] 58 | | .filter(|city| city.get_part() == 'm') [INFO] [stderr] 59 | | .map(|city| city.clone()) [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 57 | let m_records: Vec = records.iter() [INFO] [stderr] 58 | .filter(|city| city.get_part() == 'm').cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/computing/loader.rs:70:51 [INFO] [stderr] | [INFO] [stderr] 70 | let vector = res.entry(val.get_country()).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/solve.rs:4:33 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn millionaires(countries: &HashMap>, level: f64) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 4 | pub fn millionaires(countries: &HashMap, S>, level: f64) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/solve.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn population(countries: &HashMap>) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 15 | pub fn population(countries: &HashMap, S>) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/solve.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn top(countries: &HashMap>, n: usize) -> HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 26 | pub fn top(countries: &HashMap, S>, n: usize) -> HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 27 | let mut res = HashMap::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/computing/solve.rs:30:46 [INFO] [stderr] | [INFO] [stderr] 30 | let top = res.entry(country.clone()).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/computing/solve.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn ratio(data: &Vec) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[City]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/saver.rs:8:33 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn save_millionaires(data: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 8 | pub fn save_millionaires(data: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | let client = Client::connect("localhost", 27017) [INFO] [stderr] | __________________^ [INFO] [stderr] 10 | | .ok().expect("Failed to initialize client."); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / coll.delete_many(doc!{}, None) [INFO] [stderr] 17 | | .ok().expect("Failed to delete documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / coll.insert_many(records, None) [INFO] [stderr] 32 | | .ok().expect("Failed to insert documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/saver.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn save_top(data: &HashMap>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 35 | pub fn save_top(data: &HashMap, S>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | let client = Client::connect("localhost", 27017) [INFO] [stderr] | __________________^ [INFO] [stderr] 37 | | .ok().expect("Failed to initialize client."); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / coll.delete_many(doc!{}, None) [INFO] [stderr] 43 | | .ok().expect("Failed to delete documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:48:60 [INFO] [stderr] | [INFO] [stderr] 48 | let info: Vec<_> = cities.iter().map(|city: &City| bson::to_bson(city).ok().expect("")).collect(); // [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / coll.insert_many(records, None) [INFO] [stderr] 57 | | .ok().expect("Failed to insert documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/saver.rs:60:31 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn save_population(data: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 60 | pub fn save_population(data: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | let client = Client::connect("localhost", 27017) [INFO] [stderr] | __________________^ [INFO] [stderr] 62 | | .ok().expect("Failed to initialize client."); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / coll.delete_many(doc!{}, None) [INFO] [stderr] 68 | | .ok().expect("Failed to delete documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / coll.insert_many(records, None) [INFO] [stderr] 82 | | .ok().expect("Failed to insert documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/saver.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn save_ratio(data: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 85 | pub fn save_ratio(data: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | let client = Client::connect("localhost", 27017) [INFO] [stderr] | __________________^ [INFO] [stderr] 87 | | .ok().expect("Failed to initialize client."); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / coll.delete_many(doc!{}, None) [INFO] [stderr] 93 | | .ok().expect("Failed to delete documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / coll.insert_many(records, None) [INFO] [stderr] 107 | | .ok().expect("Failed to insert documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/app.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | Err(_) => { panic!("ooops") }, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/app.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | Err(_) => { panic!("ooops") }, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/app.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | Err(_) => { panic!("ooops") }, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/app.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | Err(_) => { panic!("ooops") }, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/computing/loader.rs:39:53 [INFO] [stderr] | [INFO] [stderr] 39 | let city = checker.entry(city_name.clone()).or_insert(val.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| val.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/computing/loader.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | let f_records: Vec = records.iter() [INFO] [stderr] | ________________________________^ [INFO] [stderr] 54 | | .filter(|city| city.get_part() == 'f') [INFO] [stderr] 55 | | .map(|city| city.clone()) [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 53 | let f_records: Vec = records.iter() [INFO] [stderr] 54 | .filter(|city| city.get_part() == 'f').cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/computing/loader.rs:57:32 [INFO] [stderr] | [INFO] [stderr] 57 | let m_records: Vec = records.iter() [INFO] [stderr] | ________________________________^ [INFO] [stderr] 58 | | .filter(|city| city.get_part() == 'm') [INFO] [stderr] 59 | | .map(|city| city.clone()) [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 57 | let m_records: Vec = records.iter() [INFO] [stderr] 58 | .filter(|city| city.get_part() == 'm').cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/computing/loader.rs:70:51 [INFO] [stderr] | [INFO] [stderr] 70 | let vector = res.entry(val.get_country()).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/solve.rs:4:33 [INFO] [stderr] | [INFO] [stderr] 4 | pub fn millionaires(countries: &HashMap>, level: f64) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 4 | pub fn millionaires(countries: &HashMap, S>, level: f64) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/solve.rs:15:31 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn population(countries: &HashMap>) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 15 | pub fn population(countries: &HashMap, S>) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/solve.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | pub fn top(countries: &HashMap>, n: usize) -> HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 26 | pub fn top(countries: &HashMap, S>, n: usize) -> HashMap> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 27 | let mut res = HashMap::default(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/computing/solve.rs:30:46 [INFO] [stderr] | [INFO] [stderr] 30 | let top = res.entry(country.clone()).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/computing/solve.rs:39:20 [INFO] [stderr] | [INFO] [stderr] 39 | pub fn ratio(data: &Vec) -> HashMap { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[City]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/saver.rs:8:33 [INFO] [stderr] | [INFO] [stderr] 8 | pub fn save_millionaires(data: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 8 | pub fn save_millionaires(data: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:9:18 [INFO] [stderr] | [INFO] [stderr] 9 | let client = Client::connect("localhost", 27017) [INFO] [stderr] | __________________^ [INFO] [stderr] 10 | | .ok().expect("Failed to initialize client."); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / coll.delete_many(doc!{}, None) [INFO] [stderr] 17 | | .ok().expect("Failed to delete documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / coll.insert_many(records, None) [INFO] [stderr] 32 | | .ok().expect("Failed to insert documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/saver.rs:35:24 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn save_top(data: &HashMap>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 35 | pub fn save_top(data: &HashMap, S>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | let client = Client::connect("localhost", 27017) [INFO] [stderr] | __________________^ [INFO] [stderr] 37 | | .ok().expect("Failed to initialize client."); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / coll.delete_many(doc!{}, None) [INFO] [stderr] 43 | | .ok().expect("Failed to delete documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:48:60 [INFO] [stderr] | [INFO] [stderr] 48 | let info: Vec<_> = cities.iter().map(|city: &City| bson::to_bson(city).ok().expect("")).collect(); // [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | / coll.insert_many(records, None) [INFO] [stderr] 57 | | .ok().expect("Failed to insert documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/saver.rs:60:31 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn save_population(data: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 60 | pub fn save_population(data: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | let client = Client::connect("localhost", 27017) [INFO] [stderr] | __________________^ [INFO] [stderr] 62 | | .ok().expect("Failed to initialize client."); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:67:5 [INFO] [stderr] | [INFO] [stderr] 67 | / coll.delete_many(doc!{}, None) [INFO] [stderr] 68 | | .ok().expect("Failed to delete documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | / coll.insert_many(records, None) [INFO] [stderr] 82 | | .ok().expect("Failed to insert documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/computing/saver.rs:85:26 [INFO] [stderr] | [INFO] [stderr] 85 | pub fn save_ratio(data: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 85 | pub fn save_ratio(data: &HashMap) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:86:18 [INFO] [stderr] | [INFO] [stderr] 86 | let client = Client::connect("localhost", 27017) [INFO] [stderr] | __________________^ [INFO] [stderr] 87 | | .ok().expect("Failed to initialize client."); [INFO] [stderr] | |____________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | / coll.delete_many(doc!{}, None) [INFO] [stderr] 93 | | .ok().expect("Failed to delete documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/computing/saver.rs:106:5 [INFO] [stderr] | [INFO] [stderr] 106 | / coll.insert_many(records, None) [INFO] [stderr] 107 | | .ok().expect("Failed to insert documents."); [INFO] [stderr] | |___________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.57s [INFO] running `"docker" "inspect" "ba265a9d3998273e1ffce1a088d0e554561307c5c155ef211f88fc83005fd0d5"` [INFO] running `"docker" "rm" "-f" "ba265a9d3998273e1ffce1a088d0e554561307c5c155ef211f88fc83005fd0d5"` [INFO] [stdout] ba265a9d3998273e1ffce1a088d0e554561307c5c155ef211f88fc83005fd0d5