[INFO] updating cached repository meamuri/optimization_methods [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/meamuri/optimization_methods [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/meamuri/optimization_methods" "work/ex/clippy-test-run/sources/stable/gh/meamuri/optimization_methods"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/meamuri/optimization_methods'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/meamuri/optimization_methods" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/meamuri/optimization_methods"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/meamuri/optimization_methods'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ebf50dd461de29582dfa3339acee7bd3750e6c01 [INFO] sha for GitHub repo meamuri/optimization_methods: ebf50dd461de29582dfa3339acee7bd3750e6c01 [INFO] validating manifest of meamuri/optimization_methods on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of meamuri/optimization_methods on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing meamuri/optimization_methods [INFO] finished frobbing meamuri/optimization_methods [INFO] frobbed toml for meamuri/optimization_methods written to work/ex/clippy-test-run/sources/stable/gh/meamuri/optimization_methods/Cargo.toml [INFO] started frobbing meamuri/optimization_methods [INFO] finished frobbing meamuri/optimization_methods [INFO] frobbed toml for meamuri/optimization_methods written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/meamuri/optimization_methods/Cargo.toml [INFO] crate meamuri/optimization_methods has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting meamuri/optimization_methods against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/meamuri/optimization_methods:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e1652acdb7670b285b7b3fe5def313227c786ce5b00804147d33acabecbed549 [INFO] running `"docker" "start" "-a" "e1652acdb7670b285b7b3fe5def313227c786ce5b00804147d33acabecbed549"` [INFO] [stderr] Checking optimization_methods v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/methods/multi_dim_methods/fastest_descent.rs:5:21 [INFO] [stderr] | [INFO] [stderr] 5 | let (mut a, mut b) = (-10_000.0, 10_000.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/methods/multi_dim_methods/fastest_descent.rs:5:21 [INFO] [stderr] | [INFO] [stderr] 5 | let (mut a, mut b) = (-10_000.0, 10_000.0); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/methods/single_dim_methods/parabolic.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 18 | | if i1 > i2 { [INFO] [stderr] 19 | | u3 = u2; [INFO] [stderr] 20 | | u2 = d; [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 17 | else if i1 > i2 { [INFO] [stderr] 18 | u3 = u2; [INFO] [stderr] 19 | u2 = d; [INFO] [stderr] 20 | } [INFO] [stderr] 21 | else if i2 > i3 { [INFO] [stderr] 22 | u1 = d; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/methods/single_dim_methods/parabolic.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 46 | | if f(u2 - eps) < i2{ [INFO] [stderr] 47 | | u2 -= eps; [INFO] [stderr] 48 | | } [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } // else [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 45 | else if f(u2 - eps) < i2{ [INFO] [stderr] 46 | u2 -= eps; [INFO] [stderr] 47 | } [INFO] [stderr] 48 | else if f(u2 + eps) < i2 { [INFO] [stderr] 49 | u2 += eps; [INFO] [stderr] 50 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/methods/single_dim_methods/parabolic.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 36 | | if i3 > i2 { [INFO] [stderr] 37 | | u1 = u2; [INFO] [stderr] 38 | | u2 = d; [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | else if i3 > i2 { [INFO] [stderr] 36 | u1 = u2; [INFO] [stderr] 37 | u2 = d; [INFO] [stderr] 38 | } [INFO] [stderr] 39 | else if i1 > i2 { [INFO] [stderr] 40 | u3 = d; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dialogs/mod.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | Ok(..) => return input, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dialogs/mod.rs:18:4 [INFO] [stderr] | [INFO] [stderr] 18 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dialogs/mod.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 20 | Err(..) => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/methods/single_dim_methods/parabolic.rs:17:18 [INFO] [stderr] | [INFO] [stderr] 17 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 18 | | if i1 > i2 { [INFO] [stderr] 19 | | u3 = u2; [INFO] [stderr] 20 | | u2 = d; [INFO] [stderr] ... | [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 17 | else if i1 > i2 { [INFO] [stderr] 18 | u3 = u2; [INFO] [stderr] 19 | u2 = d; [INFO] [stderr] 20 | } [INFO] [stderr] 21 | else if i2 > i3 { [INFO] [stderr] 22 | u1 = d; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/methods/single_dim_methods/parabolic.rs:45:14 [INFO] [stderr] | [INFO] [stderr] 45 | else { [INFO] [stderr] | ______________^ [INFO] [stderr] 46 | | if f(u2 - eps) < i2{ [INFO] [stderr] 47 | | u2 -= eps; [INFO] [stderr] 48 | | } [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } // else [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 45 | else if f(u2 - eps) < i2{ [INFO] [stderr] 46 | u2 -= eps; [INFO] [stderr] 47 | } [INFO] [stderr] 48 | else if f(u2 + eps) < i2 { [INFO] [stderr] 49 | u2 += eps; [INFO] [stderr] 50 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/methods/single_dim_methods/parabolic.rs:35:18 [INFO] [stderr] | [INFO] [stderr] 35 | else { [INFO] [stderr] | __________________^ [INFO] [stderr] 36 | | if i3 > i2 { [INFO] [stderr] 37 | | u1 = u2; [INFO] [stderr] 38 | | u2 = d; [INFO] [stderr] ... | [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 35 | else if i3 > i2 { [INFO] [stderr] 36 | u1 = u2; [INFO] [stderr] 37 | u2 = d; [INFO] [stderr] 38 | } [INFO] [stderr] 39 | else if i1 > i2 { [INFO] [stderr] 40 | u3 = d; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dialogs/mod.rs:7:13 [INFO] [stderr] | [INFO] [stderr] 7 | Ok(..) => return input, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `input` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dialogs/mod.rs:18:4 [INFO] [stderr] | [INFO] [stderr] 18 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/dialogs/mod.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 20 | Err(..) => return false, [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.51s [INFO] running `"docker" "inspect" "e1652acdb7670b285b7b3fe5def313227c786ce5b00804147d33acabecbed549"` [INFO] running `"docker" "rm" "-f" "e1652acdb7670b285b7b3fe5def313227c786ce5b00804147d33acabecbed549"` [INFO] [stdout] e1652acdb7670b285b7b3fe5def313227c786ce5b00804147d33acabecbed549