[INFO] updating cached repository mdsn/cryptopals [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mdsn/cryptopals [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mdsn/cryptopals" "work/ex/clippy-test-run/sources/stable/gh/mdsn/cryptopals"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mdsn/cryptopals'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mdsn/cryptopals" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mdsn/cryptopals"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mdsn/cryptopals'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a353477bd5864a5a204b441e286ceff09538759f [INFO] sha for GitHub repo mdsn/cryptopals: a353477bd5864a5a204b441e286ceff09538759f [INFO] validating manifest of mdsn/cryptopals on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mdsn/cryptopals on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mdsn/cryptopals [INFO] finished frobbing mdsn/cryptopals [INFO] frobbed toml for mdsn/cryptopals written to work/ex/clippy-test-run/sources/stable/gh/mdsn/cryptopals/Cargo.toml [INFO] started frobbing mdsn/cryptopals [INFO] finished frobbing mdsn/cryptopals [INFO] frobbed toml for mdsn/cryptopals written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mdsn/cryptopals/Cargo.toml [INFO] crate mdsn/cryptopals has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mdsn/cryptopals against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mdsn/cryptopals:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 09f6a355ff361b11180259f2576180de7ff35c986741c027747e8367df585fa7 [INFO] running `"docker" "start" "-a" "09f6a355ff361b11180259f2576180de7ff35c986741c027747e8367df585fa7"` [INFO] [stderr] Checking cryptopals v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: item `Bytes` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / impl Bytes { [INFO] [stderr] 52 | | pub fn len(&self) -> usize { [INFO] [stderr] 53 | | self.m.len() [INFO] [stderr] 54 | | } [INFO] [stderr] ... | [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / pub fn from_str(s: &str) -> Bytes { [INFO] [stderr] 69 | | Bytes { [INFO] [stderr] 70 | | m: Vec::from(s.as_bytes()), [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:135:40 [INFO] [stderr] | [INFO] [stderr] 135 | .map(|&x| (0..=7).map(|i| (x as u32 & 2_u32.pow(i)) >> i).sum::()) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:166:8 [INFO] [stderr] | [INFO] [stderr] 166 | if scores.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!scores.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `Bytes` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:51:1 [INFO] [stderr] | [INFO] [stderr] 51 | / impl Bytes { [INFO] [stderr] 52 | | pub fn len(&self) -> usize { [INFO] [stderr] 53 | | self.m.len() [INFO] [stderr] 54 | | } [INFO] [stderr] ... | [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / pub fn from_str(s: &str) -> Bytes { [INFO] [stderr] 69 | | Bytes { [INFO] [stderr] 70 | | m: Vec::from(s.as_bytes()), [INFO] [stderr] 71 | | } [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:135:40 [INFO] [stderr] | [INFO] [stderr] 135 | .map(|&x| (0..=7).map(|i| (x as u32 & 2_u32.pow(i)) >> i).sum::()) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:166:8 [INFO] [stderr] | [INFO] [stderr] 166 | if scores.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!scores.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / match break_single_byte_xor(&payload) { [INFO] [stderr] 32 | | Some((_, broken)) => assert_eq!("Cooking MC's like a pound of bacon", broken), [INFO] [stderr] 33 | | None => {} [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some((_, broken)) = break_single_byte_xor(&payload) { assert_eq!("Cooking MC's like a pound of bacon", broken) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / match break_single_byte_xor(&payload) { [INFO] [stderr] 32 | | Some((_, broken)) => assert_eq!("Cooking MC's like a pound of bacon", broken), [INFO] [stderr] 33 | | None => {} [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some((_, broken)) = break_single_byte_xor(&payload) { assert_eq!("Cooking MC's like a pound of bacon", broken) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.18s [INFO] running `"docker" "inspect" "09f6a355ff361b11180259f2576180de7ff35c986741c027747e8367df585fa7"` [INFO] running `"docker" "rm" "-f" "09f6a355ff361b11180259f2576180de7ff35c986741c027747e8367df585fa7"` [INFO] [stdout] 09f6a355ff361b11180259f2576180de7ff35c986741c027747e8367df585fa7