[INFO] updating cached repository mdelaney/rust-algorithm-play [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mdelaney/rust-algorithm-play [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mdelaney/rust-algorithm-play" "work/ex/clippy-test-run/sources/stable/gh/mdelaney/rust-algorithm-play"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mdelaney/rust-algorithm-play'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mdelaney/rust-algorithm-play" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mdelaney/rust-algorithm-play"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mdelaney/rust-algorithm-play'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 508dcee6b9f844746801aafb8fbc164d6dc1cedd [INFO] sha for GitHub repo mdelaney/rust-algorithm-play: 508dcee6b9f844746801aafb8fbc164d6dc1cedd [INFO] validating manifest of mdelaney/rust-algorithm-play on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mdelaney/rust-algorithm-play on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mdelaney/rust-algorithm-play [INFO] finished frobbing mdelaney/rust-algorithm-play [INFO] frobbed toml for mdelaney/rust-algorithm-play written to work/ex/clippy-test-run/sources/stable/gh/mdelaney/rust-algorithm-play/Cargo.toml [INFO] started frobbing mdelaney/rust-algorithm-play [INFO] finished frobbing mdelaney/rust-algorithm-play [INFO] frobbed toml for mdelaney/rust-algorithm-play written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mdelaney/rust-algorithm-play/Cargo.toml [INFO] crate mdelaney/rust-algorithm-play has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mdelaney/rust-algorithm-play against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mdelaney/rust-algorithm-play:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 879f5316e988c92126d0453e87131e606bec9cf659ac2b4aad10a30060ed81b1 [INFO] running `"docker" "start" "-a" "879f5316e988c92126d0453e87131e606bec9cf659ac2b4aad10a30060ed81b1"` [INFO] [stderr] Checking algorithm-play v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/strings/edit_distance.rs:1:32 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn levenshtein_distance(a: &String, b: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/strings/edit_distance.rs:1:44 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn levenshtein_distance(a: &String, b: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/strings/edit_distance.rs:4:34 [INFO] [stderr] | [INFO] [stderr] 4 | let mut result: Vec = (0..str_a.len() + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=str_a.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/strings/edit_distance.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | for row in 1..str_b.len()+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `1..=str_b.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/strings/edit_distance.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | for col in 1..str_a.len()+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `1..=str_a.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/strings/edit_distance.rs:1:32 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn levenshtein_distance(a: &String, b: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/strings/edit_distance.rs:1:44 [INFO] [stderr] | [INFO] [stderr] 1 | pub fn levenshtein_distance(a: &String, b: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/strings/edit_distance.rs:4:34 [INFO] [stderr] | [INFO] [stderr] 4 | let mut result: Vec = (0..str_a.len() + 1).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: use: `(0..=str_a.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/strings/edit_distance.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | for row in 1..str_b.len()+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `1..=str_b.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/strings/edit_distance.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | for col in 1..str_a.len()+1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `1..=str_a.len()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.83s [INFO] running `"docker" "inspect" "879f5316e988c92126d0453e87131e606bec9cf659ac2b4aad10a30060ed81b1"` [INFO] running `"docker" "rm" "-f" "879f5316e988c92126d0453e87131e606bec9cf659ac2b4aad10a30060ed81b1"` [INFO] [stdout] 879f5316e988c92126d0453e87131e606bec9cf659ac2b4aad10a30060ed81b1