[INFO] updating cached repository mdaffin/scribe [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mdaffin/scribe [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mdaffin/scribe" "work/ex/clippy-test-run/sources/stable/gh/mdaffin/scribe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mdaffin/scribe'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mdaffin/scribe" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mdaffin/scribe"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mdaffin/scribe'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bd1bdf1431d676f55cac0126ebcf25841c89f3c3 [INFO] sha for GitHub repo mdaffin/scribe: bd1bdf1431d676f55cac0126ebcf25841c89f3c3 [INFO] validating manifest of mdaffin/scribe on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mdaffin/scribe on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mdaffin/scribe [INFO] finished frobbing mdaffin/scribe [INFO] frobbed toml for mdaffin/scribe written to work/ex/clippy-test-run/sources/stable/gh/mdaffin/scribe/Cargo.toml [INFO] started frobbing mdaffin/scribe [INFO] finished frobbing mdaffin/scribe [INFO] frobbed toml for mdaffin/scribe written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mdaffin/scribe/Cargo.toml [INFO] crate mdaffin/scribe has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mdaffin/scribe against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mdaffin/scribe:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d8f53d67d50d207abdb140f8d791c5799208af0cae05c9fbadd05029844d3e38 [INFO] running `"docker" "start" "-a" "d8f53d67d50d207abdb140f8d791c5799208af0cae05c9fbadd05029844d3e38"` [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking chrono v0.4.3 [INFO] [stderr] Checking simplelog v0.5.2 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking scribe v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `ExternalDrive` [INFO] [stderr] --> src/block_dev.rs:49:5 [INFO] [stderr] | [INFO] [stderr] 49 | ExternalDrive, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/block_dev.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / pub fn label<'a>(&'a self) -> &'a str { [INFO] [stderr] 130 | | &self.label [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/block_dev.rs:182:20 [INFO] [stderr] | [INFO] [stderr] 182 | pub fn is_safe(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/block_dev.rs:194:24 [INFO] [stderr] | [INFO] [stderr] 194 | pub fn is_excluded(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/block_dev.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | .any(|(dev, _)| { [INFO] [stderr] | _________________________^ [INFO] [stderr] 212 | | let dev_name = blkdev.dev_file(); [INFO] [stderr] 213 | | let dev_name = dev_name.to_str().expect("none unicode char in device path"); [INFO] [stderr] 214 | | let part_name = PathBuf::from(dev); [INFO] [stderr] ... | [INFO] [stderr] 217 | | part_name.starts_with(dev_name) [INFO] [stderr] 218 | | }) { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/block_dev.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | / loop { [INFO] [stderr] 249 | | return match self.inner.next() { [INFO] [stderr] 250 | | Some(Ok(dir)) => { [INFO] [stderr] 251 | | let mut blkdev = BlockDevice::new(dir.path()); [INFO] [stderr] ... | [INFO] [stderr] 261 | | }; [INFO] [stderr] 262 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/block_dev.rs:259:44 [INFO] [stderr] | [INFO] [stderr] 259 | Some(Err(err)) => Some(Err(err.into())), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/block_dev.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | 0...1024 => format!("{}", size), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/block_dev.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | 1024...1_048_576 => format!("{:.*}KiB", decimals, size as f64 / 1024.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/block_dev.rs:313:14 [INFO] [stderr] | [INFO] [stderr] 313 | &format!( [INFO] [stderr] | ______________^ [INFO] [stderr] 314 | | "{}", [INFO] [stderr] 315 | | match self { [INFO] [stderr] 316 | | DeviceType::FlashDrive => "Flash Drive", [INFO] [stderr] ... | [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | ), [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( match self { [INFO] [stderr] 3 | DeviceType::FlashDrive => "Flash Drive", [INFO] [stderr] 4 | DeviceType::SDMMC => "SD/MMC Card", [INFO] [stderr] 5 | DeviceType::InternalDrive => "Internal Drive", [INFO] [stderr] 6 | DeviceType::ExternalDrive => "External Drive", [INFO] [stderr] 7 | DeviceType::CDROM => "CD-ROM", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/block_dev.rs:333:14 [INFO] [stderr] | [INFO] [stderr] 333 | &format!( [INFO] [stderr] | ______________^ [INFO] [stderr] 334 | | "{}", [INFO] [stderr] 335 | | match self { [INFO] [stderr] 336 | | Flags::Mounted => "mounted", [INFO] [stderr] ... | [INFO] [stderr] 340 | | } [INFO] [stderr] 341 | | ), [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( match self { [INFO] [stderr] 3 | Flags::Mounted => "mounted", [INFO] [stderr] 4 | Flags::ZeroSize => "zero-size", [INFO] [stderr] 5 | Flags::ReadOnly => "read-only", [INFO] [stderr] 6 | Flags::Large => "large", [INFO] [stderr] 7 | }.to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:32:59 [INFO] [stderr] | [INFO] [stderr] 32 | && (show_all || blkdev.device_type().is_safe() && blkdev.flags().len() == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `blkdev.flags().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `scribe`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/block_dev.rs:129:5 [INFO] [stderr] | [INFO] [stderr] 129 | / pub fn label<'a>(&'a self) -> &'a str { [INFO] [stderr] 130 | | &self.label [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/block_dev.rs:182:20 [INFO] [stderr] | [INFO] [stderr] 182 | pub fn is_safe(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/block_dev.rs:194:24 [INFO] [stderr] | [INFO] [stderr] 194 | pub fn is_excluded(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/block_dev.rs:211:25 [INFO] [stderr] | [INFO] [stderr] 211 | .any(|(dev, _)| { [INFO] [stderr] | _________________________^ [INFO] [stderr] 212 | | let dev_name = blkdev.dev_file(); [INFO] [stderr] 213 | | let dev_name = dev_name.to_str().expect("none unicode char in device path"); [INFO] [stderr] 214 | | let part_name = PathBuf::from(dev); [INFO] [stderr] ... | [INFO] [stderr] 217 | | part_name.starts_with(dev_name) [INFO] [stderr] 218 | | }) { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/block_dev.rs:248:9 [INFO] [stderr] | [INFO] [stderr] 248 | / loop { [INFO] [stderr] 249 | | return match self.inner.next() { [INFO] [stderr] 250 | | Some(Ok(dir)) => { [INFO] [stderr] 251 | | let mut blkdev = BlockDevice::new(dir.path()); [INFO] [stderr] ... | [INFO] [stderr] 261 | | }; [INFO] [stderr] 262 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/block_dev.rs:259:44 [INFO] [stderr] | [INFO] [stderr] 259 | Some(Err(err)) => Some(Err(err.into())), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `err` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: some ranges overlap [INFO] [stderr] --> src/block_dev.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | 0...1024 => format!("{}", size), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_overlapping_arm)] on by default [INFO] [stderr] note: overlaps with this [INFO] [stderr] --> src/block_dev.rs:297:13 [INFO] [stderr] | [INFO] [stderr] 297 | 1024...1_048_576 => format!("{:.*}KiB", decimals, size as f64 / 1024.0), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_overlapping_arm [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/block_dev.rs:313:14 [INFO] [stderr] | [INFO] [stderr] 313 | &format!( [INFO] [stderr] | ______________^ [INFO] [stderr] 314 | | "{}", [INFO] [stderr] 315 | | match self { [INFO] [stderr] 316 | | DeviceType::FlashDrive => "Flash Drive", [INFO] [stderr] ... | [INFO] [stderr] 322 | | } [INFO] [stderr] 323 | | ), [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( match self { [INFO] [stderr] 3 | DeviceType::FlashDrive => "Flash Drive", [INFO] [stderr] 4 | DeviceType::SDMMC => "SD/MMC Card", [INFO] [stderr] 5 | DeviceType::InternalDrive => "Internal Drive", [INFO] [stderr] 6 | DeviceType::ExternalDrive => "External Drive", [INFO] [stderr] 7 | DeviceType::CDROM => "CD-ROM", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/block_dev.rs:333:14 [INFO] [stderr] | [INFO] [stderr] 333 | &format!( [INFO] [stderr] | ______________^ [INFO] [stderr] 334 | | "{}", [INFO] [stderr] 335 | | match self { [INFO] [stderr] 336 | | Flags::Mounted => "mounted", [INFO] [stderr] ... | [INFO] [stderr] 340 | | } [INFO] [stderr] 341 | | ), [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 2 | $ crate :: fmt :: format ( match self { [INFO] [stderr] 3 | Flags::Mounted => "mounted", [INFO] [stderr] 4 | Flags::ZeroSize => "zero-size", [INFO] [stderr] 5 | Flags::ReadOnly => "read-only", [INFO] [stderr] 6 | Flags::Large => "large", [INFO] [stderr] 7 | }.to_string() ) ) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/block_dev.rs:367:13 [INFO] [stderr] | [INFO] [stderr] 367 | run_checks(&mut blkdev); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/block_dev.rs:391:29 [INFO] [stderr] | [INFO] [stderr] 391 | .filter(|x| x.trim().len() > 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.trim().is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:32:59 [INFO] [stderr] | [INFO] [stderr] 32 | && (show_all || blkdev.device_type().is_safe() && blkdev.flags().len() == 0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `blkdev.flags().is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `scribe`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d8f53d67d50d207abdb140f8d791c5799208af0cae05c9fbadd05029844d3e38"` [INFO] running `"docker" "rm" "-f" "d8f53d67d50d207abdb140f8d791c5799208af0cae05c9fbadd05029844d3e38"` [INFO] [stdout] d8f53d67d50d207abdb140f8d791c5799208af0cae05c9fbadd05029844d3e38