[INFO] updating cached repository mcoffin/eachline [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mcoffin/eachline [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mcoffin/eachline" "work/ex/clippy-test-run/sources/stable/gh/mcoffin/eachline"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mcoffin/eachline'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mcoffin/eachline" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcoffin/eachline"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcoffin/eachline'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 447df08029dfa6486939534ee63fa87f8a6c517b [INFO] sha for GitHub repo mcoffin/eachline: 447df08029dfa6486939534ee63fa87f8a6c517b [INFO] validating manifest of mcoffin/eachline on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mcoffin/eachline on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mcoffin/eachline [INFO] finished frobbing mcoffin/eachline [INFO] frobbed toml for mcoffin/eachline written to work/ex/clippy-test-run/sources/stable/gh/mcoffin/eachline/Cargo.toml [INFO] started frobbing mcoffin/eachline [INFO] finished frobbing mcoffin/eachline [INFO] frobbed toml for mcoffin/eachline written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mcoffin/eachline/Cargo.toml [INFO] crate mcoffin/eachline has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mcoffin/eachline against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mcoffin/eachline:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f7558f56300e652c479c9b38b41e3aebb260a1036fafb639a9742e8c0690f82 [INFO] running `"docker" "start" "-a" "9f7558f56300e652c479c9b38b41e3aebb260a1036fafb639a9742e8c0690f82"` [INFO] [stderr] Checking eachline v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | const ERROR_NO_COMMAND: &'static str = "You must supply a command argument"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | const ERROR_NO_COMMAND: &'static str = "You must supply a command argument"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | fn exit_status_result(status: &process::ExitStatus) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `process::ExitStatus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | None => format!("Child process terminated by signal"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Child process terminated by signal".to_string()` [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | fn exit_status_result(status: &process::ExitStatus) -> Result<(), String> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `process::ExitStatus` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:25:21 [INFO] [stderr] | [INFO] [stderr] 25 | None => format!("Child process terminated by signal"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Child process terminated by signal".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.22s [INFO] running `"docker" "inspect" "9f7558f56300e652c479c9b38b41e3aebb260a1036fafb639a9742e8c0690f82"` [INFO] running `"docker" "rm" "-f" "9f7558f56300e652c479c9b38b41e3aebb260a1036fafb639a9742e8c0690f82"` [INFO] [stdout] 9f7558f56300e652c479c9b38b41e3aebb260a1036fafb639a9742e8c0690f82