[INFO] updating cached repository mclaybaugh/rust-text-canvas [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/mclaybaugh/rust-text-canvas [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/mclaybaugh/rust-text-canvas" "work/ex/clippy-test-run/sources/stable/gh/mclaybaugh/rust-text-canvas"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/mclaybaugh/rust-text-canvas'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/mclaybaugh/rust-text-canvas" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mclaybaugh/rust-text-canvas"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mclaybaugh/rust-text-canvas'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bbbe8f7d88b0bd6682cfe24573e9f3eb87beb77b [INFO] sha for GitHub repo mclaybaugh/rust-text-canvas: bbbe8f7d88b0bd6682cfe24573e9f3eb87beb77b [INFO] validating manifest of mclaybaugh/rust-text-canvas on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of mclaybaugh/rust-text-canvas on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing mclaybaugh/rust-text-canvas [INFO] finished frobbing mclaybaugh/rust-text-canvas [INFO] frobbed toml for mclaybaugh/rust-text-canvas written to work/ex/clippy-test-run/sources/stable/gh/mclaybaugh/rust-text-canvas/Cargo.toml [INFO] started frobbing mclaybaugh/rust-text-canvas [INFO] finished frobbing mclaybaugh/rust-text-canvas [INFO] frobbed toml for mclaybaugh/rust-text-canvas written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/mclaybaugh/rust-text-canvas/Cargo.toml [INFO] crate mclaybaugh/rust-text-canvas has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting mclaybaugh/rust-text-canvas against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/mclaybaugh/rust-text-canvas:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4ea71494acbd718b172d3ecc81803c100cdb540b7130c629a0a88db872005c74 [INFO] running `"docker" "start" "-a" "4ea71494acbd718b172d3ecc81803c100cdb540b7130c629a0a88db872005c74"` [INFO] [stderr] Checking rust-text-canvas v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/terminal.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/terminal.rs:64:9 [INFO] [stderr] | [INFO] [stderr] 64 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/terminal.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / return match color { [INFO] [stderr] 11 | | canvas::Color::Normal => "\x1B[0m", [INFO] [stderr] 12 | | canvas::Color::Black => "\x1B[30m", [INFO] [stderr] 13 | | canvas::Color::Red => "\x1B[31m", [INFO] [stderr] ... | [INFO] [stderr] 27 | | canvas::Color::BrightWhite => "\x1B[37;1m" [INFO] [stderr] 28 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 10 | match color { [INFO] [stderr] 11 | canvas::Color::Normal => "\x1B[0m", [INFO] [stderr] 12 | canvas::Color::Black => "\x1B[30m", [INFO] [stderr] 13 | canvas::Color::Red => "\x1B[31m", [INFO] [stderr] 14 | canvas::Color::Green => "\x1B[32m", [INFO] [stderr] 15 | canvas::Color::Yellow => "\x1B[33m", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/terminal.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / return match color { [INFO] [stderr] 33 | | canvas::Color::Normal => "\x1B[0m", [INFO] [stderr] 34 | | canvas::Color::Black => "\x1B[40m", [INFO] [stderr] 35 | | canvas::Color::Red => "\x1B[41m", [INFO] [stderr] ... | [INFO] [stderr] 49 | | canvas::Color::BrightWhite => "\x1B[47;1m" [INFO] [stderr] 50 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 32 | match color { [INFO] [stderr] 33 | canvas::Color::Normal => "\x1B[0m", [INFO] [stderr] 34 | canvas::Color::Black => "\x1B[40m", [INFO] [stderr] 35 | canvas::Color::Red => "\x1B[41m", [INFO] [stderr] 36 | canvas::Color::Green => "\x1B[42m", [INFO] [stderr] 37 | canvas::Color::Yellow => "\x1B[43m", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Black` [INFO] [stderr] --> src/canvas.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | Black, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Red` [INFO] [stderr] --> src/canvas.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | Red, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Green` [INFO] [stderr] --> src/canvas.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | Green, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Yellow` [INFO] [stderr] --> src/canvas.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Yellow, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Blue` [INFO] [stderr] --> src/canvas.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | Blue, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Magenta` [INFO] [stderr] --> src/canvas.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Magenta, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Cyan` [INFO] [stderr] --> src/canvas.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Cyan, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `White` [INFO] [stderr] --> src/canvas.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | White, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightBlack` [INFO] [stderr] --> src/canvas.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | BrightBlack, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightRed` [INFO] [stderr] --> src/canvas.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | BrightRed, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightGreen` [INFO] [stderr] --> src/canvas.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | BrightGreen, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightYellow` [INFO] [stderr] --> src/canvas.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | BrightYellow, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightBlue` [INFO] [stderr] --> src/canvas.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | BrightBlue, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightMagenta` [INFO] [stderr] --> src/canvas.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | BrightMagenta, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightCyan` [INFO] [stderr] --> src/canvas.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | BrightCyan, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightWhite` [INFO] [stderr] --> src/canvas.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | BrightWhite [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Coord` [INFO] [stderr] --> src/canvas.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | pub struct Coord { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `TextSprite` [INFO] [stderr] --> src/canvas.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | pub struct TextSprite { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_bg_term_color` [INFO] [stderr] --> src/terminal.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | fn get_bg_term_color(color: &canvas::Color) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/terminal.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / return match color { [INFO] [stderr] 11 | | canvas::Color::Normal => "\x1B[0m", [INFO] [stderr] 12 | | canvas::Color::Black => "\x1B[30m", [INFO] [stderr] 13 | | canvas::Color::Red => "\x1B[31m", [INFO] [stderr] ... | [INFO] [stderr] 27 | | canvas::Color::BrightWhite => "\x1B[37;1m" [INFO] [stderr] 28 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 10 | match color { [INFO] [stderr] 11 | canvas::Color::Normal => "\x1B[0m", [INFO] [stderr] 12 | canvas::Color::Black => "\x1B[30m", [INFO] [stderr] 13 | canvas::Color::Red => "\x1B[31m", [INFO] [stderr] 14 | canvas::Color::Green => "\x1B[32m", [INFO] [stderr] 15 | canvas::Color::Yellow => "\x1B[33m", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/terminal.rs:32:5 [INFO] [stderr] | [INFO] [stderr] 32 | / return match color { [INFO] [stderr] 33 | | canvas::Color::Normal => "\x1B[0m", [INFO] [stderr] 34 | | canvas::Color::Black => "\x1B[40m", [INFO] [stderr] 35 | | canvas::Color::Red => "\x1B[41m", [INFO] [stderr] ... | [INFO] [stderr] 49 | | canvas::Color::BrightWhite => "\x1B[47;1m" [INFO] [stderr] 50 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 32 | match color { [INFO] [stderr] 33 | canvas::Color::Normal => "\x1B[0m", [INFO] [stderr] 34 | canvas::Color::Black => "\x1B[40m", [INFO] [stderr] 35 | canvas::Color::Red => "\x1B[41m", [INFO] [stderr] 36 | canvas::Color::Green => "\x1B[42m", [INFO] [stderr] 37 | canvas::Color::Yellow => "\x1B[43m", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Black` [INFO] [stderr] --> src/canvas.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | Black, [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Red` [INFO] [stderr] --> src/canvas.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | Red, [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Green` [INFO] [stderr] --> src/canvas.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | Green, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Yellow` [INFO] [stderr] --> src/canvas.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | Yellow, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Blue` [INFO] [stderr] --> src/canvas.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | Blue, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Magenta` [INFO] [stderr] --> src/canvas.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | Magenta, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Cyan` [INFO] [stderr] --> src/canvas.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Cyan, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `White` [INFO] [stderr] --> src/canvas.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | White, [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightBlack` [INFO] [stderr] --> src/canvas.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | BrightBlack, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightRed` [INFO] [stderr] --> src/canvas.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | BrightRed, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightGreen` [INFO] [stderr] --> src/canvas.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | BrightGreen, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightYellow` [INFO] [stderr] --> src/canvas.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | BrightYellow, [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightBlue` [INFO] [stderr] --> src/canvas.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | BrightBlue, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightMagenta` [INFO] [stderr] --> src/canvas.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | BrightMagenta, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightCyan` [INFO] [stderr] --> src/canvas.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | BrightCyan, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `BrightWhite` [INFO] [stderr] --> src/canvas.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | BrightWhite [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Coord` [INFO] [stderr] --> src/canvas.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | pub struct Coord { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `TextSprite` [INFO] [stderr] --> src/canvas.rs:32:1 [INFO] [stderr] | [INFO] [stderr] 32 | pub struct TextSprite { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_bg_term_color` [INFO] [stderr] --> src/terminal.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | fn get_bg_term_color(color: &canvas::Color) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.48s [INFO] running `"docker" "inspect" "4ea71494acbd718b172d3ecc81803c100cdb540b7130c629a0a88db872005c74"` [INFO] running `"docker" "rm" "-f" "4ea71494acbd718b172d3ecc81803c100cdb540b7130c629a0a88db872005c74"` [INFO] [stdout] 4ea71494acbd718b172d3ecc81803c100cdb540b7130c629a0a88db872005c74